git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Richard Maw <richard.maw@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 2/7] Add git_configset_add_standard
Date: Sun, 13 Aug 2017 20:36:06 +0100	[thread overview]
Message-ID: <20170813193611.4233-3-richard.maw@gmail.com> (raw)
In-Reply-To: <20170813193611.4233-1-richard.maw@gmail.com>

This exposes implementation details of repo_read_config
so a configset can be populated with a repository's standard config,
without needing to create a full repository.

This allows config lookup to use the same codepath
whether the repository is ready or not,
which allows it to be used during git init.
---
 config.c | 7 ++++++-
 config.h | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/config.c b/config.c
index 231f9a7..d0af812 100644
--- a/config.c
+++ b/config.c
@@ -1764,6 +1764,11 @@ int git_configset_add_file(struct config_set *cs, const char *filename)
 	return git_config_from_file(config_set_callback, filename, cs);
 }
 
+int git_configset_add_standard(struct config_set *cs, const struct config_options *opts)
+{
+	return config_with_options(config_set_callback, cs, NULL, opts);
+}
+
 int git_configset_get_value(struct config_set *cs, const char *key, const char **value)
 {
 	const struct string_list *values = NULL;
@@ -1879,7 +1884,7 @@ static void repo_read_config(struct repository *repo)
 
 	git_configset_init(repo->config);
 
-	if (config_with_options(config_set_callback, repo->config, NULL, &opts) < 0)
+	if (git_configset_add_standard(repo->config, &opts) < 0)
 		/*
 		 * config_with_options() normally returns only
 		 * zero, as most errors are fatal, and
diff --git a/config.h b/config.h
index 0352da1..0b7b8d2 100644
--- a/config.h
+++ b/config.h
@@ -151,6 +151,7 @@ struct config_set {
 
 extern void git_configset_init(struct config_set *cs);
 extern int git_configset_add_file(struct config_set *cs, const char *filename);
+extern int git_configset_add_standard(struct config_set *cs, const struct config_options *opts);
 extern int git_configset_get_value(struct config_set *cs, const char *key, const char **value);
 extern const struct string_list *git_configset_get_value_multi(struct config_set *cs, const char *key);
 extern void git_configset_clear(struct config_set *cs);
-- 
2.9.0


  parent reply	other threads:[~2017-08-13 19:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-13 19:36 [RFC PATCH 0/7] Implement ref namespaces as a ref storage backend Richard Maw
2017-08-13 19:36 ` [PATCH 1/7] Expose expand_namespace API Richard Maw
2017-08-13 19:36 ` Richard Maw [this message]
2017-08-13 19:36 ` [PATCH 3/7] Add helper for skipping namespace prefixes Richard Maw
2017-08-13 19:36 ` [PATCH 4/7] Autocreate reflogs for namespaced refs Richard Maw
2017-08-13 19:36 ` [PATCH 5/7] Treat namespaced HEAD and refs/bisect as per-worktree Richard Maw
2017-08-13 19:36 ` [PATCH 6/7] Add namespaced ref backend Richard Maw
2017-08-13 19:36 ` [PATCH 7/7] Plumb in namespaced ref store Richard Maw
2017-08-14 17:00 ` [RFC PATCH 0/7] Implement ref namespaces as a ref storage backend Stefan Beller
2017-08-15 17:13 ` Junio C Hamano
2017-08-24 10:20   ` Richard Maw
2017-08-24 16:17 ` Michael Haggerty
2017-08-30 13:17   ` Richard Maw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170813193611.4233-3-richard.maw@gmail.com \
    --to=richard.maw@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).