On Sat, Aug 12, 2017 at 10:32:59AM +0200, René Scharfe wrote: > All callers of fill_tree_descriptor() have been converted to object_id > already, so convert that function as well. As a nice side-effect we get > rid of NULL checks in tree-diff.c, as fill_tree_descriptor() already > does them for us. > > Helped-by: Johannes Sixt > Signed-off-by: Rene Scharfe This looks good to me. I had written a very similar patch for a later series, and they're pretty much identical. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204