From: Yaroslav Halchenko <yoh@onerussian.com>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: fatal: Out of memory, getdelim failed under NFS mounts
Date: Thu, 10 Aug 2017 16:29:42 -0400 [thread overview]
Message-ID: <20170810202942.s232yr5stjxmmz4t@hopa.kiewit.dartmouth.edu> (raw)
In-Reply-To: <20170810200502.rutab4z3ft7gcpjz@sigill.intra.peff.net>
On Thu, 10 Aug 2017, Jeff King wrote:
> On Thu, Aug 10, 2017 at 09:58:37PM +0200, René Scharfe wrote:
> > > So the function is returning -1 and leaving ENOMEM in errno on
> > > Yaroslav's system.
> > > I wonder if we are truly hitting out of memory, though. The same
> > > symptom could bee seen if getdelim() does not touch errno when it
> > > returns -1, but some other system call earlier set it to ENOMEM,
> > > for example.
> > That can happen when the end of a file is reached; getdelim() returns
> > -1 and leaves errno unchanged. So we need to set errno to 0 just
> > before that call.
> Good catch. That's a bug in my original conversoin of
> strbuf_getwholeline().
I think this did it! at least on this simple test... yet to test a bit
more in those scenarios we ran into it before while testing git-annex.
commit 36ef5e3ad2c187d3be664c33dbc8c06e59bceaf4 (HEAD -> bf-seterrno0)
Author: Yaroslav O. Halchenko <yhalchen@smaug.cns.dartmouth.edu>
Date: Thu Aug 10 20:26:47 2017 +0000
BF: set errno to 0 before getdelim call to get unbiased assesment later
diff --git a/strbuf.c b/strbuf.c
index 89d22e3b0..323c49ceb 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -476,6 +476,7 @@ int strbuf_getwholeline(struct strbuf *sb, FILE *fp, int term)
/* Translate slopbuf to NULL, as we cannot call realloc on it */
if (!sb->alloc)
sb->buf = NULL;
+ errno = 0;
r = getdelim(&sb->buf, &sb->alloc, term, fp);
if (r > 0) {
--
Yaroslav O. Halchenko
Center for Open Neuroscience http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik
next prev parent reply other threads:[~2017-08-10 20:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 17:39 fatal: Out of memory, getdelim failed under NFS mounts Yaroslav Halchenko
2017-08-10 13:27 ` René Scharfe
2017-08-10 14:43 ` Yaroslav Halchenko
2017-08-10 19:44 ` René Scharfe
2017-08-10 18:56 ` Junio C Hamano
2017-08-10 19:44 ` Yaroslav Halchenko
2017-08-10 19:58 ` René Scharfe
2017-08-10 20:05 ` Jeff King
2017-08-10 20:29 ` Yaroslav Halchenko [this message]
2017-08-10 20:56 ` [PATCH] strbuf: clear errno before calling getdelim(3) René Scharfe
2017-08-10 21:02 ` Jeff King
2017-08-10 21:35 ` Yaroslav Halchenko
2017-08-10 21:41 ` Junio C Hamano
2017-08-11 7:50 ` Simon Ruderich
2017-08-11 8:52 ` René Scharfe
2017-08-12 10:02 ` Simon Ruderich
2017-08-12 11:57 ` René Scharfe
2017-08-12 12:21 ` René Scharfe
2017-08-13 4:32 ` Jeff King
2017-08-13 5:51 ` René Scharfe
2017-08-13 5:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810202942.s232yr5stjxmmz4t@hopa.kiewit.dartmouth.edu \
--to=yoh@onerussian.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).