git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger
Date: Wed, 9 Aug 2017 06:20:41 -0400	[thread overview]
Message-ID: <20170809102040.l5sb6ukqh2225zqm@sigill.intra.peff.net> (raw)
In-Reply-To: <20170808080620.9536-2-ijc@hellion.org.uk>

On Tue, Aug 08, 2017 at 09:06:20AM +0100, Ian Campbell wrote:

> Such as v2.6.12-rc2..v2.6.13-rc3 in the Linux kernel source tree.
> 
> Insert a fake tag header, since newer `git mktag` wont accept the input
> otherwise:

Hmm. Now your resulting tag will have this crufty "unknown@example.com"
header baked into it, won't it?

Should we instead make git-mktag more lenient (possibly with a
command-line option to reduce accidental omissions)?

-Peff

  parent reply	other threads:[~2017-08-09 10:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08  8:06 [PATCH 0/2] filter-branch: support for incremental update + fix for ancient tag format Ian Campbell
2017-08-08  8:06 ` [PATCH 1/2] filter-branch: Add --state-branch to hold pickled copy of ref map Ian Campbell
2017-08-08 20:56   ` Junio C Hamano
2017-08-09  7:57     ` Ian Campbell
2017-08-08  8:06 ` [PATCH 2/2] filter-branch: Handle rewritting (very) old style tags which lack tagger Ian Campbell
2017-08-08 21:00   ` Junio C Hamano
2017-08-09  7:43     ` Ian Campbell
2017-08-09 10:20   ` Jeff King [this message]
2017-08-09 15:50     ` Junio C Hamano
2017-08-09 19:02       ` Ian Campbell
2017-08-09 19:10         ` Junio C Hamano
2017-08-09 20:23         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809102040.l5sb6ukqh2225zqm@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ijc@hellion.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).