From: Jeff King <peff@peff.net>
To: Shawn Pearce <spearce@spearce.org>
Cc: "Ben Alex" <ben.alex@acegi.com.au>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git <git@vger.kernel.org>,
"Michael Haggerty" <mhagger@alum.mit.edu>,
"Junio C Hamano" <gitster@pobox.com>,
"David Borowitz" <dborowitz@google.com>,
"Stefan Beller" <sbeller@google.com>,
"David Turner" <David.Turner@twosigma.com>,
"Kristoffer Sjogren" <stoffe@gmail.com>
Subject: Re: reftable [v5]: new ref storage format
Date: Tue, 8 Aug 2017 03:38:06 -0400 [thread overview]
Message-ID: <20170808073806.ofrxcvgg3f6zaudu@sigill.intra.peff.net> (raw)
In-Reply-To: <CAJo=hJsEaKH40WnhxqvkASpiXnV8ipc+b1zrZ9VEjqRjpJ17Qg@mail.gmail.com>
On Mon, Aug 07, 2017 at 07:41:43AM -0700, Shawn Pearce wrote:
> > As such if JGit wanted to use a longer key size, it is possible to implement
> > similar automatic builds and packaging into JGit.
>
> I don't know if we need a larger key size. $DAY_JOB limits ref names
> to ~200 bytes in a hook. I think GitHub does similar. But I'm worried
> about the general masses who might be using our software and expect
> ref names thus far to be as long as PATH_MAX on their system. Most
> systems run PATH_MAX around 1024.
GitHub limits to 255 (for the fully-qualified name, so including
"refs/heads/"). I don't recall ever seeing any complaints about that,
though I suppose it's not out of the realm of possibility for somebody
with a multi-byte encoding to hit with a real name (it's configurable,
so I'm not sure if Enterprise customers in Asia might ever bump it). I
do think something like 1024 would be well into "you're insane if you
really want to name your branch this" territory.
-Peff
next prev parent reply other threads:[~2017-08-08 7:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 3:15 reftable [v5]: new ref storage format Shawn Pearce
2017-08-06 16:56 ` Ævar Arnfjörð Bjarmason
2017-08-06 22:56 ` Shawn Pearce
[not found] ` <CAOhB0ruYhGAyNn84ZjS7TH7QdwxNi2bPN8KFxEEBd58B9qVrmg@mail.gmail.com>
2017-08-07 14:41 ` Shawn Pearce
2017-08-07 15:40 ` David Turner
2017-08-08 7:52 ` Jeff King
2017-08-08 9:16 ` Shawn Pearce
2017-08-08 7:38 ` Jeff King [this message]
2017-08-09 11:18 ` Howard Chu
2017-08-14 12:30 ` Howard Chu
2017-08-14 16:05 ` David Turner
2017-08-15 3:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808073806.ofrxcvgg3f6zaudu@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=David.Turner@twosigma.com \
--cc=avarab@gmail.com \
--cc=ben.alex@acegi.com.au \
--cc=dborowitz@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=sbeller@google.com \
--cc=spearce@spearce.org \
--cc=stoffe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).