From: Prathamesh Chavan <pc44800@gmail.com>
To: git@vger.kernel.org
Cc: sbeller@google.com, christian.couder@gmail.com,
Prathamesh Chavan <pc44800@gmail.com>
Subject: [GSoC][PATCH 00/13] Update: Week-12
Date: Tue, 8 Aug 2017 02:48:47 +0530 [thread overview]
Message-ID: <20170807211900.15001-1-pc44800@gmail.com> (raw)
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase Git's portability
and hence the efficiency of working with the git-submodule commands.
Link to the complete proposal: [1]
Mentors:
Stefan Beller <sbeller@google.com>
Christian Couder <christian.couder@gmail.com>
UPDATES:
Following are the updates about my ongoing project:
* Following patches were updated after the previous reviews:
submodule subcommands:
- deinit
- summary
- foreach
* summary: the function print_submodule_summary() is split-up
into two separate functions: generate_submodule_summary()
and print_summary().
* porting of submodule subcommand 'add' is completed and I have
started with debugging ported function. Currently, the
entire function cmd_add() is ported to the function
module_add() in C. Soon, its first patch will be floated
here as well once debugging is completed. Its progress can be
viewed at [2].
* displaypath: Last week, there was some confusion produced
with the way, the value of displaypath is being generated,
which led to some discussion, which is available at: [3].
PLAN FOR WEEK-13 (8 August 2017 to 14 August 2017):
* patches: IMO, the patches till deinit are reviewed many times,
and hence will try to get at least these patches merged.
* add: As this subcommand is widely used in the test suite, there
are many tests this ported function is failing at. Hence,
debugging the subcommand would be another task for the next week.
* deinit: A bug was identified by Stefan in the last patch-series.
its details are available at: [4]
Currenlty, the bug was handled by adding a NEEDSWORK tagged
comment as suggest. If possible, I will also start working
on debugging the issue asap.
A complete build report of these series of patches is available at: [5].
Build #151
Branch: week-12
The work is pushed on Github and is available at: [6].
[1]: https://docs.google.com/document/d/1krxVLooWl--75Pot3dazhfygR3wCUUWZWzTXtK1L-xU/
[2]: https://github.com/pratham-pc/git/commits/sub-add
[3]: https://public-inbox.org/git/CAME+mvXsh53kLJ4se4uKY=SJcvSbHtEZQ6K2CgAPs=1wxUxk1A@mail.gmail.com/
[4]: https://public-inbox.org/git/CAGZ79kbyyR54me_+wQDZRrikqKTp_a98yozVfr8P85QHfyyy=Q@mail.gmail.com/
[5]: https://travis-ci.org/pratham-pc/git/builds/
[6]: https://github.com/pratham-pc/git/commits/week-12
Prathamesh Chavan (13):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_submodule_list()
submodule: port set_name_rev() from shell to C
submodule: port submodule subcommand 'status' from shell to C
submodule: port submodule subcommand 'sync' from shell to C
submodule: port submodule subcommand 'deinit' from shell to C
diff: change scope of the function count_lines()
submodule: port submodule subcommand 'summary' from shell to C
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path'
submodule foreach: clarify the '$toplevel' variable documentation
submodule foreach: document variable '$displaypath'
submodule: port submodule subcommand 'foreach' from shell to C
Documentation/git-submodule.txt | 15 +-
builtin/submodule--helper.c | 1190 ++++++++++++++++++++++++++++++++++++++-
diff.c | 2 +-
diff.h | 1 +
git-submodule.sh | 396 +------------
t/t7407-submodule-foreach.sh | 38 +-
6 files changed, 1222 insertions(+), 420 deletions(-)
--
2.13.0
next reply other threads:[~2017-08-07 21:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 21:18 Prathamesh Chavan [this message]
2017-08-07 21:18 ` [GSoC][PATCH 01/13] submodule--helper: introduce get_submodule_displaypath() Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 02/13] submodule--helper: introduce for_each_submodule_list() Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 03/13] submodule: port set_name_rev() from shell to C Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 04/13] submodule: port submodule subcommand 'status' " Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 05/13] submodule: port submodule subcommand 'sync' " Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 06/13] submodule: port submodule subcommand 'deinit' " Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 07/13] diff: change scope of the function count_lines() Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 08/13] submodule: port submodule subcommand 'summary' from shell to C Prathamesh Chavan
2017-08-07 21:43 ` Christian Couder
2017-08-07 21:18 ` [GSoC][PATCH 09/13] submodule foreach: correct '$path' in nested submodules from a subdirectory Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 10/13] submodule foreach: document '$sm_path' instead of '$path' Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 11/13] submodule foreach: clarify the '$toplevel' variable documentation Prathamesh Chavan
2017-08-07 21:18 ` [GSoC][PATCH 12/13] submodule foreach: document variable '$displaypath' Prathamesh Chavan
2017-08-07 21:19 ` [GSoC][PATCH 13/13] submodule: port submodule subcommand 'foreach' from shell to C Prathamesh Chavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807211900.15001-1-pc44800@gmail.com \
--to=pc44800@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).