From: Jeff King <peff@peff.net>
To: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH 1/4] imap-send: add wrapper to get server credentials if needed
Date: Mon, 7 Aug 2017 16:07:24 -0400 [thread overview]
Message-ID: <20170807200724.6pdfkmrrmmkdmmb6@sigill.intra.peff.net> (raw)
In-Reply-To: <a4761418-0464-baa1-b415-836f33503eb8@morey-chaisemartin.com>
On Mon, Aug 07, 2017 at 09:55:56PM +0200, Nicolas Morey-Chaisemartin wrote:
> > On the other hand, if we're hoping to get rid of this code in favor of
> > the curl-based approach, then it's not worth spending time on
> > cosmetic refactoring, as long as it still behaves correctly in the
> > interim.
>
> Looking at the code, it seems the tunnel mode always uses the legacy imap approach.
> This would have to be ported to curl and stabilized before dropping the legacy code.
Urgh. That's an important mode, I'd think, and one that I have a feeling
curl may not be interested in supporting, just because of it's
complexity. And even if they did, it would take a while for that curl
version to become available.
So maybe the idea of deprecating the non-curl implementation is not
something that can happen anytime soon. :(
> In the meantime, it might be worth doing a bit of cleanup.
In which case, yeah, it is definitely worth cleaning up the existing
code. But I also agree with you that it's worth making sure the curl
version behaves as similarly as possible.
-Peff
next prev parent reply other threads:[~2017-08-07 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 14:03 [PATCH 1/4] imap-send: add wrapper to get server credentials if needed Nicolas Morey-Chaisemartin
2017-08-07 16:30 ` Martin Ågren
2017-08-07 17:04 ` Nicolas Morey-Chaisemartin
2017-08-07 17:18 ` Martin Ågren
2017-08-07 19:42 ` Jeff King
2017-08-07 19:55 ` Nicolas Morey-Chaisemartin
2017-08-07 20:07 ` Jeff King [this message]
2017-08-07 22:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807200724.6pdfkmrrmmkdmmb6@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=nicolas@morey-chaisemartin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).