git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [PATCH] doc: remove unsupported parameter from patch-id
@ 2017-07-27 22:46 Andreas Heiduk
  2017-07-28  0:55 ` Jeff King
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Heiduk @ 2017-07-27 22:46 UTC (permalink / raw)
  To: Git Mailing List; +Cc: Andreas Heiduk

The patch is read from standard input and not from a parameter.

Signed-off-by: Andreas Heiduk <asheiduk@gmail.com>
---
 Documentation/git-patch-id.txt | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Documentation/git-patch-id.txt b/Documentation/git-patch-id.txt
index cf71fba1c..442caff8a 100644
--- a/Documentation/git-patch-id.txt
+++ b/Documentation/git-patch-id.txt
@@ -56,9 +56,6 @@ OPTIONS
 
 	This is the default.
 
-<patch>::
-	The diff to create the ID of.
-
 GIT
 ---
 Part of the linkgit:git[1] suite
-- 
2.13.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] doc: remove unsupported parameter from patch-id
  2017-07-27 22:46 [PATCH] doc: remove unsupported parameter from patch-id Andreas Heiduk
@ 2017-07-28  0:55 ` Jeff King
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2017-07-28  0:55 UTC (permalink / raw)
  To: Andreas Heiduk; +Cc: Git Mailing List

On Fri, Jul 28, 2017 at 12:46:16AM +0200, Andreas Heiduk wrote:

> The patch is read from standard input and not from a parameter.
> 
> Signed-off-by: Andreas Heiduk <asheiduk@gmail.com>
> ---
>  Documentation/git-patch-id.txt | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/git-patch-id.txt b/Documentation/git-patch-id.txt
> index cf71fba1c..442caff8a 100644
> --- a/Documentation/git-patch-id.txt
> +++ b/Documentation/git-patch-id.txt
> @@ -56,9 +56,6 @@ OPTIONS
>  
>  	This is the default.
>  
> -<patch>::
> -	The diff to create the ID of.
> -

Heh, I think this is a leftover from 33e8fc874 (usage: do not insist
that standard input must come from a file, 2015-10-16).

Before then, the usage at the top said something like:

  git patch-id < <patch>

and this "parameter" made sense. But after, we just talk about stdin in
the text, and mentioning "<patch>" is simply confusing.

I looked through the other documentation touched by 33e8fc874 to see if
there were other cases of this same problem, but I think this is the
only one.

-Peff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-28  0:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-27 22:46 [PATCH] doc: remove unsupported parameter from patch-id Andreas Heiduk
2017-07-28  0:55 ` Jeff King

Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).