From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH] dir: support platforms that require aligned reads
Date: Sun, 16 Jul 2017 12:03:13 -0400 [thread overview]
Message-ID: <20170716160313.2crnw6exyqpvp7ue@sigill.intra.peff.net> (raw)
In-Reply-To: <84b4d5aa-956f-932b-4e95-f181243215bc@web.de>
On Sun, Jul 16, 2017 at 05:18:27PM +0200, René Scharfe wrote:
> > it looks like assumptions about struct layout are pervasive and part of
> > the on-disk format. Yuck. :(
>
> Assuming that there is no padding probably even works for the platforms
> the code currently supports (basically x86), but I don't know about
> others. We'd need to change the writing side as well to match, though.
> Which is probably a good idea, but I tried to keep the patch small and
> its impact low. Cross-machine usability is currently explicitly not
> supported -- not sure why, though.
Yeah, I think your patch is a good first step, and we don't have to go
further for now.
-Peff
prev parent reply other threads:[~2017-07-16 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-16 12:17 [PATCH] dir: support platforms that require aligned reads René Scharfe
2017-07-16 14:04 ` Jeff King
2017-07-16 15:18 ` René Scharfe
2017-07-16 16:03 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170716160313.2crnw6exyqpvp7ue@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).