From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/1] bswap: convert get_be16, get_be32 and put_be32 to inline functions
Date: Sun, 16 Jul 2017 06:28:16 -0400 [thread overview]
Message-ID: <20170716102815.gl24fbfzlom2ena3@sigill.intra.peff.net> (raw)
In-Reply-To: <20170716102704.2yywbidmmjv7zfxh@sigill.intra.peff.net>
On Sun, Jul 16, 2017 at 06:27:04AM -0400, Jeff King wrote:
> On Sat, Jul 15, 2017 at 09:22:50PM +0200, René Scharfe wrote:
>
> > Simplify the implementation and allow callers to use expressions with
> > side-effects by turning the macros get_be16, get_be32 and put_be32 into
> > inline functions.
> >
> > Signed-off-by: Rene Scharfe <l.s.r@web.de>
> > ---
> > All these redundant casts started to bother me, so I tried to come up
> > with nice and clean inline functions. Successfully? You tell me.
> > They are longer, but less cluttered. Would it punish -O0 builds? Is
> > it all worth it?
>
> I do think the end result is a lot more readable. On gcc 6 at least, the
> function seems[1] to end up inlined even with -O0.
For my footnote. I was just going to show the test file I compiled:
#include "git-compat-util.h"
uint32_t foo(const char *x)
{
return get_be32(x);
}
It's possible the optimizer may behave differently on a more complicated
input, but it does show that -O0 is still willing to inline.
-Peff
next prev parent reply other threads:[~2017-07-16 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 19:11 [PATCH] bswap: convert to unsigned before shifting in get_be32 René Scharfe
2017-07-15 19:22 ` [PATCH 2/1] bswap: convert get_be16, get_be32 and put_be32 to inline functions René Scharfe
2017-07-16 10:27 ` Jeff King
2017-07-16 10:28 ` Jeff King [this message]
2017-07-16 0:23 ` [PATCH] bswap: convert to unsigned before shifting in get_be32 Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170716102815.gl24fbfzlom2ena3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).