From: Jeff King <peff@peff.net>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Thomas Rast" <tr@thomasrast.ch>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH v1 0/4] Teach 'run' perf script to read config files
Date: Thu, 13 Jul 2017 12:58:41 -0400 [thread overview]
Message-ID: <20170713165840.e5cdw7pa2m6haaen@sigill.intra.peff.net> (raw)
In-Reply-To: <20170713065050.19215-1-chriscool@tuxfamily.org>
On Thu, Jul 13, 2017 at 08:50:46AM +0200, Christian Couder wrote:
> Goal
> ~~~~
>
> Using many long environment variables to give parameters to the 'run'
> script is error prone and tiring.
>
> We want to make it possible to store the parameters to the 'run'
> script in a config file. This will make it easier to store, reuse,
> share and compare parameters.
Because perf-lib is built on test-lib, it already reads
GIT-BUILD-OPTIONS. And the Makefile copies several perf-related values
into it, including GIT_PERF_MAKE_OPTS and GIT_PERF_REPEAT_COUNT. So you
can already do:
echo 'GIT_PERF_REPEAT_COUNT = 10' >>config.mak
echo 'GIT_PERF_MAKE_OPTS = CFLAGS="-O2" DEVELOPER=1' >>config.mak
make
cd t/perf
./run <versions-and-scripts>
I suspect there are still a lot of things that could be made easier with
a config file, so I'm not against the concept. Your example here:
> [perf "with libpcre"]
> makeOpts = DEVELOPER=1 CFLAGS='-g -O0' USE_LIBPCRE=YesPlease
> [perf "without libpcre"]
> makeOpts = DEVELOPER=1 CFLAGS='-g -O0'
is a lot more compelling. But right now the perf suite is not useful at
all for comparing two builds of the same tree. For that, I think it
would be more useful if we could define a tuple of parameters for a run.
One of which could be the tree we're testing. Build opts are another.
Tested repository is another. And then we'd fill in a table of results
and let you slice up the table by any column (e.g., compare times for
runs against a single tree but with differing build options).
So then I think your config file primarily becomes about defining the
properties of each run. I'm not sure if it would look like what you're
starting on here or not.
-Peff
next prev parent reply other threads:[~2017-07-13 16:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 6:50 [PATCH v1 0/4] Teach 'run' perf script to read config files Christian Couder
2017-07-13 6:50 ` [PATCH v1 1/4] perf/run: add '--config' option to the 'run' script Christian Couder
2017-07-13 6:50 ` [PATCH v1 2/4] perf/run: add get_var_from_env_or_config() Christian Couder
2017-07-13 6:50 ` [PATCH v1 3/4] perf/run: add GIT_PERF_DIRS_OR_REVS Christian Couder
2017-07-13 6:50 ` [PATCH v1 4/4] perf/run: add calls to get_var_from_env_or_config() Christian Couder
2017-07-13 16:58 ` Jeff King [this message]
2017-07-13 18:29 ` [PATCH v1 0/4] Teach 'run' perf script to read config files Junio C Hamano
2017-07-13 18:40 ` Jeff King
2017-07-13 19:21 ` Junio C Hamano
2017-07-13 19:45 ` Christian Couder
2017-07-13 18:57 ` Christian Couder
2017-07-13 20:55 ` Jeff King
2017-07-14 6:27 ` Christian Couder
2017-07-14 8:05 ` Jeff King
2017-07-26 15:58 ` Christian Couder
2017-07-26 16:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713165840.e5cdw7pa2m6haaen@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).