From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH] RFC: Introduce '.gitorderfile'
Date: Thu, 13 Jul 2017 11:59:23 -0400 [thread overview]
Message-ID: <20170713155923.a2nissoyczvewoh3@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kYYg6-UMrKRPeJTbHdGR0juZ2OwFZmkuYgeYe5X+cm_sQ@mail.gmail.com>
On Wed, Jul 12, 2017 at 02:08:35PM -0700, Stefan Beller wrote:
> > I could see somebody arguing that format-patch should respect a project
> > preference, since its primary purpose is to communicate your work to the
> > rest of the project.
> >
> > But then you could make a similar argument for other diff options, too.
>
> This similar argument would be to have a in-tree configuration for
> --unified=<N> for example?
Yes, that was exactly the option I was thinking of. :)
> This triggers two reactions for me:
>
> (a) We should totally do that.
> Different projects have different coding styles (e.g. opening brace
> in its own new line or at the end of the condition), which very much impacts
> how useful the context is. So, sure, the project knows best what their
> preference is.
>
> (b) It's a rabbit hole to go down.
> Any config option that format-patch respects can be argued to be useful
> to be preset by a project. So in the end we'd have a ".gitconfig"
> file offering
> good defaults for people using that project. This may have security
> implications.
> And it's a lot of work.
>
> I see your point for (b), I'll think about it more.
And yes, I had both of those reactions, too. We've had the
"project-level .gitconfig" discussion many times over the years. And it
generally comes back to "you can ship a snippet of config and then give
people a script which adds it to their repo".
-Peff
next prev parent reply other threads:[~2017-07-13 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 23:38 [PATCH] RFC: Introduce '.gitorderfile' Stefan Beller
2017-07-12 20:44 ` Junio C Hamano
2017-07-12 20:57 ` Jeff King
2017-07-12 21:08 ` Stefan Beller
2017-07-13 15:59 ` Jeff King [this message]
2017-07-13 17:30 ` Stefan Beller
2017-07-13 17:32 ` Brandon Williams
2017-07-13 19:12 ` Junio C Hamano
2017-07-13 19:20 ` Stefan Beller
2017-07-13 20:47 ` Junio C Hamano
2017-07-12 23:54 ` Junio C Hamano
2017-07-13 16:00 ` Jeff King
2017-07-12 20:58 ` Stefan Beller
2017-07-12 21:37 ` Junio C Hamano
2017-07-12 21:55 ` Stefan Beller
2017-07-12 21:03 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170713155923.a2nissoyczvewoh3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).