git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] commit: convert lookup_commit_graft to struct object_id
Date: Thu, 13 Jul 2017 02:26:30 +0000	[thread overview]
Message-ID: <20170713022630.o6ioe6xnoe5wtllf@genre.crustytoothpaste.net> (raw)
In-Reply-To: <20170713004415.5051-1-sbeller@google.com>

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

On Wed, Jul 12, 2017 at 05:44:14PM -0700, Stefan Beller wrote:
> With this patch, commit.h doesn't contain the string 'sha1' any more.

From a relatively quick look, these look sane to me.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]

  parent reply	other threads:[~2017-07-13  2:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13  0:44 [PATCH 1/2] commit: convert lookup_commit_graft to struct object_id Stefan Beller
2017-07-13  0:44 ` [PATCH 2/2] tag: convert gpg_verify_tag to use " Stefan Beller
2017-07-13 19:02   ` Junio C Hamano
2017-07-13 20:52   ` Junio C Hamano
2017-07-13 21:00     ` Stefan Beller
2017-07-13 21:23       ` Junio C Hamano
2017-07-13 21:49         ` Stefan Beller
2017-07-13 23:45           ` brian m. carlson
2017-07-13  2:26 ` brian m. carlson [this message]
2017-07-13 18:54 ` [PATCH 1/2] commit: convert lookup_commit_graft to " Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713022630.o6ioe6xnoe5wtllf@genre.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).