git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
	git@vger.kernel.org, jonathantanmy@google.com
Subject: Re: [PATCH] RFC: Introduce '.gitorderfile'
Date: Wed, 12 Jul 2017 16:57:34 -0400	[thread overview]
Message-ID: <20170712205734.h77fgbbkavwpkr4h@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqinix1j29.fsf@gitster.mtv.corp.google.com>

On Wed, Jul 12, 2017 at 01:44:46PM -0700, Junio C Hamano wrote:

> Stefan Beller <sbeller@google.com> writes:
> 
> >   I want to force myself to think about the design before pointing out
> >   memory leaks and coding style, so the least I would wish for is:
> >     *.h
> >     *.c
> >   but as we have more to look at, I would want to have the most abstract
> >   thing to come first. And most abstract from the actual code is the
> >   user interaction, the documentation.
> 
> This is exactly why I invented the orderfile in the first place.
> But such a "policy" is not something a project would want to enforce
> its users all the time; it is left to personal preference of the
> participants.
> 
> Just set diff.orderFile to suit your taste without bothering other
> people, I would say.

I could see somebody arguing that format-patch should respect a project
preference, since its primary purpose is to communicate your work to the
rest of the project.

But then you could make a similar argument for other diff options, too.

-Peff

  reply	other threads:[~2017-07-12 20:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 23:38 [PATCH] RFC: Introduce '.gitorderfile' Stefan Beller
2017-07-12 20:44 ` Junio C Hamano
2017-07-12 20:57   ` Jeff King [this message]
2017-07-12 21:08     ` Stefan Beller
2017-07-13 15:59       ` Jeff King
2017-07-13 17:30         ` Stefan Beller
2017-07-13 17:32           ` Brandon Williams
2017-07-13 19:12           ` Junio C Hamano
2017-07-13 19:20             ` Stefan Beller
2017-07-13 20:47               ` Junio C Hamano
2017-07-12 23:54     ` Junio C Hamano
2017-07-13 16:00       ` Jeff King
2017-07-12 20:58   ` Stefan Beller
2017-07-12 21:37     ` Junio C Hamano
2017-07-12 21:55       ` Stefan Beller
2017-07-12 21:03   ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170712205734.h77fgbbkavwpkr4h@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).