From: tboegi@web.de
To: git@vger.kernel.org
Cc: "Torsten Bögershausen" <tboegi@web.de>
Subject: [PATCH v2 1/2] Check DB_ENVIRONMENT using is_directory()
Date: Sat, 1 Jul 2017 14:50:57 +0200 [thread overview]
Message-ID: <20170701125057.16169-1-tboegi@web.de> (raw)
In-Reply-To: <20170628162958.519-1-tboegi@web.de>
From: Torsten Bögershausen <tboegi@web.de>
In setup.c is_git_directory() checks a Git directory using access(X_OK).
This does not check, if path is a file or a directory.
Check path with is_directory() instead.
---
After all the discussions (and lots of tests) I found that this patch
works for my setup.
All in all could the error reporting be improvved for is_git_directory(),
as there may be "access denied", or "not a directory" or others, but
that is for another day.
setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.c b/setup.c
index 358fbc2..5a7ee2e 100644
--- a/setup.c
+++ b/setup.c
@@ -321,7 +321,7 @@ int is_git_directory(const char *suspect)
/* Check non-worktree-related signatures */
if (getenv(DB_ENVIRONMENT)) {
- if (access(getenv(DB_ENVIRONMENT), X_OK))
+ if (!is_directory(getenv(DB_ENVIRONMENT)))
goto done;
}
else {
--
2.10.0
next prev parent reply other threads:[~2017-07-01 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 16:29 [PATCH/RFC v1 1/1] cygwin: Allow pushing to UNC paths tboegi
2017-06-28 17:40 ` Junio C Hamano
2017-07-01 12:50 ` tboegi [this message]
2017-07-01 17:24 ` [PATCH v2 1/2] Check DB_ENVIRONMENT using is_directory() Junio C Hamano
2017-07-03 14:41 ` [PATCH v3 1/1] cygwin: Allow pushing to UNC paths tboegi
2017-07-05 21:14 ` Junio C Hamano
2017-07-01 12:50 ` [PATCH v2 2/2] " tboegi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170701125057.16169-1-tboegi@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).