From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Lars Schneider <larsxschneider@gmail.com>,
git@vger.kernel.org, tboegi@web.de, e@80x24.org,
ttaylorr@github.com, peartben@gmail.com
Subject: Re: [PATCH v5 5/5] convert: add "status=delayed" to filter process protocol
Date: Sat, 24 Jun 2017 16:36:40 -0400 [thread overview]
Message-ID: <20170624203640.qomgbsakrgseungl@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq37ap9q2i.fsf@gitster.mtv.corp.google.com>
On Sat, Jun 24, 2017 at 11:51:49AM -0700, Junio C Hamano wrote:
> >> if ((CAP_DELAY & entry->supported_capabilities) &&
> >> dco && dco->state == CE_CAN_DELAY))
> >
> > Agreed!
>
> Why wasn't this caught earlier? I thought this is something gcc warns about.
I thought so, too. If it warned about:
if (A & B)
that would probably be too annoying. But:
if (A & B && C)
is much more questionable. I wonder if it used to exist and gcc dropped
it (or dropped it from -Wall). -Wlogical-op seems like the most likely
candidate, but it does not catch it (and it has a false positive in
handle_nonblock, or perhaps I just can't see the problem).
> >> The operator precedence is such that it works without them, so this is
> >> just a style question (I'd also usually put the flags field before the
> >> flag itself, but that's really getting into aesthetics).
> >
> > You mean (entry & CAP_DELAY) instead of (CAP_DELAY & entry)?
>
> Peff is continuing his explanation why (A & B && C) is technically
> correct and preferring ((A & B) && C) is purely stylistic. "A & B"
> binds tighter than "something && C" which means that (A & B && C)
> cannot be misinterpreted as (A & (B && C)).
I actually meant both. The bitwise operator binds tighter so it's OK
either way. But I would write "flags & MY_FLAG" and never "MY_FLAG &
flags".
-Peff
next prev parent reply other threads:[~2017-06-24 20:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 8:21 [PATCH v5 0/5] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-06-01 8:21 ` [PATCH v5 1/5] t0021: keep filter log files on comparison Lars Schneider
2017-06-01 8:22 ` [PATCH v5 2/5] t0021: make debug log file name configurable Lars Schneider
2017-06-01 8:22 ` [PATCH v5 3/5] t0021: write "OUT" only on success Lars Schneider
2017-06-01 8:22 ` [PATCH v5 4/5] convert: move multiple file filter error handling to separate function Lars Schneider
2017-06-18 7:20 ` Torsten Bögershausen
2017-06-18 11:47 ` Lars Schneider
2017-06-19 17:18 ` Torsten Bögershausen
2017-06-19 17:47 ` Lars Schneider
2017-06-01 8:22 ` [PATCH v5 5/5] convert: add "status=delayed" to filter process protocol Lars Schneider
2017-06-02 2:21 ` Junio C Hamano
2017-06-05 11:36 ` Lars Schneider
2017-06-24 14:19 ` Jeff King
2017-06-24 17:22 ` Lars Schneider
2017-06-24 18:51 ` Junio C Hamano
2017-06-24 20:36 ` Jeff King [this message]
2017-06-24 20:32 ` Jeff King
2017-06-01 9:44 ` [PATCH v5 0/5] " Junio C Hamano
2017-06-02 2:06 ` Junio C Hamano
2017-06-24 14:23 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170624203640.qomgbsakrgseungl@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=peartben@gmail.com \
--cc=tboegi@web.de \
--cc=ttaylorr@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).