From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brandon Williams <bmwill@google.com>,
Stefan Beller <sbeller@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] add: warn when adding an embedded repository
Date: Wed, 14 Jun 2017 02:38:49 -0400 [thread overview]
Message-ID: <20170614063849.kkdzxp54r25l2wk6@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqshj37qqo.fsf@gitster.mtv.corp.google.com>
On Tue, Jun 13, 2017 at 10:16:15AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I also waffled on whether we should ask the submodule code
> > whether it knows about a particular path. Technically:
> >
> > git config submodule.foo.path foo
> > git config submodule.foo.url git://...
> > git add foo
> >
> > is legal, but would still warn with this patch.
>
> Did you mean "git config -f .gitmodules" for the first two? If so,
> I think I agree that (1) it should be legal and (2) we should be
> able to add the check on top of this patch.
>
> Or do you really mean the case in which these are in .git/config?
I did mean .git/config, but I think it was because I was mostly confused
about what was possible. In either case I think what we'd want is to ask
"could this be used as an active submodule". And leave it to the
submodule code to decide whatever mechanisms are legal.
-Peff
next prev parent reply other threads:[~2017-06-14 6:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 3:56 [BUG?] gitlink without .gitmodules no longer fails recursive clone Jeff King
2017-06-06 18:01 ` Stefan Beller
2017-06-06 18:10 ` Brandon Williams
2017-06-06 18:39 ` Jeff King
2017-06-09 23:19 ` Jeff King
2017-06-10 2:10 ` Junio C Hamano
2017-06-10 7:13 ` Jeff King
2017-06-10 11:12 ` Junio C Hamano
2017-06-12 5:30 ` Stefan Beller
2017-06-13 9:14 ` Jeff King
2017-06-13 9:24 ` [PATCH 1/2] add: warn when adding an embedded repository Jeff King
2017-06-13 17:07 ` Stefan Beller
2017-06-13 17:16 ` Brandon Williams
2017-06-14 6:36 ` Jeff King
2017-06-14 10:54 ` [PATCH v2 0/2] " Jeff King
2017-06-14 10:58 ` [PATCH v2 1/2] add: " Jeff King
2017-06-14 10:58 ` [PATCH v2 2/2] t: move "git add submodule" into test blocks Jeff King
2017-06-14 17:53 ` [PATCH 1/2] add: warn when adding an embedded repository Stefan Beller
2017-06-15 6:01 ` Jeff King
2017-06-13 17:16 ` Junio C Hamano
2017-06-14 6:38 ` Jeff King [this message]
2017-06-13 9:24 ` [PATCH 2/2] t: move "git add submodule" into test blocks Jeff King
2017-06-13 17:15 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614063849.kkdzxp54r25l2wk6@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).