From: Brandon Williams <bmwill@google.com>
To: git@vger.kernel.org
Cc: sbeller@google.com, jrnieder@gmail.com, jacob.keller@gmail.com,
Johannes.Schindelin@gmx.de, sandals@crustytoothpaste.net,
peartben@gmail.com, pclouds@gmail.com, gitster@pobox.com,
peff@peff.net, git@jeffhostetler.com, avarab@gmail.com,
jonathantanmy@google.com
Subject: Re: [PATCH v2 32/32] ls-files: use repository object
Date: Thu, 8 Jun 2017 17:08:49 -0700 [thread overview]
Message-ID: <20170609000849.GA130522@google.com> (raw)
In-Reply-To: <20170608234100.188529-33-bmwill@google.com>
On 06/08, Brandon Williams wrote:
> Convert ls-files to use a repository struct and recurse submodules
> inprocess.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
> builtin/ls-files.c | 198 ++++++++++++++-------------------
> git.c | 2 +-
> repository.c | 4 +
> repository.h | 1 +
> t/t3007-ls-files-recurse-submodules.sh | 39 +++++++
> 5 files changed, 129 insertions(+), 115 deletions(-)
>
> diff --git a/builtin/ls-files.c b/builtin/ls-files.c
> index 6a0302a28..503fed5a1 100644
> --- a/builtin/ls-files.c
> +++ b/builtin/ls-files.c
> @@ -5,7 +5,9 @@
> *
> * Copyright (C) Linus Torvalds, 2005
> */
> +#define NO_THE_INDEX_COMPATIBILITY_MACROS
> #include "cache.h"
> +#include "repository.h"
> #include "config.h"
> #include "quote.h"
> #include "dir.h"
> @@ -32,10 +34,8 @@ static int line_terminator = '\n';
> static int debug_mode;
> static int show_eol;
> static int recurse_submodules;
> -static struct argv_array submodule_options = ARGV_ARRAY_INIT;
>
> static const char *prefix;
> -static const char *super_prefix;
> static int max_prefix_len;
> static int prefix_len;
> static struct pathspec pathspec;
> @@ -73,25 +73,12 @@ static void write_eolinfo(const struct index_state *istate,
>
> static void write_name(const char *name)
> {
> - /*
> - * Prepend the super_prefix to name to construct the full_name to be
> - * written.
> - */
> - struct strbuf full_name = STRBUF_INIT;
> - if (super_prefix) {
> - strbuf_addstr(&full_name, super_prefix);
> - strbuf_addstr(&full_name, name);
> - name = full_name.buf;
> - }
> -
> /*
> * With "--full-name", prefix_len=0; this caller needs to pass
> * an empty string in that case (a NULL is good for "").
> */
> write_name_quoted_relative(name, prefix_len ? prefix : NULL,
> stdout, line_terminator);
> -
> - strbuf_release(&full_name);
> }
>
> static const char *get_tag(const struct cache_entry *ce, const char *tag)
> @@ -210,82 +197,41 @@ static void show_killed_files(const struct index_state *istate,
> }
> }
>
> -/*
> - * Compile an argv_array with all of the options supported by --recurse_submodules
> - */
> -static void compile_submodule_options(const char **argv,
> - const struct dir_struct *dir,
> - int show_tag)
> -{
> - if (line_terminator == '\0')
> - argv_array_push(&submodule_options, "-z");
> - if (show_tag)
> - argv_array_push(&submodule_options, "-t");
> - if (show_valid_bit)
> - argv_array_push(&submodule_options, "-v");
> - if (show_cached)
> - argv_array_push(&submodule_options, "--cached");
> - if (show_eol)
> - argv_array_push(&submodule_options, "--eol");
> - if (debug_mode)
> - argv_array_push(&submodule_options, "--debug");
> -
> - /* Add Pathspecs */
> - argv_array_push(&submodule_options, "--");
> - for (; *argv; argv++)
> - argv_array_push(&submodule_options, *argv);
> -}
> +static void show_files(struct repository *repo, struct dir_struct *dir);
>
> -/**
> - * Recursively call ls-files on a submodule
> - */
> -static void show_gitlink(const struct cache_entry *ce)
> +static void show_submodule(const struct repository *superproject,
> + struct dir_struct *dir, const char *path)
> {
> - struct child_process cp = CHILD_PROCESS_INIT;
> - int status;
> - char *dir;
> -
> - prepare_submodule_repo_env(&cp.env_array);
> - argv_array_push(&cp.env_array, GIT_DIR_ENVIRONMENT);
> -
> - if (prefix_len)
> - argv_array_pushf(&cp.env_array, "%s=%s",
> - GIT_TOPLEVEL_PREFIX_ENVIRONMENT,
> - prefix);
> - argv_array_pushf(&cp.args, "--super-prefix=%s%s/",
> - super_prefix ? super_prefix : "",
> - ce->name);
> - argv_array_push(&cp.args, "ls-files");
> - argv_array_push(&cp.args, "--recurse-submodules");
> -
> - /* add supported options */
> - argv_array_pushv(&cp.args, submodule_options.argv);
> -
> - cp.git_cmd = 1;
> - dir = mkpathdup("%s/%s", get_git_work_tree(), ce->name);
> - cp.dir = dir;
> - status = run_command(&cp);
> - free(dir);
> - if (status)
> - exit(status);
> + struct repository submodule;
> + char *gitdir = mkpathdup("%s/%s", superproject->worktree, path);
> + repo_init(&submodule, gitdir);
> +
> + repo_read_index(&submodule);
> + repo_read_gitmodules(&submodule);
> +
> + if (superproject->submodule_prefix)
> + submodule.submodule_prefix = xstrfmt("%s%s/", superproject->submodule_prefix, path);
> + else
> + submodule.submodule_prefix = xstrfmt("%s/", path);
> + show_files(&submodule, dir);
> +
> + repo_clear(&submodule);
> + free(gitdir);
> }
>
> -static void show_ce_entry(const char *tag, const struct cache_entry *ce)
> +static void show_ce(struct repository *repo, struct dir_struct *dir,
> + const struct cache_entry *ce, const char *fullname,
> + const char *tag)
> {
> - struct strbuf name = STRBUF_INIT;
> - int len = max_prefix_len;
> - if (super_prefix)
> - strbuf_addstr(&name, super_prefix);
> - strbuf_addstr(&name, ce->name);
> -
> - if (len > ce_namelen(ce))
> + if (max_prefix_len > strlen(fullname))
> die("git ls-files: internal error - cache entry not superset of prefix");
>
> if (recurse_submodules && S_ISGITLINK(ce->ce_mode) &&
> - submodule_path_match(&pathspec, name.buf, ps_matched)) {
> - show_gitlink(ce);
> - } else if (match_pathspec(&pathspec, name.buf, name.len,
> - len, ps_matched,
> + submodule_path_match(&pathspec, fullname, ps_matched) &&
> + is_submodule_active(repo, ce->name)) {
> + show_submodule(repo, dir, ce->name);
> + } else if (match_pathspec(&pathspec, fullname, strlen(fullname),
> + max_prefix_len, ps_matched,
> S_ISDIR(ce->ce_mode) ||
> S_ISGITLINK(ce->ce_mode))) {
> tag = get_tag(ce, tag);
> @@ -299,12 +245,11 @@ static void show_ce_entry(const char *tag, const struct cache_entry *ce)
> find_unique_abbrev(ce->oid.hash, abbrev),
> ce_stage(ce));
> }
> - write_eolinfo(&the_index, ce, ce->name);
> - write_name(ce->name);
> +
> + write_eolinfo(repo->index, ce, fullname);
> + write_name(fullname);
> print_debug(ce);
> }
> -
> - strbuf_release(&name);
> }
>
> static void show_ru_info(const struct index_state *istate)
> @@ -337,59 +282,79 @@ static void show_ru_info(const struct index_state *istate)
> }
>
> static int ce_excluded(struct dir_struct *dir, struct index_state *istate,
> - const struct cache_entry *ce)
> + const char *fullname, const struct cache_entry *ce)
> {
> int dtype = ce_to_dtype(ce);
> - return is_excluded(dir, istate, ce->name, &dtype);
> + return is_excluded(dir, istate, fullname, &dtype);
> +}
> +
> +static void construct_fullname(struct strbuf *out, const struct repository *repo,
> + const struct cache_entry *ce)
> +{
> + strbuf_reset(out);
> + if (repo->submodule_prefix)
> + strbuf_addstr(out, repo->submodule_prefix);
> + strbuf_addstr(out, ce->name);
> }
>
> -static void show_files(struct index_state *istate, struct dir_struct *dir)
> +static void show_files(struct repository *repo, struct dir_struct *dir)
> {
> int i;
> + struct strbuf fullname = STRBUF_INIT;
>
> /* For cached/deleted files we don't need to even do the readdir */
> if (show_others || show_killed) {
> if (!show_others)
> dir->flags |= DIR_COLLECT_KILLED_ONLY;
> - fill_directory(dir, istate, &pathspec);
> + fill_directory(dir, repo->index, &pathspec);
> if (show_others)
> - show_other_files(istate, dir);
> + show_other_files(repo->index, dir);
> if (show_killed)
> - show_killed_files(istate, dir);
> + show_killed_files(repo->index, dir);
> }
> if (show_cached || show_stage) {
> - for (i = 0; i < istate->cache_nr; i++) {
> - const struct cache_entry *ce = istate->cache[i];
> + for (i = 0; i < repo->index->cache_nr; i++) {
> + const struct cache_entry *ce = repo->index->cache[i];
> +
> + construct_fullname(&fullname, repo, ce);
> +
> if ((dir->flags & DIR_SHOW_IGNORED) &&
> - !ce_excluded(dir, istate, ce))
> + !ce_excluded(dir, repo->index, fullname.buf, ce))
> continue;
> if (show_unmerged && !ce_stage(ce))
> continue;
> if (ce->ce_flags & CE_UPDATE)
> continue;
> - show_ce_entry(ce_stage(ce) ? tag_unmerged :
> - (ce_skip_worktree(ce) ? tag_skip_worktree : tag_cached), ce);
> + show_ce(repo, dir, ce, fullname.buf,
> + ce_stage(ce) ? tag_unmerged :
> + (ce_skip_worktree(ce) ? tag_skip_worktree :
> + tag_cached));
> }
> }
> if (show_deleted || show_modified) {
> - for (i = 0; i < istate->cache_nr; i++) {
> - const struct cache_entry *ce = istate->cache[i];
> + for (i = 0; i < repo->index->cache_nr; i++) {
> + const struct cache_entry *ce = repo->index->cache[i];
> struct stat st;
> int err;
> +
> + construct_fullname(&fullname, repo, ce);
> +
> if ((dir->flags & DIR_SHOW_IGNORED) &&
> - !ce_excluded(dir, istate, ce))
> + !ce_excluded(dir, repo->index, fullname.buf, ce))
> continue;
> if (ce->ce_flags & CE_UPDATE)
> continue;
> if (ce_skip_worktree(ce))
> continue;
> - err = lstat(ce->name, &st);
> + err = lstat(fullname.buf, &st);
> if (show_deleted && err)
> - show_ce_entry(tag_removed, ce);
> - if (show_modified && ie_modified(istate, ce, &st, 0))
> - show_ce_entry(tag_modified, ce);
> + show_ce(repo, dir, ce, fullname.buf, tag_removed);
> + if (show_modified && ie_modified(repo->index, ce, &st, 0))
> + show_ce(repo, dir, ce, fullname.buf, tag_modified);
> }
> }
> +
> + strbuf_release(&fullname);
> }
>
> /*
> @@ -614,10 +579,9 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
> prefix = cmd_prefix;
> if (prefix)
> prefix_len = strlen(prefix);
> - super_prefix = get_super_prefix();
> git_config(git_default_config, NULL);
>
> - if (read_cache() < 0)
> + if (repo_read_index(the_repository))
oops, looks like this should have been:
if (repo_read_index(the_repository) < 0)
> die("index file corrupt");
>
> argc = parse_options(argc, argv, prefix, builtin_ls_files_options,
> @@ -650,8 +614,9 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
> if (require_work_tree && !is_inside_work_tree())
> setup_work_tree();
>
> - if (recurse_submodules)
> - compile_submodule_options(argv, &dir, show_tag);
> + if (recurse_submodules) {
> + repo_read_gitmodules(the_repository);
> + }
>
> if (recurse_submodules &&
> (show_stage || show_deleted || show_others || show_unmerged ||
> @@ -669,7 +634,10 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
> /*
> * Find common prefix for all pathspec's
> * This is used as a performance optimization which unfortunately cannot
> - * be done when recursing into submodules
> + * be done when recursing into submodules because when a pathspec is
> + * given which spans repository boundaries you can't simply remove the
> + * submodule entry because the pathspec may match something inside the
> + * submodule.
> */
> if (recurse_submodules)
> max_prefix = NULL;
> @@ -677,7 +645,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
> max_prefix = common_prefix(&pathspec);
> max_prefix_len = get_common_prefix_len(max_prefix);
>
> - prune_index(&the_index, max_prefix, max_prefix_len);
> + prune_index(the_repository->index, max_prefix, max_prefix_len);
>
> /* Treat unmatching pathspec elements as errors */
> if (pathspec.nr && error_unmatch)
> @@ -698,11 +666,13 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)
> */
> if (show_stage || show_unmerged)
> die("ls-files --with-tree is incompatible with -s or -u");
> - overlay_tree_on_index(&the_index, with_tree, max_prefix);
> + overlay_tree_on_index(the_repository->index, with_tree, max_prefix);
> }
> - show_files(&the_index, &dir);
> +
> + show_files(the_repository, &dir);
> +
> if (show_resolve_undo)
> - show_ru_info(&the_index);
> + show_ru_info(the_repository->index);
>
> if (ps_matched) {
> int bad;
> diff --git a/git.c b/git.c
> index 594436e43..16c6e325d 100644
> --- a/git.c
> +++ b/git.c
> @@ -442,7 +442,7 @@ static struct cmd_struct commands[] = {
> { "init-db", cmd_init_db },
> { "interpret-trailers", cmd_interpret_trailers, RUN_SETUP_GENTLY },
> { "log", cmd_log, RUN_SETUP },
> - { "ls-files", cmd_ls_files, RUN_SETUP | SUPPORT_SUPER_PREFIX },
> + { "ls-files", cmd_ls_files, RUN_SETUP },
> { "ls-remote", cmd_ls_remote, RUN_SETUP_GENTLY },
> { "ls-tree", cmd_ls_tree, RUN_SETUP },
> { "mailinfo", cmd_mailinfo, RUN_SETUP_GENTLY },
> diff --git a/repository.c b/repository.c
> index 98a851d20..9f899a34a 100644
> --- a/repository.c
> +++ b/repository.c
> @@ -152,6 +152,8 @@ int repo_init(struct repository *repo, const char *gitdir)
> if (verify_repo_format(&format, repo->commondir))
> goto error;
>
> + repo_set_worktree(repo, gitdir);
> +
> return 0;
>
> error:
> @@ -180,6 +182,8 @@ void repo_clear(struct repository *repo)
> repo_clear_env(repo);
> free(repo->worktree);
> repo->worktree = NULL;
> + free(repo->submodule_prefix);
> + repo->submodule_prefix = NULL;
>
> if (repo->config) {
> git_configset_clear(repo->config);
> diff --git a/repository.h b/repository.h
> index d9f1f721b..eea9a88aa 100644
> --- a/repository.h
> +++ b/repository.h
> @@ -14,6 +14,7 @@ struct repository {
> char *graft_file;
> char *namespace;
> char *worktree;
> + char *submodule_prefix;
>
> /* Subsystems */
> /*
> diff --git a/t/t3007-ls-files-recurse-submodules.sh b/t/t3007-ls-files-recurse-submodules.sh
> index ebb956fd1..318b5bce7 100755
> --- a/t/t3007-ls-files-recurse-submodules.sh
> +++ b/t/t3007-ls-files-recurse-submodules.sh
> @@ -135,6 +135,45 @@ test_expect_success '--recurse-submodules and pathspecs setup' '
> test_cmp expect actual
> '
>
> +test_expect_success 'inactive submodule' '
> + test_when_finished "git config --bool submodule.submodule.active true" &&
> + test_when_finished "git -C submodule config --bool submodule.subsub.active true" &&
> + git config --bool submodule.submodule.active "false" &&
> +
> + cat >expect <<-\EOF &&
> + .gitmodules
> + a
> + b/b
> + h.txt
> + sib/file
> + sub/file
> + submodule
> + EOF
> +
> + git ls-files --recurse-submodules >actual &&
> + test_cmp expect actual &&
> +
> + git config --bool submodule.submodule.active "true" &&
> + git -C submodule config --bool submodule.subsub.active "false" &&
> +
> + cat >expect <<-\EOF &&
> + .gitmodules
> + a
> + b/b
> + h.txt
> + sib/file
> + sub/file
> + submodule/.gitmodules
> + submodule/c
> + submodule/f.TXT
> + submodule/g.txt
> + submodule/subsub
> + EOF
> +
> + git ls-files --recurse-submodules >actual &&
> + test_cmp expect actual
> +'
> +
> test_expect_success '--recurse-submodules and pathspecs' '
> cat >expect <<-\EOF &&
> h.txt
> --
> 2.13.1.508.gb3defc5cc-goog
>
--
Brandon Williams
next prev parent reply other threads:[~2017-06-09 0:08 UTC|newest]
Thread overview: 214+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 21:43 [PATCH 00/31] repository object Brandon Williams
2017-05-31 21:43 ` [PATCH 01/31] config: create config.h Brandon Williams
2017-05-31 21:43 ` [PATCH 02/31] config: don't include config.h by default Brandon Williams
2017-05-31 21:43 ` [PATCH 03/31] config: don't implicitly use gitdir Brandon Williams
2017-06-08 10:41 ` Johannes Schindelin
2017-06-08 16:37 ` Brandon Williams
2017-06-08 18:58 ` Johannes Schindelin
2017-06-08 19:19 ` Brandon Williams
2017-05-31 21:43 ` [PATCH 04/31] setup: don't perform lazy initialization of repository state Brandon Williams
2017-06-01 19:23 ` Stefan Beller
2017-06-02 18:39 ` Jeff King
2017-06-05 17:43 ` Brandon Williams
2017-06-05 18:20 ` Jeff King
2017-06-05 18:44 ` Brandon Williams
2017-05-31 21:43 ` [PATCH 05/31] environment: remove namespace_len variable Brandon Williams
2017-06-01 19:28 ` Stefan Beller
2017-06-01 21:09 ` Brandon Williams
2017-05-31 21:43 ` [PATCH 06/31] repo: introduce the repository object Brandon Williams
2017-06-01 19:53 ` Stefan Beller
2017-06-05 17:53 ` Brandon Williams
2017-06-05 18:31 ` Stefan Beller
2017-05-31 21:43 ` [PATCH 07/31] environment: place key repository state in the_repository Brandon Williams
2017-05-31 21:43 ` [PATCH 08/31] environment: store worktree " Brandon Williams
2017-05-31 21:43 ` [PATCH 09/31] setup: add comment indicating a hack Brandon Williams
2017-05-31 21:43 ` [PATCH 10/31] config: migrate the_configset to the_repository Brandon Williams
2017-05-31 21:43 ` [PATCH 11/31] repo: add index_state to struct repo Brandon Williams
2017-05-31 21:43 ` [PATCH 12/31] submodule-config: store the_submodule_cache in the_repository Brandon Williams
2017-05-31 21:43 ` [PATCH 13/31] repo: add repo_read_gitmodules Brandon Williams
2017-05-31 21:44 ` [PATCH 14/31] submodule: convert is_submodule_initialized to work on a repository Brandon Williams
2017-05-31 21:44 ` [PATCH 15/31] convert: convert get_cached_convert_stats_ascii to take an index Brandon Williams
2017-05-31 21:44 ` [PATCH 16/31] convert: convert crlf_to_git " Brandon Williams
2017-05-31 21:44 ` [PATCH 17/31] convert: convert convert_to_git_filter_fd " Brandon Williams
2017-05-31 21:44 ` [PATCH 18/31] convert: convert convert_to_git " Brandon Williams
2017-05-31 21:44 ` [PATCH 19/31] convert: convert renormalize_buffer " Brandon Williams
2017-05-31 21:44 ` [PATCH 20/31] tree: convert read_tree to take an index parameter Brandon Williams
2017-05-31 21:44 ` [PATCH 21/31] ls-files: convert overlay_tree_on_cache to take an index Brandon Williams
2017-05-31 21:44 ` [PATCH 22/31] ls-files: convert write_eolinfo " Brandon Williams
2017-05-31 21:44 ` [PATCH 23/31] ls-files: convert show_killed_files " Brandon Williams
2017-05-31 21:44 ` [PATCH 24/31] ls-files: convert show_other_files " Brandon Williams
2017-05-31 21:44 ` [PATCH 25/31] ls-files: convert show_ru_info " Brandon Williams
2017-05-31 21:44 ` [PATCH 26/31] ls-files: convert ce_excluded " Brandon Williams
2017-05-31 21:44 ` [PATCH 27/31] ls-files: convert prune_cache " Brandon Williams
2017-05-31 21:44 ` [PATCH 28/31] ls-files: convert show_files " Brandon Williams
2017-05-31 21:44 ` [PATCH 29/31] ls-files: factor out debug info into a function Brandon Williams
2017-05-31 21:44 ` [PATCH 30/31] ls-files: factor out tag calculation Brandon Williams
2017-05-31 21:44 ` [PATCH 31/31] ls-files: use repository object Brandon Williams
2017-06-01 20:36 ` Stefan Beller
2017-06-05 17:46 ` Brandon Williams
2017-05-31 22:56 ` [PATCH 00/31] " Stefan Beller
2017-05-31 23:01 ` Brandon Williams
2017-06-01 18:10 ` Brandon Williams
2017-06-01 18:28 ` Stefan Beller
2017-06-01 20:03 ` Jacob Keller
2017-06-08 23:40 ` [PATCH v2 00/32] " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 01/32] config: create config.h Brandon Williams
2017-06-08 23:40 ` [PATCH v2 02/32] config: remove git_config_iter Brandon Williams
2017-06-08 23:40 ` [PATCH v2 03/32] config: don't include config.h by default Brandon Williams
2017-06-08 23:40 ` [PATCH v2 04/32] config: don't implicitly use gitdir Brandon Williams
2017-06-12 19:57 ` Brandon Williams
2017-06-08 23:40 ` [PATCH v2 05/32] setup: don't perform lazy initialization of repository state Brandon Williams
2017-06-08 23:40 ` [PATCH v2 06/32] environment: remove namespace_len variable Brandon Williams
2017-06-08 23:40 ` [PATCH v2 07/32] repository: introduce the repository object Brandon Williams
2017-06-09 8:53 ` [PATCH 0/2] Add a freez() wrapper Ævar Arnfjörð Bjarmason
2017-06-09 14:53 ` Brandon Williams
2017-06-09 22:04 ` [PATCH v2 0/2] Add a FREEZ() wrapper macro Ævar Arnfjörð Bjarmason
2017-06-09 22:04 ` [PATCH v2 1/2] git-compat-util: add a FREEZ() wrapper around free(ptr); ptr = NULL Ævar Arnfjörð Bjarmason
2017-06-09 22:27 ` Jonathan Nieder
2017-06-09 23:37 ` Eric Wong
2017-06-10 1:40 ` Junio C Hamano
2017-06-10 3:21 ` Eric Wong
2017-06-10 7:25 ` Jeff King
2017-06-15 16:48 ` Junio C Hamano
2017-06-15 17:13 ` Ævar Arnfjörð Bjarmason
2017-06-15 21:06 ` [PATCH v3 0/2] Add a FREE_AND_NULL() wrapper macro Ævar Arnfjörð Bjarmason
2017-06-15 22:00 ` Junio C Hamano
2017-06-15 23:15 ` [PATCH v4 0/6] " Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 1/6] git-compat-util: add a FREE_AND_NULL() wrapper around free(ptr); ptr = NULL Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 2/6] coccinelle: add a rule to make "type" code use FREE_AND_NULL() Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 3/6] coccinelle: make use of the "type" FREE_AND_NULL() rule Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 4/6] coccinelle: add a rule to make "expression" code use FREE_AND_NULL() Ævar Arnfjörð Bjarmason
2017-06-16 19:43 ` Junio C Hamano
2017-06-25 8:01 ` René Scharfe
2017-06-28 21:39 ` Ævar Arnfjörð Bjarmason
2017-06-28 22:00 ` Junio C Hamano
2017-06-28 22:17 ` Ævar Arnfjörð Bjarmason
2017-06-28 22:21 ` René Scharfe
2017-06-28 22:30 ` Ævar Arnfjörð Bjarmason
2017-06-28 23:15 ` Junio C Hamano
2017-06-28 22:30 ` René Scharfe
2017-06-28 22:35 ` Ævar Arnfjörð Bjarmason
2017-06-28 22:44 ` René Scharfe
2017-06-15 23:15 ` [PATCH v4 5/6] coccinelle: make use of the "expression" FREE_AND_NULL() rule Ævar Arnfjörð Bjarmason
2017-06-15 23:15 ` [PATCH v4 6/6] *.[ch] refactoring: make use of the FREE_AND_NULL() macro Ævar Arnfjörð Bjarmason
2017-06-15 21:06 ` [PATCH v3 1/2] git-compat-util: add a FREE_AND_NULL() wrapper around free(ptr); ptr = NULL Ævar Arnfjörð Bjarmason
2017-06-15 21:07 ` [PATCH v3 2/2] *.[ch] refactoring: make use of the FREE_AND_NULL() macro Ævar Arnfjörð Bjarmason
2017-06-10 6:55 ` [PATCH v2 1/2] git-compat-util: add a FREEZ() wrapper around free(ptr); ptr = NULL Andreas Schwab
2017-06-09 22:04 ` [PATCH v2 2/2] *.[ch] refactoring: make use of the FREEZ() macro Ævar Arnfjörð Bjarmason
2017-06-09 8:53 ` [PATCH 1/2] git-compat-util: add a freez() wrapper around free(x); x = NULL Ævar Arnfjörð Bjarmason
2017-06-09 12:04 ` Christian Couder
2017-06-09 8:53 ` [PATCH 2/2] *.[ch] refactoring: make use of the freez() wrapper Ævar Arnfjörð Bjarmason
2017-06-09 10:12 ` Martin Ågren
2017-06-09 10:58 ` Ævar Arnfjörð Bjarmason
2017-06-09 14:48 ` Brandon Williams
2017-06-08 23:40 ` [PATCH v2 08/32] environment: place key repository state in the_repository Brandon Williams
2017-06-08 23:40 ` [PATCH v2 09/32] environment: store worktree " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 10/32] setup: add comment indicating a hack Brandon Williams
2017-06-08 23:40 ` [PATCH v2 11/32] config: read config from a repository object Brandon Williams
2017-06-08 23:40 ` [PATCH v2 12/32] repository: add index_state to struct repo Brandon Williams
2017-06-08 23:40 ` [PATCH v2 13/32] submodule-config: store the_submodule_cache in the_repository Brandon Williams
2017-06-08 23:40 ` [PATCH v2 14/32] submodule: add repo_read_gitmodules Brandon Williams
2017-06-08 23:40 ` [PATCH v2 15/32] submodule: convert is_submodule_initialized to work on a repository Brandon Williams
2017-06-08 23:40 ` [PATCH v2 16/32] convert: convert get_cached_convert_stats_ascii to take an index Brandon Williams
2017-06-08 23:40 ` [PATCH v2 17/32] convert: convert crlf_to_git " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 18/32] convert: convert convert_to_git_filter_fd " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 19/32] convert: convert convert_to_git " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 20/32] convert: convert renormalize_buffer " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 21/32] tree: convert read_tree to take an index parameter Brandon Williams
2017-06-08 23:40 ` [PATCH v2 22/32] ls-files: convert overlay_tree_on_cache to take an index Brandon Williams
2017-06-08 23:40 ` [PATCH v2 23/32] ls-files: convert write_eolinfo " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 24/32] ls-files: convert show_killed_files " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 25/32] ls-files: convert show_other_files " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 26/32] ls-files: convert show_ru_info " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 27/32] ls-files: convert ce_excluded " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 28/32] ls-files: convert prune_cache " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 29/32] ls-files: convert show_files " Brandon Williams
2017-06-08 23:40 ` [PATCH v2 30/32] ls-files: factor out debug info into a function Brandon Williams
2017-06-08 23:40 ` [PATCH v2 31/32] ls-files: factor out tag calculation Brandon Williams
2017-06-08 23:41 ` [PATCH v2 32/32] ls-files: use repository object Brandon Williams
2017-06-09 0:08 ` Brandon Williams [this message]
2017-06-10 5:59 ` Junio C Hamano
2017-06-12 21:24 ` Brandon Williams
2017-06-10 0:40 ` [PATCH v2 00/32] " Jonathan Tan
2017-06-10 6:07 ` Jeff King
2017-06-10 6:13 ` Jeff King
2017-06-11 0:43 ` Brandon Williams
2017-06-12 19:10 ` Jonathan Tan
2017-06-11 0:35 ` Brandon Williams
2017-06-12 5:24 ` Stefan Beller
2017-06-12 21:23 ` Jeff King
2017-06-12 19:01 ` Jonathan Tan
2017-06-12 19:11 ` Brandon Williams
2017-06-12 20:04 ` Jonathan Tan
2017-06-12 21:28 ` Jeff King
2017-06-20 19:19 ` [PATCH v3 00/20] " Brandon Williams
2017-06-20 19:19 ` [PATCH v3 01/20] setup: don't perform lazy initialization of repository state Brandon Williams
2017-06-20 19:19 ` [PATCH v3 02/20] setup: add comment indicating a hack Brandon Williams
2017-06-20 19:19 ` [PATCH v3 03/20] environment: remove namespace_len variable Brandon Williams
2017-06-20 19:19 ` [PATCH v3 04/20] repository: introduce the repository object Brandon Williams
2017-06-20 19:57 ` Stefan Beller
2017-06-21 21:27 ` Brandon Williams
2017-06-21 21:31 ` Stefan Beller
2017-06-20 21:31 ` Jonathan Tan
2017-06-20 21:56 ` Brandon Williams
2017-06-20 19:19 ` [PATCH v3 05/20] environment: place key repository state in the_repository Brandon Williams
2017-06-20 21:59 ` Jonathan Tan
2017-06-20 19:19 ` [PATCH v3 06/20] environment: store worktree " Brandon Williams
2017-06-20 19:19 ` [PATCH v3 07/20] path: create path.h Brandon Williams
2017-06-20 19:19 ` [PATCH v3 08/20] path: always pass in commondir to update_common_dir Brandon Williams
2017-06-20 19:19 ` [PATCH v3 09/20] path: convert strbuf_git_common_path to take a 'struct repository' Brandon Williams
2017-06-20 19:19 ` [PATCH v3 10/20] path: convert do_git_path " Brandon Williams
2017-06-20 22:23 ` Jonathan Tan
2017-06-21 21:20 ` Brandon Williams
2017-06-20 19:19 ` [PATCH v3 11/20] path: construct correct path to a worktree's index Brandon Williams
2017-06-20 21:10 ` Stefan Beller
2017-06-20 23:02 ` Jonathan Nieder
2017-06-21 0:39 ` Brandon Williams
2017-06-21 2:10 ` Jonathan Nieder
2017-06-21 2:30 ` Jonathan Nieder
2017-06-21 15:43 ` Brandon Williams
2017-06-21 17:57 ` Jonathan Nieder
2017-06-21 18:48 ` Junio C Hamano
2017-06-20 19:19 ` [PATCH v3 12/20] path: add repo_git_path and strbuf_repo_git_path Brandon Williams
2017-06-20 19:19 ` [PATCH v3 13/20] path: add repo_worktree_path and strbuf_repo_worktree_path Brandon Williams
2017-06-20 19:19 ` [PATCH v3 14/20] config: read config from a repository object Brandon Williams
2017-06-20 19:19 ` [PATCH v3 15/20] repository: add index_state to struct repo Brandon Williams
2017-06-21 22:50 ` Jonathan Tan
2017-06-21 22:54 ` Brandon Williams
2017-06-21 23:00 ` Stefan Beller
2017-06-20 19:19 ` [PATCH v3 16/20] submodule-config: store the_submodule_cache in the_repository Brandon Williams
2017-06-20 19:19 ` [PATCH v3 17/20] submodule: add repo_read_gitmodules Brandon Williams
2017-06-20 19:19 ` [PATCH v3 18/20] submodule: convert is_submodule_initialized to work on a repository Brandon Williams
2017-06-20 19:19 ` [PATCH v3 19/20] repository: enable initialization of submodules Brandon Williams
2017-06-21 23:00 ` Jonathan Tan
2017-06-21 23:09 ` Brandon Williams
2017-06-20 19:19 ` [PATCH v3 20/20] ls-files: use repository object Brandon Williams
2017-06-21 22:48 ` Jonathan Tan
2017-06-20 19:23 ` [PATCH v3 00/20] " Stefan Beller
2017-06-22 18:43 ` [PATCH v4 " Brandon Williams
2017-06-22 18:43 ` [PATCH v4 01/20] setup: don't perform lazy initialization of repository state Brandon Williams
2017-06-22 18:43 ` [PATCH v4 02/20] setup: add comment indicating a hack Brandon Williams
2017-06-22 18:43 ` [PATCH v4 03/20] environment: remove namespace_len variable Brandon Williams
2017-06-22 18:43 ` [PATCH v4 04/20] repository: introduce the repository object Brandon Williams
2017-06-22 18:43 ` [PATCH v4 05/20] environment: place key repository state in the_repository Brandon Williams
2017-06-22 18:43 ` [PATCH v4 06/20] environment: store worktree " Brandon Williams
2017-06-22 18:43 ` [PATCH v4 07/20] path: create path.h Brandon Williams
2017-06-22 18:43 ` [PATCH v4 08/20] path: always pass in commondir to update_common_dir Brandon Williams
2017-06-22 18:43 ` [PATCH v4 09/20] path: convert strbuf_git_common_path to take a 'struct repository' Brandon Williams
2017-06-22 18:43 ` [PATCH v4 10/20] path: convert do_git_path " Brandon Williams
2017-06-22 18:43 ` [PATCH v4 11/20] path: worktree_git_path() should not use file relocation Brandon Williams
2017-06-22 18:43 ` [PATCH v4 12/20] path: add repo_git_path and strbuf_repo_git_path Brandon Williams
2017-06-22 18:43 ` [PATCH v4 13/20] path: add repo_worktree_path and strbuf_repo_worktree_path Brandon Williams
2017-06-22 18:43 ` [PATCH v4 14/20] config: read config from a repository object Brandon Williams
2017-06-22 18:43 ` [PATCH v4 15/20] repository: add index_state to struct repo Brandon Williams
2017-06-22 20:16 ` Junio C Hamano
2017-06-22 20:35 ` Brandon Williams
2017-06-22 22:10 ` Junio C Hamano
2017-06-22 18:43 ` [PATCH v4 16/20] submodule-config: store the_submodule_cache in the_repository Brandon Williams
2017-06-22 18:43 ` [PATCH v4 17/20] submodule: add repo_read_gitmodules Brandon Williams
2017-06-22 18:43 ` [PATCH v4 18/20] submodule: convert is_submodule_initialized to work on a repository Brandon Williams
2017-06-22 18:43 ` [PATCH v4 19/20] repository: enable initialization of submodules Brandon Williams
2017-06-22 18:43 ` [PATCH v4 20/20] ls-files: use repository object Brandon Williams
2017-06-22 19:42 ` [PATCH v4 00/20] " Stefan Beller
2017-06-23 16:44 ` Jeff Hostetler
2017-06-23 17:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609000849.GA130522@google.com \
--to=bmwill@google.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.keller@gmail.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).