From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 00CF12027C for ; Fri, 2 Jun 2017 20:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751168AbdFBURg (ORCPT ); Fri, 2 Jun 2017 16:17:36 -0400 Received: from cloud.peff.net ([104.130.231.41]:34071 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbdFBURf (ORCPT ); Fri, 2 Jun 2017 16:17:35 -0400 Received: (qmail 30687 invoked by uid 109); 2 Jun 2017 20:17:35 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Fri, 02 Jun 2017 20:17:35 +0000 Received: (qmail 31123 invoked by uid 111); 2 Jun 2017 20:18:14 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Fri, 02 Jun 2017 16:18:14 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 02 Jun 2017 16:17:33 -0400 Date: Fri, 2 Jun 2017 16:17:33 -0400 From: Jeff King To: SZEDER =?utf-8?B?R8OhYm9y?= Cc: Junio C Hamano , git@vger.kernel.org Subject: Re: [PATCH 0/3] Use skip_prefix() in handle_revision_{,pseudo_}opt() Message-ID: <20170602201733.r277dubonpyuavqv@sigill.intra.peff.net> References: <20170602191010.16834-1-szeder.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170602191010.16834-1-szeder.dev@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jun 02, 2017 at 09:10:07PM +0200, SZEDER Gábor wrote: > While at it, the first one fixes a minor bug, which allowed e.g. 'git > log --no-min-parents-foobarbaz' to succeed. > > The other two are fairly straightforward starts_with() -> > skip_prefix() conversions. These all look fine to me. It would be nice to address the extra cases I mentioned on top, but even without that this is a strict improvement. -Peff