From: Joey Hess <id@joeyh.name>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Peter Simons" <simons@cryp.to>
Subject: Re: reversion in GIT_COMMON_DIR refs path
Date: Fri, 19 May 2017 10:37:27 -0400 [thread overview]
Message-ID: <20170519143727.edi4ni7v5pywm7dk@kitenet.net> (raw)
In-Reply-To: <20170516171028.5eagqr2sw5a2i77d@kitenet.net>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
Joey Hess wrote:
> Bisecting this test suite failure
> https://git-annex.branchable.com/git-annex_in_nixpkgs_fails_with_git-2.13.0/
> I landed on commit f57f37e2e1bf11ab4cdfd221ad47e961ba9353a0 to git.
>
> It seems that changed resolving refs paths when GIT_DIR and GIT_COMMON_DIR
> are both set. While before refs were looked for in GIT_COMMON_DIR,
> now they're not.
In case there's any doubt about whether this is a reversion or an
intentional change, see gitrepository-layout(5):
refs
References are stored in subdirectories of this directory. The git
prune command knows to preserve objects reachable from refs found
in this directory and its subdirectories. This directory is ignored
if $GIT_COMMON_DIR is set and "$GIT_COMMON_DIR/refs" will be used
instead.
So the documented behavior is broken.
--
see shy jo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-19 14:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 17:10 reversion in GIT_COMMON_DIR refs path Joey Hess
2017-05-16 17:50 ` Ævar Arnfjörð Bjarmason
2017-05-16 17:59 ` Joey Hess
2017-05-16 20:37 ` [PATCH] tests: add an optional test to test git-annex Ævar Arnfjörð Bjarmason
2017-05-16 22:10 ` Joey Hess
2017-05-17 2:45 ` Junio C Hamano
2017-05-17 6:47 ` Ævar Arnfjörð Bjarmason
2017-05-17 10:19 ` Junio C Hamano
2017-05-17 19:33 ` Ævar Arnfjörð Bjarmason
2017-05-17 23:03 ` Stefan Beller
2017-05-17 23:59 ` Brandon Williams
2017-05-17 23:56 ` Brandon Williams
2017-05-19 14:37 ` Joey Hess [this message]
2017-05-22 11:11 ` reversion in GIT_COMMON_DIR refs path Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519143727.edi4ni7v5pywm7dk@kitenet.net \
--to=id@joeyh.name \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=simons@cryp.to \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).