From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id A7497201A7 for ; Sat, 13 May 2017 02:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757320AbdEMCDv (ORCPT ); Fri, 12 May 2017 22:03:51 -0400 Received: from cloud.peff.net ([104.130.231.41]:50609 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbdEMCDu (ORCPT ); Fri, 12 May 2017 22:03:50 -0400 Received: (qmail 1571 invoked by uid 109); 13 May 2017 02:03:49 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Sat, 13 May 2017 02:03:49 +0000 Received: (qmail 28779 invoked by uid 111); 13 May 2017 02:04:20 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Fri, 12 May 2017 22:04:20 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 12 May 2017 22:03:46 -0400 Date: Fri, 12 May 2017 22:03:46 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: Josh Hagins , Git Mailing List Subject: Re: [PATCH] config: complain about --local outside of a git repo Message-ID: <20170513020346.25ijajgtwffh7g4b@sigill.intra.peff.net> References: <20170512203436.fcoqauphzvox2sgv@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, May 13, 2017 at 12:31:31AM +0200, Ævar Arnfjörð Bjarmason wrote: > > + if (use_local_config && nongit) > > + die(_("--local only be used inside a git repository")); > > + > > It would be better to have a test for edge cases that are currently > only being discovered by users in the wild. I actually started on one earlier, but what would it check? We already die() in this case. Should we be grepping for the message? It seems more likely to me that we would change the message and cause a false positive than that there would be an actual regression. What I think might be more interesting is if die("BUG") could learn to exit with some error code that the test suite considered invalid. Like calling abort(), which would kill us with SIGABRT and cause test_must_fail to complain. On many systems that would also generate a coredump. Which is handy sometimes, but I wonder if it would be inconvenient for others. I guess that is no different than what a raised assert() would do. But if we were to do that, then the test could easily demonstrate that we expect a clean die(). -Peff