From: Brandon Williams <bmwill@google.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [BUG] :(attr) pathspecs can die("BUG") in the tree-walker
Date: Tue, 9 May 2017 15:52:19 -0700 [thread overview]
Message-ID: <20170509225219.GB106700@google.com> (raw)
In-Reply-To: <20170509222432.3dxt7osjt2zjtaiw@sigill.intra.peff.net>
On 05/09, Jeff King wrote:
> I was playing with the new :(attr) pathspecs in the upcoming v2.13
> today, and noticed:
>
> $ git ls-files -- ':(attr:-diff)'
> t/t0110/url-1
> t/t0110/url-10
> [etc]
>
> So far so good.
>
> $ git ls-tree HEAD -- ':(attr:-diff)'
> fatal: :(attr:-diff): pathspec magic not supported by this command: 'attr'
>
> Bummer, but I understand that sometimes the options need to be plumbed
> through to work everywhere.
>
> $ git log HEAD -- ':(attr:-diff)'
> fatal: BUG:tree-walk.c:947: unsupported magic 40
>
> Whoops. This is presumably ls-tree is protected, but I think we are
> missing a GUARD_PATHSPEC call somewhere.
>
> This isn't a huge deal, as the correct behavior is probably to die like
> ls-tree does, but we probably shouldn't be hitting BUG assertions as a
> general rule.
>
> -Peff
The die("BUG: ..."); is from a GAURD_PATHSPEC call. What really needs
to happen is to update the magic_mask passed into the parse_pathspec
call which initializes the pathspec object. Its this magic_mask which
catches unsupported magic and prints a better message.
I guess this means I (or someone else :D) should audit all the
parse_pathspec calls and ensure that 'attr' magic is turned off until we
won't run into these GAURD_PATHSPEC die's.
--
Brandon Williams
next prev parent reply other threads:[~2017-05-09 22:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 22:24 [BUG] :(attr) pathspecs can die("BUG") in the tree-walker Jeff King
2017-05-09 22:52 ` Brandon Williams [this message]
2017-05-10 1:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509225219.GB106700@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).