From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: git@vger.kernel.org
Cc: "Michael Haggerty" <mhagger@alum.mit.edu>,
"Jonathan Tan" <jonathantanmy@google.com>,
"Stefan Beller" <sbeller@google.com>, "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Brandon Williams" <bmwill@google.com>
Subject: [PATCH v3 00/53] object_id part 8
Date: Sat, 6 May 2017 22:09:45 +0000 [thread overview]
Message-ID: <20170506221038.296722-1-sandals@crustytoothpaste.net> (raw)
This is the eighth series of patches to convert unsigned char [20] to
struct object_id. This series converts lookup_commit, lookup_blob,
lookup_tree, lookup_tag, and finally parse_object to struct object_id.
A small number of functions have temporaries inserted during the
conversion in order to allow conversion of functions that still need to
take unsigned char *; they are removed either later in the series or
will be in a future series.
This series can be fetched from the object-id-part8 branch from either
of the follwing:
https://github.com/bk2204/git
https://git.crustytoothpaste.net/git/bmc/git.git
Changes from v2:
* Remove spurious space after ampersand.
* Undo more needless line rewrapping.
* Expand computation for notes path.
* Remove check for line->len with parse_oid_hex.
Changes from v1:
* Rebase on master. This led to a conflict with the ref-cache changes in patch
39. Extra-careful review here would be welcome.
* Undo the needless line rewrapping.
* Fix the commit message typo.
* Use GIT_MAX_RAWSZ instead of struct object_id for the pack checksum.
brian m. carlson (53):
fetch-pack: convert to struct object_id
Clean up outstanding object_id transforms.
Convert struct cache_tree to use struct object_id
builtin/name-rev: convert to struct object_id
builtin/prune: convert to struct object_id
bundle: convert to struct object_id
branch: convert to struct object_id
builtin/blame: convert static function to struct object_id
builtin/rev-parse: convert to struct object_id
fast-import: convert internal structs to struct object_id
fast-import: convert to struct object_id
submodule: convert merge_submodule to use struct object_id
notes-cache: convert to struct object_id
parse-options-cb: convert to struct object_id
reflog_expire: convert to struct object_id
builtin/verify-commit: convert to struct object_id
tag: convert parse_tag_buffer to struct object_id
http-push: convert some static functions to struct object_id
notes-utils: convert internals to struct object_id
revision: convert prepare_show_merge to struct object_id
shallow: convert shallow registration functions to object_id
sequencer: convert some functions to struct object_id
builtin/tag: convert to struct object_id
Convert remaining callers of lookup_commit_reference* to object_id
Convert lookup_commit* to struct object_id
pack: convert struct pack_idx_entry to struct object_id
builtin/unpack-objects: convert to struct object_id
Convert remaining callers of lookup_blob to object_id
Convert lookup_blob to struct object_id
tree: convert read_tree_1 to use struct object_id internally
builtin/reflog: convert tree_is_complete to take struct object_id
Convert lookup_tree to struct object_id
log-tree: convert to struct object_id
Convert lookup_tag to struct object_id
Convert the verify_pack callback to struct object_id
Convert struct ref_array_item to struct object_id
ref-filter: convert some static functions to struct object_id
refs: convert struct ref_update to use struct object_id
refs/files-backend: convert many internals to struct object_id
http-push: convert process_ls_object and descendants to object_id
revision: rename add_pending_sha1 to add_pending_oid
revision: convert remaining parse_object callers to object_id
upload-pack: convert remaining parse_object callers to object_id
sha1_name: convert internals of peel_onion to object_id
builtin/read-tree: convert to struct object_id
builtin/ls-files: convert overlay_tree_on_cache to object_id
sequencer: convert fast_forward_to to struct object_id
merge: convert checkout_fast_forward to struct object_id
builtin/ls-tree: convert to struct object_id
diff-lib: convert do_diff_cache to struct object_id
sequencer: convert do_recursive_merge to struct object_id
tree: convert parse_tree_indirect to struct object_id
object: convert parse_object* to take struct object_id
archive.c | 6 +-
bisect.c | 2 +-
blob.c | 6 +-
blob.h | 2 +-
branch.c | 16 +-
builtin/am.c | 18 +-
builtin/blame.c | 14 +-
builtin/branch.c | 6 +-
builtin/checkout.c | 18 +-
builtin/clone.c | 4 +-
builtin/commit-tree.c | 2 +-
builtin/commit.c | 8 +-
builtin/describe.c | 10 +-
builtin/diff-tree.c | 8 +-
builtin/diff.c | 6 +-
builtin/fast-export.c | 8 +-
builtin/fetch.c | 7 +-
builtin/fmt-merge-msg.c | 8 +-
builtin/fsck.c | 16 +-
builtin/grep.c | 2 +-
builtin/index-pack.c | 56 ++---
builtin/log.c | 10 +-
builtin/ls-files.c | 6 +-
builtin/ls-tree.c | 6 +-
builtin/merge-base.c | 6 +-
builtin/merge-tree.c | 10 +-
builtin/merge.c | 12 +-
builtin/name-rev.c | 32 +--
builtin/notes.c | 2 +-
builtin/pack-objects.c | 71 ++++---
builtin/prune.c | 7 +-
builtin/pull.c | 14 +-
builtin/read-tree.c | 10 +-
builtin/receive-pack.c | 8 +-
builtin/reflog.c | 36 ++--
builtin/replace.c | 6 +-
builtin/reset.c | 10 +-
builtin/rev-list.c | 2 +-
builtin/rev-parse.c | 56 ++---
builtin/show-branch.c | 4 +-
builtin/tag.c | 66 +++---
builtin/unpack-objects.c | 65 +++---
builtin/verify-commit.c | 12 +-
bulk-checkin.c | 4 +-
bundle.c | 39 ++--
bundle.h | 4 +-
cache-tree.c | 33 +--
cache-tree.h | 3 +-
cache.h | 4 +-
commit.c | 38 ++--
commit.h | 16 +-
diff-lib.c | 12 +-
diff.c | 4 +-
diff.h | 2 +-
fast-import.c | 447 ++++++++++++++++++++--------------------
fetch-pack.c | 97 ++++-----
fsck.c | 6 +-
http-backend.c | 2 +-
http-push.c | 55 ++---
list-objects.c | 4 +-
log-tree.c | 26 +--
merge-recursive.c | 16 +-
merge.c | 4 +-
notes-cache.c | 29 ++-
notes-cache.h | 4 +-
notes-merge.c | 26 +--
notes-utils.c | 18 +-
object.c | 38 ++--
object.h | 8 +-
pack-bitmap-write.c | 8 +-
pack-bitmap.c | 4 +-
pack-check.c | 25 ++-
pack-objects.c | 8 +-
pack-write.c | 10 +-
pack.h | 4 +-
parse-options-cb.c | 6 +-
pretty.c | 2 +-
reachable.c | 8 +-
ref-filter.c | 38 ++--
ref-filter.h | 2 +-
reflog-walk.c | 6 +-
refs.c | 4 +-
refs.h | 6 +-
refs/files-backend.c | 158 +++++++-------
refs/ref-cache.c | 4 +-
refs/ref-cache.h | 2 +-
refs/refs-internal.h | 4 +-
remote.c | 17 +-
revision.c | 76 +++----
revision.h | 6 +-
sequencer.c | 59 +++---
server-info.c | 2 +-
sha1_name.c | 38 ++--
shallow.c | 34 +--
submodule.c | 32 +--
submodule.h | 8 +-
t/helper/test-dump-cache-tree.c | 4 +-
t/helper/test-match-trees.c | 4 +-
tag.c | 25 ++-
tag.h | 2 +-
transport.c | 2 +-
tree.c | 22 +-
tree.h | 4 +-
upload-pack.c | 60 +++---
walker.c | 8 +-
wt-status.c | 2 +-
106 files changed, 1178 insertions(+), 1139 deletions(-)
next reply other threads:[~2017-05-06 22:11 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 22:09 brian m. carlson [this message]
2017-05-06 22:09 ` [PATCH v3 01/53] fetch-pack: convert to struct object_id brian m. carlson
2017-05-06 22:09 ` [PATCH v3 02/53] Clean up outstanding object_id transforms brian m. carlson
2017-05-06 22:09 ` [PATCH v3 03/53] Convert struct cache_tree to use struct object_id brian m. carlson
2017-05-06 22:09 ` [PATCH v3 04/53] builtin/name-rev: convert to " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 05/53] builtin/prune: " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 06/53] bundle: " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 07/53] branch: " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 08/53] builtin/blame: convert static function " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 09/53] builtin/rev-parse: convert " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 10/53] fast-import: convert internal structs " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 11/53] fast-import: convert " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 12/53] submodule: convert merge_submodule to use " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 13/53] notes-cache: convert to " brian m. carlson
2017-05-06 22:09 ` [PATCH v3 14/53] parse-options-cb: " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 15/53] reflog_expire: " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 16/53] builtin/verify-commit: " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 17/53] tag: convert parse_tag_buffer " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 18/53] http-push: convert some static functions " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 19/53] notes-utils: convert internals " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 20/53] revision: convert prepare_show_merge " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 21/53] shallow: convert shallow registration functions to object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 22/53] sequencer: convert some functions to struct object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 23/53] builtin/tag: convert " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 24/53] Convert remaining callers of lookup_commit_reference* to object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 25/53] Convert lookup_commit* to struct object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 26/53] pack: convert struct pack_idx_entry " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 27/53] builtin/unpack-objects: convert " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 28/53] Convert remaining callers of lookup_blob to object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 29/53] Convert lookup_blob to struct object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 30/53] tree: convert read_tree_1 to use struct object_id internally brian m. carlson
2017-05-06 22:10 ` [PATCH v3 31/53] builtin/reflog: convert tree_is_complete to take struct object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 32/53] Convert lookup_tree to " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 33/53] log-tree: convert " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 34/53] Convert lookup_tag " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 35/53] Convert the verify_pack callback " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 36/53] Convert struct ref_array_item " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 37/53] ref-filter: convert some static functions " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 38/53] refs: convert struct ref_update to use " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 39/53] refs/files-backend: convert many internals to " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 40/53] http-push: convert process_ls_object and descendants to object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 41/53] revision: rename add_pending_sha1 to add_pending_oid brian m. carlson
2017-05-06 22:10 ` [PATCH v3 42/53] revision: convert remaining parse_object callers to object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 43/53] upload-pack: " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 44/53] sha1_name: convert internals of peel_onion " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 45/53] builtin/read-tree: convert to struct object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 46/53] builtin/ls-files: convert overlay_tree_on_cache to object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 47/53] sequencer: convert fast_forward_to to struct object_id brian m. carlson
2017-05-06 22:10 ` [PATCH v3 48/53] merge: convert checkout_fast_forward " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 49/53] builtin/ls-tree: convert " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 50/53] diff-lib: convert do_diff_cache " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 51/53] sequencer: convert do_recursive_merge " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 52/53] tree: convert parse_tree_indirect " brian m. carlson
2017-05-06 22:10 ` [PATCH v3 53/53] object: convert parse_object* to take " brian m. carlson
2017-05-08 21:53 ` [PATCH v3 00/53] object_id part 8 Jonathan Tan
2017-05-09 22:13 ` Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170506221038.296722-1-sandals@crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).