From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, Stefan Beller <sbeller@google.com>
Subject: [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS
Date: Mon, 1 May 2017 12:07:14 -0700 [thread overview]
Message-ID: <20170501190719.10669-1-sbeller@google.com> (raw)
This applies to origin/master.
For better readability and understandability for newcomers it is a good idea
to not offer 2 APIs doing the same thing with on being the #define of the other.
In the long run we may want to drop the macros guarded by
NO_THE_INDEX_COMPATIBILITY_MACROS. This converts a couple of them.
My main reason for this patch is to try out coccinelle as well as a
discussion I had off list about maintainability of software.
I just made these patches and wonder if now is a good time to pull through and
convert the rest as well?
Thanks,
Stefan
Stefan Beller (5):
cache.h: drop read_cache()
cache.h: drop active_* macros
cache.h: drop read_cache_from
cache.h: drop read_cache_preload(pathspec)
cache.h: drop read_cache_unmerged()
apply.c | 10 +++----
builtin/add.c | 10 +++----
builtin/am.c | 14 +++++-----
builtin/blame.c | 10 +++----
builtin/check-attr.c | 2 +-
builtin/check-ignore.c | 4 +--
builtin/checkout-index.c | 10 +++----
builtin/checkout.c | 53 ++++++++++++++++++------------------
builtin/clean.c | 2 +-
builtin/commit.c | 32 +++++++++++-----------
builtin/describe.c | 2 +-
builtin/diff-files.c | 4 +--
builtin/diff-index.c | 6 ++--
builtin/diff.c | 14 +++++-----
builtin/fsck.c | 14 +++++-----
builtin/grep.c | 10 +++----
builtin/ls-files.c | 38 +++++++++++++-------------
builtin/merge-index.c | 12 ++++----
builtin/merge.c | 14 +++++-----
builtin/mv.c | 12 ++++----
builtin/pull.c | 2 +-
builtin/read-tree.c | 4 +--
builtin/reset.c | 4 +--
builtin/rev-parse.c | 2 +-
builtin/rm.c | 18 ++++++------
builtin/submodule--helper.c | 10 +++----
builtin/update-index.c | 52 ++++++++++++++++++-----------------
cache.h | 10 -------
check-racy.c | 6 ++--
diff-lib.c | 6 ++--
diff.c | 10 +++----
dir.c | 20 +++++++-------
merge-recursive.c | 30 ++++++++++----------
merge.c | 2 +-
pathspec.c | 14 +++++-----
read-cache.c | 4 +--
rerere.c | 32 +++++++++++-----------
revision.c | 22 +++++++--------
sequencer.c | 27 +++++++++---------
sha1_name.c | 16 +++++------
submodule.c | 16 +++++------
t/helper/test-dump-cache-tree.c | 4 +--
t/helper/test-dump-untracked-cache.c | 2 +-
t/helper/test-lazy-init-name-hash.c | 10 +++----
t/helper/test-read-cache.c | 2 +-
t/helper/test-scrap-cache-tree.c | 4 +--
t/t2107-update-index-basic.sh | 2 +-
tree.c | 8 +++---
wt-status.c | 12 ++++----
49 files changed, 309 insertions(+), 315 deletions(-)
--
2.13.0.rc1.1.gbc33f0f778
next reply other threads:[~2017-05-01 19:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 19:07 Stefan Beller [this message]
2017-05-01 19:07 ` [PATCH 1/5] cache.h: drop read_cache() Stefan Beller
2017-05-01 19:07 ` [PATCH 2/5] cache.h: drop active_* macros Stefan Beller
2017-05-01 19:07 ` [PATCH 3/5] cache.h: drop read_cache_from Stefan Beller
2017-05-01 19:07 ` [PATCH 4/5] cache.h: drop read_cache_preload(pathspec) Stefan Beller
2017-05-01 19:07 ` [PATCH 5/5] cache.h: drop read_cache_unmerged() Stefan Beller
2017-05-02 1:36 ` [PATCH 0/5] Start of a journey: drop NO_THE_INDEX_COMPATIBILITY_MACROS Junio C Hamano
2017-05-02 4:17 ` Stefan Beller
2017-05-02 14:05 ` Jeff Hostetler
2017-05-03 11:31 ` Samuel Lijin
2017-05-03 17:14 ` Stefan Beller
2017-05-03 18:22 ` Samuel Lijin
2017-05-04 3:29 ` Brandon Williams
2017-05-03 10:27 ` Duy Nguyen
2017-05-03 17:02 ` Stefan Beller
2017-05-04 2:48 ` Junio C Hamano
2017-05-04 3:24 ` Brandon Williams
2017-05-04 18:30 ` Stefan Beller
2017-05-05 14:31 ` Johannes Schindelin
2017-05-05 17:20 ` Brandon Williams
2017-05-04 19:19 ` Jonathan Nieder
2017-05-05 17:22 ` Junio C Hamano
2017-05-05 17:29 ` Brandon Williams
2017-05-02 15:35 ` Jeff Hostetler
2017-05-02 17:06 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501190719.10669-1-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).