git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: git@vger.kernel.org
Cc: "Michael Haggerty" <mhagger@alum.mit.edu>,
	"Jeff King" <peff@peff.net>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: [PATCH 34/53] Convert lookup_tag to struct object_id
Date: Sun, 23 Apr 2017 21:34:34 +0000	[thread overview]
Message-ID: <20170423213453.253425-35-sandals@crustytoothpaste.net> (raw)
In-Reply-To: <20170423213453.253425-1-sandals@crustytoothpaste.net>

Convert lookup_tag to take a pointer to struct object_id.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 builtin/describe.c     | 6 +++---
 builtin/pack-objects.c | 2 +-
 builtin/replace.c      | 2 +-
 log-tree.c             | 2 +-
 object.c               | 2 +-
 sha1_name.c            | 2 +-
 tag.c                  | 8 ++++----
 tag.h                  | 2 +-
 8 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/builtin/describe.c b/builtin/describe.c
index f6032f593..893c8789f 100644
--- a/builtin/describe.c
+++ b/builtin/describe.c
@@ -79,13 +79,13 @@ static int replace_name(struct commit_name *e,
 		struct tag *t;
 
 		if (!e->tag) {
-			t = lookup_tag(e->oid.hash);
+			t = lookup_tag(&e->oid);
 			if (!t || parse_tag(t))
 				return 1;
 			e->tag = t;
 		}
 
-		t = lookup_tag(oid->hash);
+		t = lookup_tag(oid);
 		if (!t || parse_tag(t))
 			return 0;
 		*tag = t;
@@ -245,7 +245,7 @@ static unsigned long finish_depth_computation(
 static void display_name(struct commit_name *n)
 {
 	if (n->prio == 2 && !n->tag) {
-		n->tag = lookup_tag(n->oid.hash);
+		n->tag = lookup_tag(&n->oid);
 		if (!n->tag || parse_tag(n->tag))
 			die(_("annotated tag %s not available"), n->path);
 	}
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index d76ff0542..7cebb5a7f 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -2348,7 +2348,7 @@ static void add_tag_chain(const struct object_id *oid)
 	if (packlist_find(&to_pack, oid->hash, NULL))
 		return;
 
-	tag = lookup_tag(oid->hash);
+	tag = lookup_tag(oid);
 	while (1) {
 		if (!tag || parse_tag(tag) || !tag->tagged)
 			die("unable to pack objects reachable from tag %s",
diff --git a/builtin/replace.c b/builtin/replace.c
index e2ea3d47b..205510b5b 100644
--- a/builtin/replace.c
+++ b/builtin/replace.c
@@ -354,7 +354,7 @@ static void check_one_mergetag(struct commit *commit,
 	int i;
 
 	hash_sha1_file(extra->value, extra->len, typename(OBJ_TAG), tag_oid.hash);
-	tag = lookup_tag(tag_oid.hash);
+	tag = lookup_tag(&tag_oid);
 	if (!tag)
 		die(_("bad mergetag in commit '%s'"), ref);
 	if (parse_tag_buffer(tag, extra->value, extra->len))
diff --git a/log-tree.c b/log-tree.c
index 169fd039f..6532c892c 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -488,7 +488,7 @@ static void show_one_mergetag(struct commit *commit,
 	size_t payload_size, gpg_message_offset;
 
 	hash_sha1_file(extra->value, extra->len, typename(OBJ_TAG), oid.hash);
-	tag = lookup_tag(oid.hash);
+	tag = lookup_tag(&oid);
 	if (!tag)
 		return; /* error message already given */
 
diff --git a/object.c b/object.c
index d23c5fad3..dd4d3a1ea 100644
--- a/object.c
+++ b/object.c
@@ -220,7 +220,7 @@ struct object *parse_object_buffer(const unsigned char *sha1, enum object_type t
 			obj = &commit->object;
 		}
 	} else if (type == OBJ_TAG) {
-		struct tag *tag = lookup_tag(sha1);
+		struct tag *tag = lookup_tag(&oid);
 		if (tag) {
 			if (parse_tag_buffer(tag, buffer, size))
 			       return NULL;
diff --git a/sha1_name.c b/sha1_name.c
index 390a09c41..b7e09ac13 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -361,7 +361,7 @@ static int show_ambiguous_object(const struct object_id *oid, void *data)
 			format_commit_message(commit, " %ad - %s", &desc, &pp);
 		}
 	} else if (type == OBJ_TAG) {
-		struct tag *tag = lookup_tag(oid->hash);
+		struct tag *tag = lookup_tag(oid);
 		if (!parse_tag(tag) && tag->tag)
 			strbuf_addf(&desc, " %s", tag->tag);
 	}
diff --git a/tag.c b/tag.c
index 062516b40..571798519 100644
--- a/tag.c
+++ b/tag.c
@@ -89,11 +89,11 @@ struct object *deref_tag_noverify(struct object *o)
 	return o;
 }
 
-struct tag *lookup_tag(const unsigned char *sha1)
+struct tag *lookup_tag(const struct object_id *oid)
 {
-	struct object *obj = lookup_object(sha1);
+	struct object *obj = lookup_object(oid->hash);
 	if (!obj)
-		return create_object(sha1, alloc_tag_node());
+		return create_object(oid->hash, alloc_tag_node());
 	return object_as_type(obj, OBJ_TAG, 0);
 }
 
@@ -148,7 +148,7 @@ int parse_tag_buffer(struct tag *item, const void *data, unsigned long size)
 	} else if (!strcmp(type, commit_type)) {
 		item->tagged = &lookup_commit(&oid)->object;
 	} else if (!strcmp(type, tag_type)) {
-		item->tagged = &lookup_tag(oid.hash)->object;
+		item->tagged = &lookup_tag(&oid)->object;
 	} else {
 		error("Unknown type %s", type);
 		item->tagged = NULL;
diff --git a/tag.h b/tag.h
index a5721b673..8d6fc2814 100644
--- a/tag.h
+++ b/tag.h
@@ -12,7 +12,7 @@ struct tag {
 	unsigned long date;
 };
 
-extern struct tag *lookup_tag(const unsigned char *sha1);
+extern struct tag *lookup_tag(const struct object_id *oid);
 extern int parse_tag_buffer(struct tag *item, const void *data, unsigned long size);
 extern int parse_tag(struct tag *item);
 extern struct object *deref_tag(struct object *, const char *, int);

  parent reply	other threads:[~2017-04-23 21:37 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-23 21:34 [PATCH 00/53] object_id part 8 brian m. carlson
2017-04-23 21:34 ` [PATCH 01/53] fetch-pack: convert to struct object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 02/53] Clean up outstanding object_id transforms brian m. carlson
2017-04-23 21:34 ` [PATCH 03/53] Convert struct cache_tree to use struct object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 04/53] builtin/name-rev: convert to " brian m. carlson
2017-04-23 21:34 ` [PATCH 05/53] builtin/prune: " brian m. carlson
2017-04-23 21:34 ` [PATCH 06/53] bundle: " brian m. carlson
2017-04-23 21:34 ` [PATCH 07/53] branch: " brian m. carlson
2017-04-23 21:34 ` [PATCH 08/53] builtin/blame: convert static function " brian m. carlson
2017-04-23 21:34 ` [PATCH 09/53] builtin/rev-parse: convert " brian m. carlson
2017-04-23 21:34 ` [PATCH 10/53] fast-import: convert internal structs " brian m. carlson
2017-04-23 21:34 ` [PATCH 11/53] fast-import: convert " brian m. carlson
2017-04-24 17:20   ` Stefan Beller
2017-04-24 23:23     ` brian m. carlson
2017-04-23 21:34 ` [PATCH 12/53] submodule: convert merge_submodule to use " brian m. carlson
2017-04-23 21:34 ` [PATCH 13/53] notes-cache: convert to " brian m. carlson
2017-04-24 22:10   ` Stefan Beller
2017-04-23 21:34 ` [PATCH 14/53] parse-options-cb: " brian m. carlson
2017-04-23 21:34 ` [PATCH 15/53] reflog_expire: " brian m. carlson
2017-04-23 21:34 ` [PATCH 16/53] builtin/verify-commit: " brian m. carlson
2017-04-23 21:34 ` [PATCH 17/53] tag: convert parse_tag_buffer " brian m. carlson
2017-04-23 21:34 ` [PATCH 18/53] http-push: convert some static functions " brian m. carlson
2017-04-23 21:34 ` [PATCH 19/53] notes-utils: convert internals " brian m. carlson
2017-04-23 21:34 ` [PATCH 20/53] revision: convert prepare_show_merge " brian m. carlson
2017-04-23 21:34 ` [PATCH 21/53] shallow: convert shallow registration functions to object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 22/53] sequencer: convert some functions to struct object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 23/53] builtin/tag: convert " brian m. carlson
2017-04-23 21:34 ` [PATCH 24/53] Convert remaining callers of lookup_commit_reference* to object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 25/53] Convert lookup_commit* to struct object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 26/53] pack: convert struct pack_idx_entry " brian m. carlson
2017-04-23 21:34 ` [PATCH 27/53] builtin/unpack-objects: convert " brian m. carlson
2017-04-23 21:34 ` [PATCH 28/53] Convert remaining callers of lookup_blob to object_id brian m. carlson
2017-04-24 23:05   ` Stefan Beller
2017-04-23 21:34 ` [PATCH 29/53] Convert lookup_blob to struct object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 30/53] tree: convert read_tree_1 to use struct object_id internally brian m. carlson
2017-04-23 21:34 ` [PATCH 31/53] builtin/reflog: convert tree_is_complete to take struct object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 32/53] Convert lookup_tree to " brian m. carlson
2017-04-23 21:34 ` [PATCH 33/53] log-tree: convert " brian m. carlson
2017-04-23 21:34 ` brian m. carlson [this message]
2017-04-23 21:34 ` [PATCH 35/53] Convert the verify_pack callback " brian m. carlson
2017-04-26 23:01   ` Stefan Beller
2017-04-27  5:52   ` Jeff King
2017-04-28  0:17     ` brian m. carlson
2017-04-28  1:14       ` Jeff King
2017-04-23 21:34 ` [PATCH 36/53] Convert struct ref_array_item " brian m. carlson
2017-04-23 21:34 ` [PATCH 37/53] ref-filter: convert some static functions " brian m. carlson
2017-04-23 21:34 ` [PATCH 38/53] refs: convert struct ref_update to use " brian m. carlson
2017-04-27  4:55   ` Michael Haggerty
2017-04-23 21:34 ` [PATCH 39/53] refs/files-backend: convert many internals to " brian m. carlson
2017-04-27  5:04   ` Michael Haggerty
2017-04-23 21:34 ` [PATCH 40/53] http-push: convert process_ls_object and descendants to object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 41/53] revision: rename add_pending_sha1 to add_pending_oid brian m. carlson
2017-04-23 21:34 ` [PATCH 42/53] revision: convert remaining parse_object callers to object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 43/53] upload-pack: " brian m. carlson
2017-04-23 21:34 ` [PATCH 44/53] sha1_name: convert internals of peel_onion " brian m. carlson
2017-04-23 21:34 ` [PATCH 45/53] builtin/read-tree: convert to struct object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 46/53] builtin/ls-files: convert overlay_tree_on_cache to object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 47/53] sequencer: convert fast_forward_to to struct object_id brian m. carlson
2017-04-23 21:34 ` [PATCH 48/53] merge: convert checkout_fast_forward " brian m. carlson
2017-04-23 21:34 ` [PATCH 49/53] builtin/ls-tree: convert " brian m. carlson
2017-04-23 21:34 ` [PATCH 50/53] diff-lib: convert do_diff_cache " brian m. carlson
2017-04-23 21:34 ` [PATCH 51/53] sequencer: convert do_recursive_merge " brian m. carlson
2017-04-23 21:34 ` [PATCH 52/53] tree: convert parse_tree_indirect " brian m. carlson
2017-04-23 21:34 ` [PATCH 53/53] object: convert parse_object* to take " brian m. carlson
2017-04-27 21:46   ` Stefan Beller
2017-04-24  6:23 ` [PATCH 00/53] object_id part 8 Junio C Hamano
2017-04-24 16:08 ` Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170423213453.253425-35-sandals@crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=mhagger@alum.mit.edu \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).