From: Jeff King <peff@peff.net>
To: David Turner <David.Turner@twosigma.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"christian.couder@gmail.com" <christian.couder@gmail.com>,
"mfick@codeaurora.org" <mfick@codeaurora.org>,
"jacob.keller@gmail.com" <jacob.keller@gmail.com>
Subject: Re: [PATCH] repack: respect gc.pid lock
Date: Thu, 20 Apr 2017 16:14:43 -0400 [thread overview]
Message-ID: <20170420201443.ee4tgoymzpfvl4jq@sigill.intra.peff.net> (raw)
In-Reply-To: <7e31f4ed5c0f4c31b2870fb58cf7110e@exmbdft7.ad.twosigma.com>
On Thu, Apr 20, 2017 at 08:10:24PM +0000, David Turner wrote:
> > Is "-a" or "-A" the key factor? Are there current callers who prefer the current
> > behavior of "possibly duplicate some work, but never report failure" versus "do
> > not duplicate work, but sometimes fail due to lock contention"?
>
> One problem with failing is that it can leave a temp pack behind.
Yeah. IMHO we should probably treat failed object and pack writes as
normal tempfiles and remove them (but possibly respect a "debug mode"
that leaves them around). But that's another patch entirely.
> I think the correct fix is to change the default code.packedGitLimit on 64-bit
> machines to 32 terabytes (2**45 bytes). That's because on modern Intel
> processors, there are 48 bits of address space actually available, but the kernel
> is going to probably reserve a few bits. My machine claims to have 2**46 bytes
> of virtual address space available. It's also several times bigger than any
> repo that I know of or can easily imagine.
>
> Does that seem reasonable to you?
Yes, it does.
-Peff
prev parent reply other threads:[~2017-04-20 20:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 20:27 [PATCH] repack: respect gc.pid lock David Turner
2017-04-14 0:33 ` Jacob Keller
2017-04-14 19:33 ` Jeff King
2017-04-17 23:29 ` David Turner
2017-04-18 3:41 ` Jeff King
2017-04-18 17:08 ` David Turner
2017-04-18 17:16 ` Jeff King
2017-04-18 17:16 ` David Turner
2017-04-18 17:19 ` Jeff King
2017-04-18 17:43 ` David Turner
2017-04-18 17:50 ` Jeff King
2017-04-20 20:10 ` David Turner
2017-04-20 20:14 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420201443.ee4tgoymzpfvl4jq@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=David.Turner@twosigma.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=mfick@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).