From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 36B131FE90 for ; Wed, 19 Apr 2017 22:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765050AbdDSWl1 (ORCPT ); Wed, 19 Apr 2017 18:41:27 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:33285 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764613AbdDSWlZ (ORCPT ); Wed, 19 Apr 2017 18:41:25 -0400 Received: by mail-wr0-f194.google.com with SMTP id w50so313892wrc.0 for ; Wed, 19 Apr 2017 15:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ivxE+4twyBZsGI+JW3l6d9a2Ft29cNo7cclBn+oGNBY=; b=XPODUF1sUgqIbCrjqdViS1pypI/SxxfOvL8r1VoNZwElfRTX8LylbDYTH4L8JE21BR NMTf4DOuGqnGrK0g3PZ9eoxG3TJtlQdLo+NuFn0Bxk8p0xQYv6n0zQewjxTHEdPeUXgo jKIXSZYxZhZp/TJrD6OGUrf5BJpzIyxkAU8LGHwqjq4CjHYHHzdAXEgz+DT8RjWGJ+1/ NCnbBa+6PEDROBuymFhy+m8HsSOeJQJyJgMDJiQZfgNoZq1AkqDwkGQpULroVSi8uWmv zwyeHv/fuCEB6xY6J/1R2FdEEMS9JWNETyoHvwuM7IZs+wgRko4Hfz/FC1W2ZC05eHW7 L6pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ivxE+4twyBZsGI+JW3l6d9a2Ft29cNo7cclBn+oGNBY=; b=Ouxwaj8j9MCi0VcAX3hbFQ7PRse3GIEFJmng1+iOpIlWi8jmDK9DR/gLsQ6V3IF7og g3u/xFA1JoLZLkrof450hoyEKJAs8mGpPX4/pOgdSrrRtN9L1BAXP0OU+IZL8jmfDDaD pA7MTNjwKcKIQudmoGoezRDfudhsPzmnSBnAYmORtZ9GDQcsU53/1ye+X6K5kyapg9hy 60R5sakSeyUbduC31ov10O0HfoOpLK5cqv56fSOUoFX7zvjhf4WoaMzb2/Tqpw9lyJXS AyiGuNRRpXaDW8uIvn+l+AqfZObg9DeuY1Z8IA19qL1kFoyKI+Wmw3iKOMJmnHvR3pWJ zJCw== X-Gm-Message-State: AN3rC/7odyCHAHsGQHrsLYxiX3qE/dJrxYcLLthdt21+gqhTFffJAiNU GRRsQ9sMH+3/AQ== X-Received: by 10.223.135.134 with SMTP id b6mr4659497wrb.48.1492641682795; Wed, 19 Apr 2017 15:41:22 -0700 (PDT) Received: from u.nix.is ([2a01:4f8:190:5095::2]) by smtp.gmail.com with ESMTPSA id q130sm21128996wmd.29.2017.04.19.15.41.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Apr 2017 15:41:21 -0700 (PDT) From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= To: git@vger.kernel.org Cc: Junio C Hamano , Jeff King , Jeffrey Walton , =?UTF-8?q?Micha=C5=82=20Kiedrowicz?= , J Smith , Victor Leschuk , =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?= , Fredrik Kuivinen , =?UTF-8?q?Zolt=C3=A1n=20Herczeg?= , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH v2 02/13] Makefile & configure: reword outdated comment about PCRE Date: Wed, 19 Apr 2017 22:40:42 +0000 Message-Id: <20170419224053.8920-3-avarab@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170419224053.8920-1-avarab@gmail.com> References: <20170419224053.8920-1-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Reword an outdated comment which suggests that only git-grep can use PCRE. This comment was added back when PCRE support was initially added in commit 63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09), and was true at the time. It hasn't been telling the full truth since git-log learned to use PCRE with --grep in commit 727b6fc3ed ("log --grep: accept --basic-regexp and --perl-regexp", 2012-10-03), and more importantly is likely to get more inaccurate over time as more use is made of PCRE in other areas. Reword it to be more future-proof, and to more clearly explain that this enables user-initiated runtime behavior. Copy/pasting this so much in configure.ac is lame, these Makefile-like flags aren't even used by autoconf, just the corresponding --with[out]-* options. But copy/pasting the comments that make sense for the Makefile to configure.ac where they make less sence is the pattern everything else follows in that file. I'm not going to war against that as part of this change, just following the existing pattern. Signed-off-by: Ævar Arnfjörð Bjarmason --- Makefile | 6 ++++-- configure.ac | 12 ++++++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index d595ea3837..516f57aac8 100644 --- a/Makefile +++ b/Makefile @@ -24,8 +24,10 @@ all:: # Define NO_OPENSSL environment variable if you do not have OpenSSL. # This also implies BLK_SHA1. # -# Define USE_LIBPCRE if you have and want to use libpcre. git-grep will be -# able to use Perl-compatible regular expressions. +# Define USE_LIBPCRE if you have and want to use libpcre. Various +# commands such as log and grep offer runtime options to use +# Perl-compatible regular expressions instead of standard or extended +# POSIX regular expressions. # # Define LIBPCREDIR=/foo/bar if your libpcre header and library files are in # /foo/bar/include and /foo/bar/lib directories. diff --git a/configure.ac b/configure.ac index 128165529f..deeb968daa 100644 --- a/configure.ac +++ b/configure.ac @@ -250,8 +250,10 @@ AS_HELP_STRING([--with-openssl],[use OpenSSL library (default is YES)]) AS_HELP_STRING([], [ARG can be prefix for openssl library and headers]), GIT_PARSE_WITH([openssl])) -# Define USE_LIBPCRE if you have and want to use libpcre. git-grep will be -# able to use Perl-compatible regular expressions. +# Define USE_LIBPCRE if you have and want to use libpcre. Various +# commands such as log and grep offer runtime options to use +# Perl-compatible regular expressions instead of standard or extended +# POSIX regular expressions. # # Define LIBPCREDIR=/foo/bar if your libpcre header and library files are in # /foo/bar/include and /foo/bar/lib directories. @@ -499,8 +501,10 @@ GIT_CONF_SUBST([NEEDS_SSL_WITH_CRYPTO]) GIT_CONF_SUBST([NO_OPENSSL]) # -# Define USE_LIBPCRE if you have and want to use libpcre. git-grep will be -# able to use Perl-compatible regular expressions. +# Define USE_LIBPCRE if you have and want to use libpcre. Various +# commands such as log and grep offer runtime options to use +# Perl-compatible regular expressions instead of standard or extended +# POSIX regular expressions. # if test -n "$USE_LIBPCRE"; then -- 2.11.0