From: Jeff King <peff@peff.net>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: "Jacob Keller" <jacob.e.keller@intel.com>,
"Git mailing list" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"René Scharfe" <l.s.r@web.de>
Subject: Re: [RFC PATCH] parse-options: disallow double-negations of options starting with no-
Date: Wed, 19 Apr 2017 17:00:28 -0400 [thread overview]
Message-ID: <20170419210028.sky24qda7kp4pl5y@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+P7+xqo6BJ8LXy8EVvq0JXPD4r-jZ6boOGT=2XY8SVnWfVMcQ@mail.gmail.com>
On Wed, Apr 19, 2017 at 01:54:06PM -0700, Jacob Keller wrote:
> This is why it's an RFC. I don't really feel that it's too much of a
> problem. As for the reason why I thought it might want a flag itself
> is because of concerns raised earlier that we might have something
> liek
>
> OPT_BOOL( ... "no-stage" ...)
> OPT_INT(... "stage" ....)
>
> or something already which might be broken and the only proper way to
> disable no-stage is no-no-stage?
>
> Is this actually a concern? I thought this was a comment raised by you
> earlier as an objection to a change unless we specifically flagged
> them as OPT_NEGBOOL()
I think the breakage in that case would be caused by "--no-stage" taking
over "--stage" as well. And your patch doesn't change that; it happened
already in 2012.
Your patch only affects the --no-no- form, which I think we would never
want. I don't think it needs callers to trigger it explicitly.
-Peff
next prev parent reply other threads:[~2017-04-19 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 9:08 [RFC PATCH] parse-options: disallow double-negations of options starting with no- Jacob Keller
2017-04-19 9:34 ` Ævar Arnfjörð Bjarmason
2017-04-19 12:58 ` René Scharfe
2017-04-19 15:10 ` Jeff King
2017-04-19 20:54 ` Jacob Keller
2017-04-19 21:00 ` Jeff King [this message]
2017-04-19 21:22 ` Jacob Keller
2017-04-19 21:23 ` Jacob Keller
2017-04-19 21:24 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419210028.sky24qda7kp4pl5y@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).