From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 6ED5920960 for ; Fri, 14 Apr 2017 05:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbdDNFfI (ORCPT ); Fri, 14 Apr 2017 01:35:08 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:53190 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbdDNFfI (ORCPT ); Fri, 14 Apr 2017 01:35:08 -0400 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8D07720960; Fri, 14 Apr 2017 05:35:07 +0000 (UTC) Date: Fri, 14 Apr 2017 05:35:07 +0000 From: Eric Wong To: Brandon Williams Cc: git@vger.kernel.org, jrnieder@gmail.com Subject: Re: [PATCH 7/6] run-command: block signals between fork and execve Message-ID: <20170414053507.GB815@starla> References: <20170410234919.34586-1-bmwill@google.com> <20170413183252.4713-1-bmwill@google.com> <20170413211428.GA5961@whir> <20170414024202.GA27281@google.com> <20170414052624.GA815@starla> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170414052624.GA815@starla> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Eric Wong wrote: > Brandon Williams wrote: > > On 04/13, Eric Wong wrote: > > > @@ -277,6 +278,8 @@ static void child_err_spew(struct child_process *cmd, struct child_err *cerr) > > > error_errno("exec '%s': cd to '%s' failed", > > > cmd->argv[0], cmd->dir); > > > break; > > > + case CHILD_ERR_SIGPROCMASK: > > > + error_errno("sigprocmask failed restoring signals"); > > > > missing a break statement here I'll add it in, in the re-roll. > > Good catch, thanks! Actually, I now wonder if that should be die_errno instead. sigprocmask failures (EFAULT/EINVAL) would only be due to programmer error. In one of my minor projects(*), I do something like this: # define CHECK(type, expect, expr) do { \ type checkvar = (expr); \ assert(checkvar == (expect) && "BUG" && __FILE__ && __LINE__); \ } while (0) CHECK(int, 0, sigfillset(&fullset)); CHECK(int, 0, sigemptyset(&emptyset)); CHECK(int, 0, pthread_sigmask(SIG_SETMASK, &fullset, NULL)); Dunno if it's considered good style or not, here. (*) git clone git://bogomips.org/cmogstored