From: Jonathan Nieder <jrnieder@gmail.com>
To: David Turner <dturner@twosigma.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v6] http.postbuffer: allow full range of ssize_t values
Date: Tue, 11 Apr 2017 11:27:40 -0700 [thread overview]
Message-ID: <20170411182740.GO8741@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20170411181357.16580-1-dturner@twosigma.com>
David Turner wrote:
> Unfortunately, in order to push some large repos where a server does
> not support chunked encoding, the http postbuffer must sometimes
> exceed two gigabytes. On a 64-bit system, this is OK: we just malloc
> a larger buffer.
>
> This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the
> buffer size.
>
> Signed-off-by: David Turner <dturner@twosigma.com>
> ---
> cache.h | 1 +
> config.c | 17 +++++++++++++++++
> http.c | 6 ++++--
> http.h | 2 +-
> remote-curl.c | 12 +++++++++---
> 5 files changed, 32 insertions(+), 6 deletions(-)
The only unresolved issue was whether we can count on curl being new
enough for CURLOPT_POSTFIELDSIZE_LARGE to be present. I say
"unresolved" but it is resolved in my mind since git doesn't build and
pass tests with such old versions of curl --- what's unresolved is
formalizing what the oldest curl version is that we want to support.
And that doesn't need to hold this patch hostage.
So for what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thank you.
next prev parent reply other threads:[~2017-04-11 18:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 18:13 [PATCH v6] http.postbuffer: allow full range of ssize_t values David Turner
2017-04-11 18:27 ` Jonathan Nieder [this message]
2017-04-11 19:41 ` Jeff King
2017-04-12 2:39 ` Junio C Hamano
2017-04-12 12:52 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411182740.GO8741@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).