From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0964B1FA14 for ; Tue, 11 Apr 2017 10:47:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753756AbdDKKon (ORCPT ); Tue, 11 Apr 2017 06:44:43 -0400 Received: from cloud.peff.net ([104.130.231.41]:59821 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669AbdDKKns (ORCPT ); Tue, 11 Apr 2017 06:43:48 -0400 Received: (qmail 24986 invoked by uid 109); 11 Apr 2017 10:43:47 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Tue, 11 Apr 2017 10:43:47 +0000 Received: (qmail 922 invoked by uid 111); 11 Apr 2017 10:44:08 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Tue, 11 Apr 2017 06:44:08 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 11 Apr 2017 06:43:45 -0400 Date: Tue, 11 Apr 2017 06:43:45 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Jeffrey Walton , =?utf-8?Q?Micha=C5=82?= Kiedrowicz , J Smith , Victor Leschuk , =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy Subject: Re: [PATCH 12/12] grep: add support for PCRE v2 Message-ID: <20170411104345.apqr37jn53p6xwdf@sigill.intra.peff.net> References: <20170408132506.5415-1-avarab@gmail.com> <20170408132506.5415-13-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170408132506.5415-13-avarab@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Apr 08, 2017 at 01:25:06PM +0000, Ævar Arnfjörð Bjarmason wrote: > --- a/Makefile > +++ b/Makefile > @@ -32,6 +32,14 @@ all:: > # Define LIBPCREDIR=/foo/bar if your libpcre header and library files are in > # /foo/bar/include and /foo/bar/lib directories. > # > +# Define USE_LIBPCRE if you have and want to use libpcre2. Various > +# commands such as like log, grep offer runtime options to use > +# Perl-compatible regular expressions instead of standard or extended > +# POSIX regular expressions. USE_LIBPCRE2 here, right? I'll admit I skimmed a bit on reading this patch, as I don't know the pcre2 API at all. I didn't see anything that looked obviously wrong, though. -Peff