From: Jeff King <peff@peff.net>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, gitster@pobox.com,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v1 2/2] p0005-status: time status on very large repo
Date: Fri, 7 Apr 2017 00:29:56 -0400 [thread overview]
Message-ID: <20170407042955.i63i6prc3rwi4i6s@sigill.intra.peff.net> (raw)
In-Reply-To: <db545f25-b0a7-2359-e6f5-7a89860c4022@jeffhostetler.com>
On Thu, Apr 06, 2017 at 09:26:15AM -0400, Jeff Hostetler wrote:
> > > +export depth
> > > +export width
> > > +export files
> >
> > Why are these exported? test_expect_success code (unlike test_per
> > code) runs in the same shell as outside, so it doesn't seem necessary.
>
> I'm still trying to grok all of the shell wizardry hidden
> in the test_* functions, so some may be novice mistakes here.
> However, I couldn't get some of the steps to run in an earlier
> draft of it without them. But I copied this from p0004-read-tree
> that I posted in an earlier patch and this version is much simpler
> so they may not be necessary here. I'll double check.
It's a subtle but annoying difference between the regular tests and the
perf tests. test_perf() runs in a subshell because of the way the timing
is implemented. There are a few pointers in t/perf/README regarding
this.
-Peff
prev parent reply other threads:[~2017-04-07 4:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 19:55 [PATCH v1 0/2] string-list: use ALLOC_GROW macro when reallocing git
2017-04-05 19:55 ` [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list git
2017-04-05 20:00 ` Stefan Beller
2017-04-05 20:09 ` Jeff King
2017-04-05 21:12 ` Jeff Hostetler
2017-04-05 21:26 ` Jonathan Nieder
2017-04-05 19:56 ` [PATCH v1 2/2] p0005-status: time status on very large repo git
2017-04-05 21:33 ` Jonathan Nieder
2017-04-06 13:26 ` Jeff Hostetler
2017-04-07 4:29 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407042955.i63i6prc3rwi4i6s@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).