From: git@jeffhostetler.com
To: git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: [PATCH v4 3/4] test-strcmp-offset: created test for strcmp_offset
Date: Tue, 4 Apr 2017 21:08:46 +0000 [thread overview]
Message-ID: <20170404210847.50860-4-git@jeffhostetler.com> (raw)
In-Reply-To: <20170404210847.50860-1-git@jeffhostetler.com>
From: Jeff Hostetler <jeffhost@microsoft.com>
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
Makefile | 1 +
t/helper/.gitignore | 1 +
t/helper/test-strcmp-offset.c | 64 +++++++++++++++++++++++++++++++++++++++++++
t/t0065-strcmp-offset.sh | 11 ++++++++
4 files changed, 77 insertions(+)
create mode 100644 t/helper/test-strcmp-offset.c
create mode 100755 t/t0065-strcmp-offset.sh
diff --git a/Makefile b/Makefile
index 9ec6065..4c4c246 100644
--- a/Makefile
+++ b/Makefile
@@ -631,6 +631,7 @@ TEST_PROGRAMS_NEED_X += test-scrap-cache-tree
TEST_PROGRAMS_NEED_X += test-sha1
TEST_PROGRAMS_NEED_X += test-sha1-array
TEST_PROGRAMS_NEED_X += test-sigchain
+TEST_PROGRAMS_NEED_X += test-strcmp-offset
TEST_PROGRAMS_NEED_X += test-string-list
TEST_PROGRAMS_NEED_X += test-submodule-config
TEST_PROGRAMS_NEED_X += test-subprocess
diff --git a/t/helper/.gitignore b/t/helper/.gitignore
index d6e8b36..0a89531 100644
--- a/t/helper/.gitignore
+++ b/t/helper/.gitignore
@@ -25,6 +25,7 @@
/test-sha1
/test-sha1-array
/test-sigchain
+/test-strcmp-offset
/test-string-list
/test-submodule-config
/test-subprocess
diff --git a/t/helper/test-strcmp-offset.c b/t/helper/test-strcmp-offset.c
new file mode 100644
index 0000000..fe01318
--- /dev/null
+++ b/t/helper/test-strcmp-offset.c
@@ -0,0 +1,64 @@
+#include "cache.h"
+
+struct test_data {
+ const char *s1;
+ const char *s2;
+ int first_change;
+};
+
+static struct test_data data[] = {
+ { "abc", "abc", 0 },
+ { "abc", "def", 0 },
+
+ { "abc", "abz", 2 },
+
+ { "abc", "abcdef", 3 },
+
+ { "abc\xF0zzz", "abc\xFFzzz", 3 },
+
+ { NULL, NULL, 0 }
+};
+
+int try_pair(const char *sa, const char *sb, int first_change)
+{
+ int failed = 0;
+ int offset, r_exp, r_tst;
+ int r_exp_sign, r_tst_sign;
+
+ /*
+ * Because differnt CRTs behave differently, only rely on signs
+ * of the result values.
+ */
+ r_exp = strcmp(sa, sb);
+ r_exp_sign = ((r_exp < 0) ? -1 : ((r_exp == 0) ? 0 : 1));
+
+ r_tst = strcmp_offset(sa, sb, &offset);
+ r_tst_sign = ((r_tst < 0) ? -1 : ((r_tst == 0) ? 0 : 1));
+
+ if (r_tst_sign != r_exp_sign) {
+ error("FAIL: '%s' vs '%s', result expect %d, observed %d\n",
+ sa, sb, r_exp_sign, r_tst_sign);
+ failed = 1;
+ }
+
+ if (offset != first_change) {
+ error("FAIL: '%s' vs '%s', offset expect %d, observed %d\n",
+ sa, sb, first_change, offset);
+ failed = 1;
+ }
+
+ return failed;
+}
+
+int cmd_main(int argc, const char **argv)
+{
+ int failed = 0;
+ int k;
+
+ for (k=0; data[k].s1; k++) {
+ failed += try_pair(data[k].s1, data[k].s2, data[k].first_change);
+ failed += try_pair(data[k].s2, data[k].s1, data[k].first_change);
+ }
+
+ return failed;
+}
diff --git a/t/t0065-strcmp-offset.sh b/t/t0065-strcmp-offset.sh
new file mode 100755
index 0000000..0176c8c
--- /dev/null
+++ b/t/t0065-strcmp-offset.sh
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+test_description='Test strcmp_offset functionality'
+
+. ./test-lib.sh
+
+test_expect_success run_helper '
+ test-strcmp-offset
+'
+
+test_done
--
2.9.3
next prev parent reply other threads:[~2017-04-04 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 21:08 [PATCH v4 0/4] read-cache: speed up add_index_entry git
2017-04-04 21:08 ` [PATCH v4 1/4] p0004-read-tree: perf test to time read-tree git
2017-04-04 21:08 ` [PATCH v4 2/4] read-cache: add strcmp_offset function git
2017-04-04 21:08 ` git [this message]
2017-04-04 21:08 ` [PATCH v4 4/4] read-cache: speed up add_index_entry during checkout git
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404210847.50860-4-git@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).