git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Pickfire <pickfire@riseup.net>
To: jacob.keller@gmail.com
Cc: git@vger.kernel.org
Subject: Re: Re: Re: Microproject | Add more builtin patterns for userdiff
Date: Wed, 29 Mar 2017 09:55:32 +0800	[thread overview]
Message-ID: <20170329015532.R50BRdAbP%pickfire@riseup.net> (raw)
In-Reply-To: <CA+P7+xrYKE1JOhmVQLVB1RKPnkGNsPPaW+-t8=PqcVpRDcZ=Nw@mail.gmail.com>

Jacob Keller <jacob.keller@gmail.com> wrote:

> On Tue, Mar 28, 2017 at 10:53 AM, Pickfire <pickfire@riseup.net> wrote:
> >
> > Yes, I can't reproduce it outside the test suite. I have added the builtin
> > and yet the test fails. test_decode_color gets same output as expect but
> > still it fails, should I send in the patch?
> 
> You also need to ensure you have the exact same color settings as used
> by the test scripts.
> 
> Thanks,
> Jake

Yes, I used the same color, looks like the block that are failing is:

    test_must_fail git diff --no-index "$@" pre post >output

  reply	other threads:[~2017-03-29  1:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 10:46 Microproject | Add more builtin patterns for userdiff Pickfire
2017-03-28 12:31 ` Jacob Keller
2017-03-28 17:53   ` Pickfire
2017-03-28 18:10     ` Jacob Keller
2017-03-29  1:55       ` Pickfire [this message]
2017-03-28 18:11 ` Stefan Beller
2017-03-29  1:54   ` Pickfire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170329015532.R50BRdAbP%pickfire@riseup.net \
    --to=pickfire@riseup.net \
    --cc=git@vger.kernel.org \
    --cc=jacob.keller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).