From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Conrad Irwin" <conrad.irwin@gmail.com>,
"Sitaram Chamarty" <sitaramc@gmail.com>,
"Michael J Gruber" <git@drmicha.warpmail.net>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"Brian M . Carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH v2 3/3] rev-parse: match ^{<type>} case-insensitively
Date: Sun, 26 Mar 2017 22:58:18 -0400 [thread overview]
Message-ID: <20170327025818.pbm4nwqrfolyto7g@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq60iv4ku2.fsf@gitster.mtv.corp.google.com>
On Sun, Mar 26, 2017 at 05:36:21PM -0700, Junio C Hamano wrote:
> It's not "potential confusion". This closes the door for us to
> introduce "TREE" as a separate object type in the future.
>
> If we agree to make a declaration that all typenames are officially
> spelled in lowercase [*1*] and at the UI level we accept typenames
> spelled in any case, then we can adopt this change (and then we need
> to update "cat-file -t" etc. to match it).
>
> I do not at all mind to see if the list concensus is to make such a
> declaration and permanently close the door for typenames that are
> not lowercase, and after seeing such a concensus I'd gladly
> appreciate this patch, but I do not want to see a change like this
> that decides the future of the system, pretending as an innocuous
> change, sneaked in without making sure that everybody is aware of
> its implications.
FWIW, I cannot see us ever adding TREE (or Tree) as a separate type.
It's too confusing for no gain. We'd call it "tree2" or something more
obvious.
So I don't mind closing that door, but I'm not sure if a partial
conversion (where some commands are case-insensitive but others aren't
yet) might not leave us in a more confusing place.
I dunno. I guess I have never wanted to type "^{Tree}" in the first
place, so I do not personally see the _benefit_. Which makes it easy to
see even small negatives as a net loss.
-Peff
next prev parent reply other threads:[~2017-03-27 2:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 22:34 [PATCH] rev-parse: match @{u}, @{push} and ^{<type>} case-insensitively Ævar Arnfjörð Bjarmason
2017-03-19 9:19 ` Duy Nguyen
2017-03-19 10:04 ` Ævar Arnfjörð Bjarmason
2017-03-19 12:55 ` Junio C Hamano
2017-03-19 14:26 ` Ævar Arnfjörð Bjarmason
2017-03-19 22:53 ` Junio C Hamano
2017-03-26 12:16 ` [PATCH v2 0/3] rev-parse case insensitivity & @{p} synonym Ævar Arnfjörð Bjarmason
2017-03-26 12:16 ` [PATCH v2 1/3] rev-parse: match @{upstream}, @{u} and @{push} case-insensitively Ævar Arnfjörð Bjarmason
2017-03-27 0:27 ` Junio C Hamano
2017-03-27 11:16 ` [PATCH v3] " Ævar Arnfjörð Bjarmason
2017-03-27 17:45 ` Junio C Hamano
2017-03-27 18:05 ` Ævar Arnfjörð Bjarmason
2017-03-26 12:16 ` [PATCH v2 2/3] rev-parse: add @{p} as a synonym for @{push} Ævar Arnfjörð Bjarmason
2017-03-27 2:53 ` Jeff King
2017-03-27 7:52 ` Ævar Arnfjörð Bjarmason
2017-03-26 12:16 ` [PATCH v2 3/3] rev-parse: match ^{<type>} case-insensitively Ævar Arnfjörð Bjarmason
2017-03-27 0:36 ` Junio C Hamano
2017-03-27 2:58 ` Jeff King [this message]
2017-03-27 5:39 ` Junio C Hamano
2017-03-27 7:11 ` Jeff King
2017-03-27 7:33 ` Ævar Arnfjörð Bjarmason
2017-03-21 19:19 ` [PATCH] rev-parse: match @{u}, @{push} and " Ævar Arnfjörð Bjarmason
2017-03-21 19:26 ` Junio C Hamano
2017-03-21 19:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327025818.pbm4nwqrfolyto7g@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=conrad.irwin@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=sitaramc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).