From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> To: git@vger.kernel.org Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>, Michael Haggerty <mhagger@alum.mit.edu>, Johannes Schindelin <Johannes.Schindelin@gmx.de>, Ramsay Jones <ramsay@ramsayjones.plus.com>, Stefan Beller <sbeller@google.com>, novalis@novalis.org, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Subject: [PATCH v7 07/28] files-backend: convert git_path() to strbuf_git_path() Date: Sun, 26 Mar 2017 09:42:20 +0700 Message-ID: <20170326024241.31984-8-pclouds@gmail.com> (raw) In-Reply-To: <20170326024241.31984-1-pclouds@gmail.com> git_path() and friends are going to be killed in files-backend.c in near future. And because there's a risk with overwriting buffer in git_path(), let's convert them all to strbuf_git_path(). We'll have easier time killing/converting strbuf_git_path() then because we won't have to worry about memory management again. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- refs/files-backend.c | 130 ++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 97 insertions(+), 33 deletions(-) diff --git a/refs/files-backend.c b/refs/files-backend.c index 6d0fcc88f9..5f9b0ab9bc 100644 --- a/refs/files-backend.c +++ b/refs/files-backend.c @@ -2316,6 +2316,7 @@ enum { static void try_remove_empty_parents(const char *refname, unsigned int flags) { struct strbuf buf = STRBUF_INIT; + struct strbuf sb = STRBUF_INIT; char *p, *q; int i; @@ -2337,14 +2338,19 @@ static void try_remove_empty_parents(const char *refname, unsigned int flags) if (q == p) break; strbuf_setlen(&buf, q - buf.buf); - if ((flags & REMOVE_EMPTY_PARENTS_REF) && - rmdir(git_path("%s", buf.buf))) + + strbuf_reset(&sb); + strbuf_git_path(&sb, "%s", buf.buf); + if ((flags & REMOVE_EMPTY_PARENTS_REF) && rmdir(sb.buf)) flags &= ~REMOVE_EMPTY_PARENTS_REF; - if ((flags & REMOVE_EMPTY_PARENTS_REFLOG) && - rmdir(git_path("logs/%s", buf.buf))) + + strbuf_reset(&sb); + strbuf_git_path(&sb, "logs/%s", buf.buf); + if ((flags & REMOVE_EMPTY_PARENTS_REFLOG) && rmdir(sb.buf)) flags &= ~REMOVE_EMPTY_PARENTS_REFLOG; } strbuf_release(&buf); + strbuf_release(&sb); } /* make sure nobody touched the ref, and unlink */ @@ -2506,11 +2512,16 @@ static int files_delete_refs(struct ref_store *ref_store, */ #define TMP_RENAMED_LOG "logs/refs/.tmp-renamed-log" -static int rename_tmp_log_callback(const char *path, void *cb) +struct rename_cb { + const char *tmp_renamed_log; + int true_errno; +}; + +static int rename_tmp_log_callback(const char *path, void *cb_data) { - int *true_errno = cb; + struct rename_cb *cb = cb_data; - if (rename(git_path(TMP_RENAMED_LOG), path)) { + if (rename(cb->tmp_renamed_log, path)) { /* * rename(a, b) when b is an existing directory ought * to result in ISDIR, but Solaris 5.8 gives ENOTDIR. @@ -2518,7 +2529,7 @@ static int rename_tmp_log_callback(const char *path, void *cb) * but report EISDIR to raceproof_create_file() so * that it knows to retry. */ - *true_errno = errno; + cb->true_errno = errno; if (errno == ENOTDIR) errno = EISDIR; return -1; @@ -2529,20 +2540,26 @@ static int rename_tmp_log_callback(const char *path, void *cb) static int rename_tmp_log(const char *newrefname) { - char *path = git_pathdup("logs/%s", newrefname); - int ret, true_errno; + struct strbuf path = STRBUF_INIT; + struct strbuf tmp = STRBUF_INIT; + struct rename_cb cb; + int ret; - ret = raceproof_create_file(path, rename_tmp_log_callback, &true_errno); + strbuf_git_path(&path, "logs/%s", newrefname); + strbuf_git_path(&tmp, TMP_RENAMED_LOG); + cb.tmp_renamed_log = tmp.buf; + ret = raceproof_create_file(path.buf, rename_tmp_log_callback, &cb); if (ret) { if (errno == EISDIR) - error("directory not empty: %s", path); + error("directory not empty: %s", path.buf); else error("unable to move logfile %s to %s: %s", - git_path(TMP_RENAMED_LOG), path, - strerror(true_errno)); + tmp.buf, path.buf, + strerror(cb.true_errno)); } - free(path); + strbuf_release(&path); + strbuf_release(&tmp); return ret; } @@ -2583,10 +2600,17 @@ static int files_rename_ref(struct ref_store *ref_store, int flag = 0, logmoved = 0; struct ref_lock *lock; struct stat loginfo; - int log = !lstat(git_path("logs/%s", oldrefname), &loginfo); + struct strbuf sb_oldref = STRBUF_INIT; + struct strbuf sb_newref = STRBUF_INIT; + struct strbuf tmp_renamed_log = STRBUF_INIT; + int log, ret; struct strbuf err = STRBUF_INIT; - int ret; + strbuf_git_path(&sb_oldref, "logs/%s", oldrefname); + strbuf_git_path(&sb_newref, "logs/%s", newrefname); + strbuf_git_path(&tmp_renamed_log, TMP_RENAMED_LOG); + + log = !lstat(sb_oldref.buf, &loginfo); if (log && S_ISLNK(loginfo.st_mode)) { ret = error("reflog for %s is a symlink", oldrefname); goto out; @@ -2608,7 +2632,7 @@ static int files_rename_ref(struct ref_store *ref_store, goto out; } - if (log && rename(git_path("logs/%s", oldrefname), git_path(TMP_RENAMED_LOG))) { + if (log && rename(sb_oldref.buf, tmp_renamed_log.buf)) { ret = error("unable to move logfile logs/%s to "TMP_RENAMED_LOG": %s", oldrefname, strerror(errno)); goto out; @@ -2690,16 +2714,19 @@ static int files_rename_ref(struct ref_store *ref_store, log_all_ref_updates = flag; rollbacklog: - if (logmoved && rename(git_path("logs/%s", newrefname), git_path("logs/%s", oldrefname))) + if (logmoved && rename(sb_newref.buf, sb_oldref.buf)) error("unable to restore logfile %s from %s: %s", oldrefname, newrefname, strerror(errno)); if (!logmoved && log && - rename(git_path(TMP_RENAMED_LOG), git_path("logs/%s", oldrefname))) + rename(tmp_renamed_log.buf, sb_oldref.buf)) error("unable to restore logfile %s from "TMP_RENAMED_LOG": %s", oldrefname, strerror(errno)); - ret = 1; out: + strbuf_release(&sb_newref); + strbuf_release(&sb_oldref); + strbuf_release(&tmp_renamed_log); + return ret; } @@ -2872,18 +2899,24 @@ static int files_log_ref_write(const char *refname, const unsigned char *old_sha result = log_ref_write_fd(logfd, old_sha1, new_sha1, git_committer_info(0), msg); if (result) { + struct strbuf sb = STRBUF_INIT; int save_errno = errno; + strbuf_git_path(&sb, "logs/%s", refname); strbuf_addf(err, "unable to append to '%s': %s", - git_path("logs/%s", refname), strerror(save_errno)); + sb.buf, strerror(save_errno)); + strbuf_release(&sb); close(logfd); return -1; } if (close(logfd)) { + struct strbuf sb = STRBUF_INIT; int save_errno = errno; + strbuf_git_path(&sb, "logs/%s", refname); strbuf_addf(err, "unable to append to '%s': %s", - git_path("logs/%s", refname), strerror(save_errno)); + sb.buf, strerror(save_errno)); + strbuf_release(&sb); return -1; } return 0; @@ -3103,22 +3136,32 @@ int set_worktree_head_symref(const char *gitdir, const char *target, const char static int files_reflog_exists(struct ref_store *ref_store, const char *refname) { + struct strbuf sb = STRBUF_INIT; struct stat st; + int ret; /* Check validity (but we don't need the result): */ files_downcast(ref_store, 0, "reflog_exists"); - return !lstat(git_path("logs/%s", refname), &st) && - S_ISREG(st.st_mode); + strbuf_git_path(&sb, "logs/%s", refname); + ret = !lstat(sb.buf, &st) && S_ISREG(st.st_mode); + strbuf_release(&sb); + return ret; } static int files_delete_reflog(struct ref_store *ref_store, const char *refname) { + struct strbuf sb = STRBUF_INIT; + int ret; + /* Check validity (but we don't need the result): */ files_downcast(ref_store, 0, "delete_reflog"); - return remove_path(git_path("logs/%s", refname)); + strbuf_git_path(&sb, "logs/%s", refname); + ret = remove_path(sb.buf); + strbuf_release(&sb); + return ret; } static int show_one_reflog_ent(struct strbuf *sb, each_reflog_ent_fn fn, void *cb_data) @@ -3174,7 +3217,9 @@ static int files_for_each_reflog_ent_reverse(struct ref_store *ref_store, /* Check validity (but we don't need the result): */ files_downcast(ref_store, 0, "for_each_reflog_ent_reverse"); - logfp = fopen(git_path("logs/%s", refname), "r"); + strbuf_git_path(&sb, "logs/%s", refname); + logfp = fopen(sb.buf, "r"); + strbuf_release(&sb); if (!logfp) return -1; @@ -3280,7 +3325,9 @@ static int files_for_each_reflog_ent(struct ref_store *ref_store, /* Check validity (but we don't need the result): */ files_downcast(ref_store, 0, "for_each_reflog_ent"); - logfp = fopen(git_path("logs/%s", refname), "r"); + strbuf_git_path(&sb, "logs/%s", refname); + logfp = fopen(sb.buf, "r"); + strbuf_release(&sb); if (!logfp) return -1; @@ -3362,12 +3409,15 @@ static struct ref_iterator *files_reflog_iterator_begin(struct ref_store *ref_st { struct files_reflog_iterator *iter = xcalloc(1, sizeof(*iter)); struct ref_iterator *ref_iterator = &iter->base; + struct strbuf sb = STRBUF_INIT; /* Check validity (but we don't need the result): */ files_downcast(ref_store, 0, "reflog_iterator_begin"); base_ref_iterator_init(ref_iterator, &files_reflog_iterator_vtable); - iter->dir_iterator = dir_iterator_begin(git_path("logs")); + strbuf_git_path(&sb, "logs"); + iter->dir_iterator = dir_iterator_begin(sb.buf); + strbuf_release(&sb); return ref_iterator; } @@ -3705,6 +3755,7 @@ static int files_transaction_commit(struct ref_store *ref_store, char *head_ref = NULL; int head_type; struct object_id head_oid; + struct strbuf sb = STRBUF_INIT; assert(err); @@ -3826,7 +3877,9 @@ static int files_transaction_commit(struct ref_store *ref_store, if (!(update->type & REF_ISPACKED) || update->type & REF_ISSYMREF) { /* It is a loose reference. */ - if (unlink_or_msg(git_path("%s", lock->ref_name), err)) { + strbuf_reset(&sb); + strbuf_git_path(&sb, "%s", lock->ref_name); + if (unlink_or_msg(sb.buf, err)) { ret = TRANSACTION_GENERIC_ERROR; goto cleanup; } @@ -3846,7 +3899,9 @@ static int files_transaction_commit(struct ref_store *ref_store, /* Delete the reflogs of any references that were deleted: */ for_each_string_list_item(ref_to_delete, &refs_to_delete) { - if (!unlink_or_warn(git_path("logs/%s", ref_to_delete->string))) + strbuf_reset(&sb); + strbuf_git_path(&sb, "logs/%s", ref_to_delete->string); + if (!unlink_or_warn(sb.buf)) try_remove_empty_parents(ref_to_delete->string, REMOVE_EMPTY_PARENTS_REFLOG); } @@ -3854,6 +3909,7 @@ static int files_transaction_commit(struct ref_store *ref_store, clear_loose_ref_cache(refs); cleanup: + strbuf_release(&sb); transaction->state = REF_TRANSACTION_CLOSED; for (i = 0; i < transaction->nr; i++) { @@ -4120,14 +4176,22 @@ static int files_reflog_expire(struct ref_store *ref_store, static int files_init_db(struct ref_store *ref_store, struct strbuf *err) { + struct strbuf sb = STRBUF_INIT; + /* Check validity (but we don't need the result): */ files_downcast(ref_store, 0, "init_db"); /* * Create .git/refs/{heads,tags} */ - safe_create_dir(git_path("refs/heads"), 1); - safe_create_dir(git_path("refs/tags"), 1); + strbuf_git_path(&sb, "refs/heads"); + safe_create_dir(sb.buf, 1); + + strbuf_reset(&sb); + strbuf_git_path(&sb, "refs/tags"); + safe_create_dir(sb.buf, 1); + + strbuf_release(&sb); return 0; } -- 2.11.0.157.gd943d85
next prev parent reply index Thread overview: 250+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-13 15:20 [PATCH/RFC 00/11] Remove submodule from files-backend.c Nguyễn Thái Ngọc Duy 2017-02-13 15:20 ` [PATCH 01/11] refs-internal.c: make files_log_ref_write() static Nguyễn Thái Ngọc Duy 2017-02-13 20:14 ` Ramsay Jones 2017-02-14 9:23 ` Duy Nguyen 2017-02-13 15:20 ` [PATCH 02/11] files-backend: convert git_path() to strbuf_git_path() Nguyễn Thái Ngọc Duy 2017-02-13 20:38 ` Ramsay Jones 2017-02-13 15:20 ` [PATCH 03/11] files-backend: add files_path() Nguyễn Thái Ngọc Duy 2017-02-13 20:43 ` Ramsay Jones 2017-02-13 15:20 ` [PATCH 04/11] files-backend: replace *git_path*() with files_path() Nguyễn Thái Ngọc Duy 2017-02-13 20:58 ` Ramsay Jones 2017-02-14 9:43 ` Duy Nguyen 2017-02-13 15:20 ` [PATCH 05/11] refs.c: share is_per_worktree_ref() to files-backend.c Nguyễn Thái Ngọc Duy 2017-02-13 15:20 ` [PATCH 06/11] refs-internal.h: correct is_per_worktree_ref() Nguyễn Thái Ngọc Duy 2017-02-13 22:37 ` Stefan Beller 2017-02-14 9:40 ` Duy Nguyen 2017-02-14 17:40 ` Stefan Beller 2017-02-13 15:20 ` [PATCH 07/11] files-backend: remove the use of git_path() Nguyễn Thái Ngọc Duy 2017-02-13 23:09 ` Stefan Beller 2017-02-14 9:38 ` Duy Nguyen 2017-02-13 15:20 ` [PATCH 08/11] refs.c: factor submodule code out of get_ref_store() Nguyễn Thái Ngọc Duy 2017-02-13 23:13 ` Stefan Beller 2017-02-13 15:20 ` [PATCH 09/11] refs: move submodule code out of files-backend.c Nguyễn Thái Ngọc Duy 2017-02-13 23:35 ` Stefan Beller 2017-02-14 9:32 ` Duy Nguyen 2017-02-13 15:20 ` [PATCH 10/11] files-backend: remove submodule_allowed from files_downcast() Nguyễn Thái Ngọc Duy 2017-02-13 23:44 ` Stefan Beller 2017-02-13 15:20 ` [PATCH 11/11] refs: split and make get_*_ref_store() public API Nguyễn Thái Ngọc Duy 2017-02-13 23:55 ` Stefan Beller 2017-02-14 10:04 ` Duy Nguyen 2017-02-14 18:24 ` Junio C Hamano 2017-02-15 0:44 ` Duy Nguyen 2017-02-15 1:16 ` Junio C Hamano 2017-02-14 18:43 ` Stefan Beller 2017-02-16 11:48 ` [PATCH v2 00/16] Remove submodule from files-backend.c Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 01/16] refs-internal.c: make files_log_ref_write() static Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 02/16] files-backend: convert git_path() to strbuf_git_path() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 03/16] files-backend: add files_path() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 04/16] files-backend: replace *git_path*() with files_path() Nguyễn Thái Ngọc Duy 2017-02-20 11:23 ` Michael Haggerty 2017-02-20 12:25 ` Duy Nguyen 2017-02-16 11:48 ` [PATCH v2 05/16] refs.c: share is_per_worktree_ref() to files-backend.c Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 06/16] refs-internal.h: correct is_per_worktree_ref() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 07/16] files-backend: remove the use of git_path() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 08/16] refs.c: introduce get_main_ref_store() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 09/16] refs: rename lookup_ref_store() to lookup_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 10/16] refs.c: flatten get_ref_store() a bit Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 11/16] refs.c: kill register_ref_store(), add register_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 12/16] refs.c: make get_main_ref_store() public and use it Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 13/16] path.c: move some code out of strbuf_git_path_submodule() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 14/16] refs: move submodule code out of files-backend.c Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 15/16] files-backend: remove submodule_allowed from files_downcast() Nguyễn Thái Ngọc Duy 2017-02-16 11:48 ` [PATCH v2 16/16] refs: rename get_ref_store() to get_submodule_ref_store() and make it public Nguyễn Thái Ngọc Duy 2017-02-16 22:55 ` [PATCH v2 00/16] Remove submodule from files-backend.c Stefan Beller 2017-02-17 14:04 ` [PATCH v3 " Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 01/16] refs-internal.c: make files_log_ref_write() static Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 02/16] files-backend: convert git_path() to strbuf_git_path() Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 03/16] files-backend: add files_path() Nguyễn Thái Ngọc Duy 2017-02-17 18:57 ` Junio C Hamano 2017-02-17 14:04 ` [PATCH v3 04/16] files-backend: replace *git_path*() with files_path() Nguyễn Thái Ngọc Duy 2017-02-17 19:27 ` Junio C Hamano 2017-02-17 14:04 ` [PATCH v3 05/16] refs.c: share is_per_worktree_ref() to files-backend.c Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 06/16] refs-internal.h: correct is_per_worktree_ref() Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 07/16] files-backend: remove the use of git_path() Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 08/16] refs.c: introduce get_main_ref_store() Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 09/16] refs: rename lookup_ref_store() to lookup_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 10/16] refs.c: flatten get_ref_store() a bit Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 11/16] refs.c: kill register_ref_store(), add register_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-02-17 19:29 ` Junio C Hamano 2017-02-17 14:04 ` [PATCH v3 12/16] refs.c: make get_main_ref_store() public and use it Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 13/16] path.c: move some code out of strbuf_git_path_submodule() Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 14/16] refs: move submodule code out of files-backend.c Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 15/16] files-backend: remove submodule_allowed from files_downcast() Nguyễn Thái Ngọc Duy 2017-02-17 14:04 ` [PATCH v3 16/16] refs: rename get_ref_store() to get_submodule_ref_store() and make it public Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 00/15] Remove submodule from files-backend.c Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 01/15] refs-internal.c: make files_log_ref_write() static Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 02/15] files-backend: convert git_path() to strbuf_git_path() Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 03/15] files-backend: add files_path() Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 04/15] files-backend: replace *git_path*() with files_path() Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 05/15] refs.c: share is_per_worktree_ref() to files-backend.c Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 06/15] files-backend: remove the use of git_path() Nguyễn Thái Ngọc Duy 2017-02-20 11:34 ` Michael Haggerty 2017-02-20 12:31 ` Duy Nguyen 2017-02-18 13:32 ` [PATCH v4 07/15] refs.c: introduce get_main_ref_store() Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 08/15] refs: rename lookup_ref_store() to lookup_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 09/15] refs.c: flatten get_ref_store() a bit Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 10/15] refs.c: kill register_ref_store(), add register_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-02-18 13:32 ` [PATCH v4 11/15] refs.c: make get_main_ref_store() public and use it Nguyễn Thái Ngọc Duy 2017-02-20 12:37 ` Michael Haggerty 2017-02-18 13:33 ` [PATCH v4 12/15] path.c: move some code out of strbuf_git_path_submodule() Nguyễn Thái Ngọc Duy 2017-02-18 13:33 ` [PATCH v4 13/15] refs: move submodule code out of files-backend.c Nguyễn Thái Ngọc Duy 2017-02-18 13:33 ` [PATCH v4 14/15] files-backend: remove submodule_allowed from files_downcast() Nguyễn Thái Ngọc Duy 2017-02-20 12:11 ` Michael Haggerty 2017-02-20 12:21 ` Duy Nguyen 2017-02-20 12:30 ` Michael Haggerty 2017-02-20 12:33 ` Duy Nguyen 2017-02-20 12:38 ` Michael Haggerty 2017-02-21 13:25 ` Duy Nguyen 2017-02-18 13:33 ` [PATCH v4 15/15] refs: rename get_ref_store() to get_submodule_ref_store() and make it public Nguyễn Thái Ngọc Duy 2017-02-20 12:42 ` [PATCH v4 00/15] Remove submodule from files-backend.c Michael Haggerty 2017-02-20 12:47 ` Duy Nguyen 2017-02-22 14:04 ` [PATCH v5 00/24] " Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 01/24] refs.h: add forward declaration for structs used in this file Nguyễn Thái Ngọc Duy 2017-02-22 18:18 ` Stefan Beller 2017-02-23 9:26 ` Duy Nguyen 2017-02-22 14:04 ` [PATCH v5 02/24] files-backend: make files_log_ref_write() static Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 03/24] files-backend: add and use files_packed_refs_path() Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 04/24] files-backend: convert git_path() to strbuf_git_path() Nguyễn Thái Ngọc Duy 2017-02-28 17:06 ` Michael Haggerty 2017-03-02 12:52 ` Duy Nguyen 2017-02-22 14:04 ` [PATCH v5 05/24] files-backend: move "logs/" out of TMP_RENAMED_LOG Nguyễn Thái Ngọc Duy 2017-02-28 17:19 ` Michael Haggerty 2017-03-02 13:07 ` Duy Nguyen 2017-02-22 14:04 ` [PATCH v5 06/24] files-backend: add and use files_reflog_path() Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 07/24] files-backend: add and use files_refname_path() Nguyễn Thái Ngọc Duy 2017-02-28 17:41 ` Michael Haggerty 2017-03-02 12:46 ` Duy Nguyen 2017-03-09 12:24 ` Michael Haggerty 2017-02-22 14:04 ` [PATCH v5 08/24] files-backend: remove the use of git_path() Nguyễn Thái Ngọc Duy 2017-02-28 17:50 ` Michael Haggerty 2017-03-02 12:43 ` Duy Nguyen 2017-02-22 14:04 ` [PATCH v5 09/24] refs.c: introduce get_main_ref_store() Nguyễn Thái Ngọc Duy 2017-02-28 17:51 ` Michael Haggerty 2017-03-01 12:06 ` Duy Nguyen 2017-02-22 14:04 ` [PATCH v5 10/24] refs: rename lookup_ref_store() to lookup_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 11/24] refs.c: flatten get_ref_store() a bit Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 12/24] refs.c: kill register_ref_store(), add register_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-02-28 18:03 ` Michael Haggerty 2017-03-01 12:00 ` Duy Nguyen 2017-03-01 12:31 ` Michael Haggerty 2017-02-22 14:04 ` [PATCH v5 13/24] refs.c: make get_main_ref_store() public and use it Nguyễn Thái Ngọc Duy 2017-02-28 18:06 ` Michael Haggerty 2017-02-22 14:04 ` [PATCH v5 14/24] path.c: move some code out of strbuf_git_path_submodule() Nguyễn Thái Ngọc Duy 2017-02-28 18:14 ` Michael Haggerty 2017-02-22 14:04 ` [PATCH v5 15/24] refs: move submodule code out of files-backend.c Nguyễn Thái Ngọc Duy 2017-03-03 14:32 ` Michael Haggerty 2017-02-22 14:04 ` [PATCH v5 16/24] files-backend: replace submodule_allowed check in files_downcast() Nguyễn Thái Ngọc Duy 2017-03-03 14:49 ` Michael Haggerty 2017-02-22 14:04 ` [PATCH v5 17/24] refs: rename get_ref_store() to get_submodule_ref_store() and make it public Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 18/24] refs: add new ref-store api Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 19/24] refs: new transaction related " Nguyễn Thái Ngọc Duy 2017-03-03 15:48 ` Michael Haggerty 2017-02-22 14:04 ` [PATCH v5 20/24] files-backend: avoid ref api targetting main ref store Nguyễn Thái Ngọc Duy 2017-03-03 16:03 ` Michael Haggerty 2017-02-22 14:04 ` [PATCH v5 21/24] refs: delete pack_refs() in favor of refs_pack_refs() Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 22/24] t/helper: add test-ref-store to test ref-store functions Nguyễn Thái Ngọc Duy 2017-02-22 14:04 ` [PATCH v5 23/24] t1405: some basic tests on main ref store Nguyễn Thái Ngọc Duy 2017-03-03 16:43 ` Michael Haggerty 2017-03-06 12:30 ` Duy Nguyen 2017-02-22 14:04 ` [PATCH v5 24/24] t1406: new tests for submodule " Nguyễn Thái Ngọc Duy 2017-02-28 17:34 ` Michael Haggerty 2017-03-01 12:34 ` Duy Nguyen 2017-03-01 15:11 ` Michael Haggerty 2017-03-02 6:13 ` Duy Nguyen 2017-03-02 8:16 ` Michael Haggerty 2017-03-02 12:38 ` Duy Nguyen 2017-03-03 16:51 ` Michael Haggerty 2017-02-22 17:18 ` [PATCH v5 00/24] Remove submodule from files-backend.c Junio C Hamano 2017-02-22 21:04 ` Junio C Hamano 2017-02-28 18:20 ` Michael Haggerty 2017-02-28 20:52 ` Junio C Hamano 2017-03-03 16:54 ` Michael Haggerty 2017-03-18 2:03 ` [PATCH v6 00/27] " Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 01/27] refs.h: add forward declaration for structs used in this file Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 02/27] files-backend: make files_log_ref_write() static Nguyễn Thái Ngọc Duy 2017-03-19 19:10 ` Michael Haggerty 2017-03-19 20:35 ` Ramsay Jones 2017-03-18 2:03 ` [PATCH v6 03/27] files-backend: delete dead code in files_init_db() Nguyễn Thái Ngọc Duy 2017-03-19 19:11 ` Michael Haggerty 2017-03-18 2:03 ` [PATCH v6 04/27] files-backend: add and use files_packed_refs_path() Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 05/27] files-backend: make sure files_rename_ref() always reach the end Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 06/27] files-backend: convert git_path() to strbuf_git_path() Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 07/27] files-backend: move "logs/" out of TMP_RENAMED_LOG Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 08/27] files-backend: add and use files_reflog_path() Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 09/27] files-backend: add and use files_refname_path() Nguyễn Thái Ngọc Duy 2017-03-19 20:32 ` Michael Haggerty 2017-03-18 2:03 ` [PATCH v6 10/27] files-backend: remove the use of git_path() Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 11/27] refs.c: introduce get_main_ref_store() Nguyễn Thái Ngọc Duy 2017-03-19 20:38 ` Michael Haggerty 2017-03-18 2:03 ` [PATCH v6 12/27] refs: rename lookup_ref_store() to lookup_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 13/27] refs.c: flatten get_ref_store() a bit Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 14/27] refs.c: kill register_ref_store(), add register_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 15/27] refs.c: make get_main_ref_store() public and use it Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 16/27] path.c: move some code out of strbuf_git_path_submodule() Nguyễn Thái Ngọc Duy 2017-03-19 20:47 ` Michael Haggerty 2017-03-20 12:11 ` Duy Nguyen 2017-03-18 2:03 ` [PATCH v6 17/27] refs: move submodule code out of files-backend.c Nguyễn Thái Ngọc Duy 2017-03-19 21:05 ` Michael Haggerty 2017-03-20 12:09 ` Duy Nguyen 2017-03-20 14:29 ` Michael Haggerty 2017-03-18 2:03 ` [PATCH v6 18/27] files-backend: replace submodule_allowed check in files_downcast() Nguyễn Thái Ngọc Duy 2017-03-19 21:18 ` Michael Haggerty 2017-03-26 2:16 ` Duy Nguyen 2017-03-29 10:55 ` Michael Haggerty 2017-03-18 2:03 ` [PATCH v6 19/27] refs: rename get_ref_store() to get_submodule_ref_store() and make it public Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 20/27] refs: add new ref-store api Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 21/27] refs: new transaction related " Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 22/27] files-backend: avoid ref api targetting main ref store Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 23/27] refs: delete pack_refs() in favor of refs_pack_refs() Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 24/27] t/helper: add test-ref-store to test ref-store functions Nguyễn Thái Ngọc Duy 2017-03-22 13:34 ` Jeff King 2017-03-22 13:37 ` Jeff King 2017-03-25 11:54 ` Duy Nguyen 2017-03-18 2:03 ` [PATCH v6 25/27] t1405: some basic tests on main ref store Nguyễn Thái Ngọc Duy 2017-03-18 2:03 ` [PATCH v6 26/27] t1406: new tests for submodule " Nguyễn Thái Ngọc Duy 2017-03-20 5:27 ` Michael Haggerty 2017-03-20 12:05 ` Duy Nguyen 2017-03-18 2:03 ` [PATCH v6 27/27] refs.h: add a note about sorting order of for_each_ref_* Nguyễn Thái Ngọc Duy 2017-03-20 5:37 ` [PATCH v6 00/27] Remove submodule from files-backend.c Michael Haggerty 2017-03-20 15:53 ` Junio C Hamano 2017-03-26 2:42 ` [PATCH v7 00/28] " Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 01/28] refs.h: add forward declaration for structs used in this file Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 02/28] files-backend: make files_log_ref_write() static Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 03/28] files-backend.c: delete dead code in files_ref_iterator_begin() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 04/28] files-backend: delete dead code in files_init_db() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 05/28] files-backend: add and use files_packed_refs_path() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 06/28] files-backend: make sure files_rename_ref() always reach the end Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` Nguyễn Thái Ngọc Duy [this message] 2017-03-26 2:42 ` [PATCH v7 08/28] files-backend: move "logs/" out of TMP_RENAMED_LOG Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 09/28] files-backend: add and use files_reflog_path() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 10/28] files-backend: add and use files_ref_path() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 11/28] files-backend: remove the use of git_path() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 12/28] refs.c: introduce get_main_ref_store() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 13/28] refs: rename lookup_ref_store() to lookup_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 14/28] refs.c: flatten get_ref_store() a bit Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 15/28] refs.c: kill register_ref_store(), add register_submodule_ref_store() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 16/28] refs.c: make get_main_ref_store() public and use it Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 17/28] path.c: move some code out of strbuf_git_path_submodule() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 18/28] refs: move submodule code out of files-backend.c Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 19/28] files-backend: replace submodule_allowed check in files_downcast() Nguyễn Thái Ngọc Duy 2017-04-01 4:02 ` Michael Haggerty 2017-04-07 12:41 ` Duy Nguyen 2017-04-14 10:44 ` Junio C Hamano 2017-04-14 13:02 ` Duy Nguyen 2017-03-26 2:42 ` [PATCH v7 20/28] refs: rename get_ref_store() to get_submodule_ref_store() and make it public Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 21/28] refs: add new ref-store api Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 22/28] refs: new transaction related " Nguyễn Thái Ngọc Duy 2017-04-01 4:54 ` Michael Haggerty 2017-04-07 12:29 ` Duy Nguyen 2017-03-26 2:42 ` [PATCH v7 23/28] files-backend: avoid ref api targetting main ref store Nguyễn Thái Ngọc Duy 2017-04-01 5:05 ` Michael Haggerty 2017-03-26 2:42 ` [PATCH v7 24/28] refs: delete pack_refs() in favor of refs_pack_refs() Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 25/28] t/helper: add test-ref-store to test ref-store functions Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 26/28] t1405: some basic tests on main ref store Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 27/28] t1406: new tests for submodule " Nguyễn Thái Ngọc Duy 2017-03-26 2:42 ` [PATCH v7 28/28] refs.h: add a note about sorting order of for_each_ref_* Nguyễn Thái Ngọc Duy 2017-04-01 5:09 ` [PATCH v7 00/28] Remove submodule from files-backend.c Michael Haggerty 2017-04-11 8:30 ` Junio C Hamano 2017-02-17 18:35 ` [PATCH v2 00/16] " Junio C Hamano 2017-02-17 20:49 ` Junio C Hamano 2017-02-18 13:15 ` Duy Nguyen
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170326024241.31984-8-pclouds@gmail.com \ --to=pclouds@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=mhagger@alum.mit.edu \ --cc=novalis@novalis.org \ --cc=peff@peff.net \ --cc=ramsay@ramsayjones.plus.com \ --cc=sbeller@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Example config snippet for mirrors Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git