From: Jeff King <peff@peff.net>
To: Romuald Brunet <romuald@chivil.com>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@imag.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] push: allow atomic flag via configuration
Date: Fri, 24 Mar 2017 14:45:51 -0400 [thread overview]
Message-ID: <20170324184550.3l6mw4ybynizblsm@sigill.intra.peff.net> (raw)
In-Reply-To: <1490375874.745.227.camel@locke.gandi.net>
On Fri, Mar 24, 2017 at 06:17:54PM +0100, Romuald Brunet wrote:
> Added a "push.atomic" option to git-config to allow site-specific
> configuration of the atomic flag of git push
I don't really use --atomic myself, but this seems like a reasonable
thing to want, and the implementation looks cleanly done.
My one question would be whether people would want this to actually be
specific to a particular remote, and not just on for a given repository
(your "site-specific" in the description made me think of that). In that
case it would be better as part of the remote.* config.
-Peff
next prev parent reply other threads:[~2017-03-24 18:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 17:17 [PATCH] push: allow atomic flag via configuration Romuald Brunet
2017-03-24 18:45 ` Jeff King [this message]
2017-03-24 18:53 ` Jonathan Nieder
2017-03-24 19:01 ` Jeff King
2017-03-24 19:29 ` Junio C Hamano
2017-03-27 8:27 ` Romuald Brunet
2017-03-28 0:51 ` Jonathan Nieder
2017-03-27 9:30 ` Ævar Arnfjörð Bjarmason
2017-03-27 9:33 ` Ævar Arnfjörð Bjarmason
2017-03-27 16:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324184550.3l6mw4ybynizblsm@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=romuald@chivil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).