From: Jeff King <peff@peff.net>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de,
gitster@pobox.com, sxlijin@gmail.com
Subject: Re: [PATCH v2] travis-ci: build and test Git on Windows
Date: Fri, 24 Mar 2017 10:59:40 -0400 [thread overview]
Message-ID: <20170324145940.xqjmwxphwmtx67ug@sigill.intra.peff.net> (raw)
In-Reply-To: <20170324113747.44991-1-larsxschneider@gmail.com>
On Fri, Mar 24, 2017 at 12:37:47PM +0100, Lars Schneider wrote:
> I think I addressed all issues from the v1 review (see interdiff below)
> with one exception. The script still uses bash instead of sh. Something
> about this does not work in sh:
> --output >(sed "$(printf '1s/^\xef\xbb\xbf//')" >cat >&3)
>
> Does anyone know how to make this sh compatible?
Process substitution is a bash-ism. Just looking at this snippet I would
ask why you aren't just using stdout, but from the whole diff it looks
like you're using --write-out and want to keep the streams separate.
The POSIX shell way would be to make your own named pipe rather than
anonymous one:
mkfifo data
sed ... <data &
curl ... --output data
rm data
But I don't think relying on bash is that big a deal, as long as the
script is clearly marked with the correct #!-line (which it is).
The ">cat" isn't doing AFAICT, though.
-Peff
next prev parent reply other threads:[~2017-03-24 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 11:37 [PATCH v2] travis-ci: build and test Git on Windows Lars Schneider
2017-03-24 11:48 ` Daniel Stenberg
2017-03-24 12:35 ` Lars Schneider
2017-03-24 12:42 ` Daniel Stenberg
2017-03-24 12:43 ` Sebastian Schuberth
2017-03-29 23:26 ` Johannes Schindelin
2017-03-24 14:59 ` Jeff King [this message]
2017-03-24 16:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324145940.xqjmwxphwmtx67ug@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=larsxschneider@gmail.com \
--cc=sxlijin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).