From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Lars Hjemli" <hjemli@gmail.com>, "Jeff King" <peff@peff.net>,
"Christian Couder" <christian.couder@gmail.com>,
"Carlos Rica" <jasampler@gmail.com>,
"Samuel Tardieu" <sam@rfc1149.net>,
"Tom Grennan" <tmgrennan@gmail.com>,
"Karthik Nayak" <karthik.188@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v3 00/16] Various changes to the "tag" command & related
Date: Thu, 23 Mar 2017 13:05:13 +0000 [thread overview]
Message-ID: <20170323130529.11361-1-avarab@gmail.com> (raw)
Hopefully the last version of this. Changes since v2 in
<20170321125901.10652-1-avarab@gmail.com>:
Ævar Arnfjörð Bjarmason (16):
tag doc: move the description of --[no-]merged earlier
tag doc: split up the --[no-]merged documentation
tag doc: reword --[no-]merged to talk about commits, not tips
ref-filter: make combining --merged & --no-merged an error
No changes.
ref-filter: add test for --contains on a non-commit
Minor grammar fixes in the commit message, as pointed out on-list.
tag: remove a TODO item from the test suite
tag tests: fix a typo in a test description
for-each-ref: partly change <object> to <commit> in help
No changes.
tag: add more incompatibles mode tests
Reworded the commit message to be less confusing, as pointed out
on-list & added a few more tests for incompatible model, e.g. modes,
e.g. "-l -v -d".
parse-options: add OPT_NONEG to the "contains" option
NEW: Junio pointed out that my new --without should have a OPT_NONEG,
which made me notice that --with and --contains have also had the same
bug for ages without anyone noticing, add OPT_NONEG to them all.
tag: change misleading --list <pattern> documentation
Hopefully solves the sticking point with the "-l <pat> -l <pat>" test
I'm adding, there's now a big fat comment saying this was never
intended behavior but we want to test it blah blah.
Also change `git tag <pattern>` -> `git tag <tagname>`. See also my
just-sent "[PATCH] branch doc: Change `git branch <pattern>` to use
`<branchname>`".
tag: implicitly supply --list given another list-like option
Minor typo fix in commit message, as pointed out on-list.
Squashed the "tag: implicitly supply --list given the -n option" patch
into this, as discussed on-list.
tag: change --point-at to default to HEAD
ref-filter: add --no-contains option to tag/branch/for-each-ref
The new --no-contains & --without options also have OPT_NONEG now.
ref-filter: reflow recently changed branch/tag/for-each-ref docs
Add missing Signed-off-by.
tag: add tests for --with and --without
Add a couple of extra tests asserting that --no-with and --no-without
error out.
Documentation/git-branch.txt | 33 +++--
Documentation/git-for-each-ref.txt | 12 +-
Documentation/git-tag.txt | 60 +++++---
builtin/branch.c | 5 +-
builtin/for-each-ref.c | 5 +-
builtin/tag.c | 27 ++--
contrib/completion/git-completion.bash | 4 +-
parse-options.h | 6 +-
ref-filter.c | 30 +++-
ref-filter.h | 1 +
t/t3200-branch.sh | 4 +
t/t3201-branch-contains.sh | 61 +++++++-
t/t6302-for-each-ref-filter.sh | 20 +++
t/t7004-tag.sh | 245 +++++++++++++++++++++++++++++++--
14 files changed, 441 insertions(+), 72 deletions(-)
--
2.11.0
next reply other threads:[~2017-03-23 13:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 13:05 Ævar Arnfjörð Bjarmason [this message]
2017-03-23 13:05 ` [PATCH v3 01/16] tag doc: move the description of --[no-]merged earlier Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 02/16] tag doc: split up the --[no-]merged documentation Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 03/16] tag doc: reword --[no-]merged to talk about commits, not tips Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 04/16] ref-filter: make combining --merged & --no-merged an error Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 05/16] ref-filter: add test for --contains on a non-commit Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 06/16] tag: remove a TODO item from the test suite Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 07/16] tag tests: fix a typo in a test description Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 08/16] for-each-ref: partly change <object> to <commit> in help Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 09/16] tag: add more incompatibles mode tests Ævar Arnfjörð Bjarmason
2017-03-23 17:13 ` Junio C Hamano
2017-03-23 20:37 ` Ævar Arnfjörð Bjarmason
2017-03-23 21:36 ` Junio C Hamano
2017-03-23 22:13 ` Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 10/16] parse-options: add OPT_NONEG to the "contains" option Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 11/16] tag: change misleading --list <pattern> documentation Ævar Arnfjörð Bjarmason
2017-03-23 17:16 ` Junio C Hamano
2017-03-23 13:05 ` [PATCH v3 12/16] tag: implicitly supply --list given another list-like option Ævar Arnfjörð Bjarmason
2017-03-23 17:29 ` Junio C Hamano
2017-03-23 20:32 ` Ævar Arnfjörð Bjarmason
2017-03-23 21:33 ` Junio C Hamano
2017-03-23 13:05 ` [PATCH v3 13/16] tag: change --point-at to default to HEAD Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 14/16] ref-filter: add --no-contains option to tag/branch/for-each-ref Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 15/16] ref-filter: reflow recently changed branch/tag/for-each-ref docs Ævar Arnfjörð Bjarmason
2017-03-23 13:05 ` [PATCH v3 16/16] tag: add tests for --with and --without Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323130529.11361-1-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=jasampler@gmail.com \
--cc=karthik.188@gmail.com \
--cc=peff@peff.net \
--cc=sam@rfc1149.net \
--cc=tmgrennan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).