From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 2AA0520323 for ; Wed, 22 Mar 2017 13:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933105AbdCVNhn (ORCPT ); Wed, 22 Mar 2017 09:37:43 -0400 Received: from cloud.peff.net ([104.130.231.41]:49319 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759652AbdCVNhl (ORCPT ); Wed, 22 Mar 2017 09:37:41 -0400 Received: (qmail 28752 invoked by uid 109); 22 Mar 2017 13:37:40 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Wed, 22 Mar 2017 13:37:40 +0000 Received: (qmail 26120 invoked by uid 111); 22 Mar 2017 13:37:53 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Wed, 22 Mar 2017 09:37:53 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 22 Mar 2017 09:37:35 -0400 Date: Wed, 22 Mar 2017 09:37:35 -0400 From: Jeff King To: =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy Cc: git@vger.kernel.org, Junio C Hamano , Michael Haggerty , Johannes Schindelin , Ramsay Jones , Stefan Beller , novalis@novalis.org Subject: Re: [PATCH v6 24/27] t/helper: add test-ref-store to test ref-store functions Message-ID: <20170322133735.ozjbncfm5tchygoc@sigill.intra.peff.net> References: <20170222140450.30886-1-pclouds@gmail.com> <20170318020337.22767-1-pclouds@gmail.com> <20170318020337.22767-25-pclouds@gmail.com> <20170322133412.e2oqmqekreyuf4gr@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170322133412.e2oqmqekreyuf4gr@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Mar 22, 2017 at 09:34:12AM -0400, Jeff King wrote: > On Sat, Mar 18, 2017 at 09:03:34AM +0700, Nguyễn Thái Ngọc Duy wrote: > > > diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c > > new file mode 100644 > > When nd/files-backend-git-dir is merged to 'next', the new tests in > t1405/t1406 break. They need this on top (which should probably just be > squashed into this commit when you re-roll). > > -- >8 -- > Subject: [PATCH] test-ref-store: setup git directory > > Without setting up the git directory, we rely on the ".git" > fallback in setup_git_env(). This will cause us to abort > once b1ef400ee (setup_git_env: avoid blind fall-back to > ".git", 2016-10-20) is merged. After posting this, it occurred to me that "pu" should be showing the same failure, but it doesn't. The reason is that e9e167145 (worktree.c: kill parse_ref() in favor of refs_resolve_ref_unsafe(), 2017-03-18) from nd/worktree-kill-parse-ref sneaks in the setup call. We should move it back to the addition of test-ref-store, though, since nd/files-backend-git-dir may graduate separately. -Peff