From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Ben Peart <peartben@gmail.com>
Cc: 'git' <git@vger.kernel.org>,
"Jeff Hostetler (jeffhost@microsoft.com)"
<Jeff.Hostetler@microsoft.com>,
Ben Peart <benpeart@microsoft.com>
Subject: Re: Safe to use stdatomic.h?
Date: Mon, 20 Mar 2017 23:22:40 +0000 [thread overview]
Message-ID: <20170320232240.k3egololfj7wt5cf@genre.crustytoothpaste.net> (raw)
In-Reply-To: <000801d2a1b7$1ec41620$5c4c4260$@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]
On Mon, Mar 20, 2017 at 04:18:20PM -0400, Ben Peart wrote:
> My college Jeff is working on a patch series to further parallelize the
> loading of the index. As part of that patch, it would be nice to use the
> atomic_fetch_add function as that would be more efficient than creating a
> mutex simply to protect a variable so that it can be incremented. I haven't
> seen any use of atomics yet in Git, nor anything that includes
> <stdatomic.h>.
>
> GCC has supported them since 4.9 and Clang has supported them by default
> since 3.3. Are there any compilers currently in use by Git that don't
> support these C11 functions?
At work, we're compiling for CentOS 6 and 7. CentOS 7 only has GCC 4.8,
and CentOS 6 has something much older. This is code we ship to
customers, so we can't rely on them having devtoolset installed for
newer GCC.
I could support the argument for ditching RHEL/CentOS 5 support, but I
expect other people might disagree. After all, we're still targeting
C89.
--
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2017-03-20 23:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 20:18 Safe to use stdatomic.h? Ben Peart
2017-03-20 20:27 ` Jeff King
2017-03-20 23:22 ` brian m. carlson [this message]
2017-03-21 1:59 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320232240.k3egololfj7wt5cf@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=Jeff.Hostetler@microsoft.com \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).