From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/5] minor pack-name cleanups
Date: Thu, 16 Mar 2017 10:26:47 -0400 [thread overview]
Message-ID: <20170316142647.t6tthkcgon3rpg4m@sigill.intra.peff.net> (raw)
In-Reply-To: <20170315212617.6x57bvltinuozv4q@sigill.intra.peff.net>
Here's a re-roll of the series from:
http://public-inbox.org/git/20170315212617.6x57bvltinuozv4q@sigill.intra.peff.net/
The general gist is the same, but there are a number of changes:
- I dropped the first patch factoring out finalize_file(), as Ramsay
pointed out a subtle difference between the index and pack handling.
- I added an extra patch on top (5/5 here) to get the same
pointer-aliasing safety that the factored-out function got us
(more so, actually, as it protects keep_msg, too).
- I re-ordered the odb_pack_keep() cleanup before the odb_pack_name()
cleanups, which lets us do the latter in one swoop (and avoids
explaining "well, we can't do .keep yet, because..." in the commit
message)
- The original had two patches doing the odb_pack_name() conversion.
Now that it has fewer caveats, I felt comfortable lumping it all
into one (patch 4/5 here).
[1/5]: move odb_* declarations out of git-compat-util.h
[2/5]: sha1_file.c: make pack-name helper globally accessible
[3/5]: odb_pack_keep(): stop generating keepfile name
[4/5]: replace snprintf with odb_pack_name()
[5/5]: index-pack: make pointer-alias fallbacks safer
builtin/index-pack.c | 31 +++++++++++++++----------------
cache.h | 21 +++++++++++++++++++++
environment.c | 6 ++----
fast-import.c | 26 +++++++++++++-------------
git-compat-util.h | 2 --
sha1_file.c | 17 ++++++-----------
6 files changed, 57 insertions(+), 46 deletions(-)
next prev parent reply other threads:[~2017-03-16 14:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 21:26 [PATCH 0/6] minor pack-name cleanups Jeff King
2017-03-15 21:27 ` [PATCH 1/6] index-pack: factor out pack/idx finalization Jeff King
2017-03-15 22:03 ` Ramsay Jones
2017-03-15 22:22 ` Jeff King
2017-03-15 22:30 ` Jeff King
2017-03-15 21:27 ` [PATCH 2/6] move odb_* declarations out of git-compat-util.h Jeff King
2017-03-15 21:28 ` [PATCH 3/6] sha1_file.c: make pack-name helper globally accessible Jeff King
2017-03-15 21:28 ` [PATCH 4/6] index-pack: drop fixed-size buffer for pack filenames Jeff King
2017-03-15 21:29 ` [PATCH 5/6] fast-import: replace fixed buffer with odb_pack_name Jeff King
2017-03-15 21:30 ` [PATCH 6/6] odb_pack_keep(): stop generating keepfile name Jeff King
2017-03-16 1:24 ` Junio C Hamano
2017-03-16 14:26 ` Jeff King [this message]
2017-03-16 14:27 ` [PATCH v2 1/5] move odb_* declarations out of git-compat-util.h Jeff King
2017-03-16 14:27 ` [PATCH v2 2/5] sha1_file.c: make pack-name helper globally accessible Jeff King
2017-03-16 14:31 ` Jeff King
2017-03-16 17:03 ` Ramsay Jones
2017-03-16 17:40 ` Jeff King
2017-03-16 14:27 ` [PATCH v2 3/5] odb_pack_keep(): stop generating keepfile name Jeff King
2017-03-16 14:27 ` [PATCH v2 4/5] replace snprintf with odb_pack_name() Jeff King
2017-03-16 15:37 ` Ramsay Jones
2017-03-16 18:33 ` Junio C Hamano
2017-03-16 18:34 ` Jeff King
2017-03-16 18:57 ` Junio C Hamano
2017-03-16 14:27 ` [PATCH v2 5/5] index-pack: make pointer-alias fallbacks safer Jeff King
2017-03-16 15:42 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316142647.t6tthkcgon3rpg4m@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).