From: Jeff King <peff@peff.net>
To: Thomas Braun <thomas.braun@virtuell-zuhause.de>
Cc: Florian Adamus <florian-adamus@gmx.de>, git@vger.kernel.org
Subject: Re: Commiting files larger than 4 GB on Windows
Date: Wed, 15 Mar 2017 11:59:52 -0400 [thread overview]
Message-ID: <20170315155952.x2tpiudi6rbqidvi@sigill.intra.peff.net> (raw)
In-Reply-To: <179b5d92-ee96-c2df-dbd8-eb96f7bbdb24@virtuell-zuhause.de>
On Wed, Mar 15, 2017 at 02:48:57PM +0100, Thomas Braun wrote:
> I can not comment on the git-lfs issues. The issue that you can not
> properly use files larger than 4GB on windows (no matter if 32bit or
> 64bit) is known, see my findings from May last year [1]. Unfortunately
> nobody, including me, did find time to fix the underlying issue
> properly.
I suspect the fix is going to be quite involved. The use of "unsigned
long" for object sizes is all over the code base.
> My band-aid patch from [1]
>
> diff --git a/pack-write.c b/pack-write.c
> index 33293ce..ebb8b0a 100644
> --- a/pack-write.c
> +++ b/pack-write.c
> @@ -313,6 +313,9 @@ int encode_in_pack_object_header(enum object_type type, uintmax_t size, unsigned
> if (type < OBJ_COMMIT || type > OBJ_REF_DELTA)
> die("bad type %d", type);
>
> + if (bitsizeof(unsigned long) != bitsizeof(uintmax_t) && size > (unsigned long) size)
> + die("Cannot handle files this big");
> +
> c = (type << 4) | (size & 15);
> size >>= 4;
> while (size) {
>
> would at least tell the user much earlier about the problem. I can
> submit the above diff as proper patch if it is deemed a worthy change.
I agree that detecting the situation in the meantime is a good idea.
The patch above probably handles the bulk-checkin code path, I'd guess.
It might be nice to have similar checks in other places, too:
- when reading from an existing packfile
Looks like we may already have such a check in
unpack_object_header_buffer().
- when taking in new objects via index-pack or unpack-objects (to
catch a fetch of a too-big object)
I think index-pack.c:unpack_raw_entry() would want a similar check
to what is in unpack_object_header_buffer().
-Peff
next prev parent reply other threads:[~2017-03-15 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 13:00 Commiting files larger than 4 GB on Windows Florian Adamus
2017-03-15 13:48 ` Thomas Braun
2017-03-15 15:59 ` Jeff King [this message]
2017-03-15 16:13 ` Jeff King
2017-03-15 18:23 ` Thomas Braun
2017-03-15 21:15 ` Torsten Bögershausen
2017-03-15 21:29 ` Junio C Hamano
2017-03-17 5:29 ` Torsten Bögershausen
2017-03-18 13:03 ` Thomas Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315155952.x2tpiudi6rbqidvi@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=florian-adamus@gmx.de \
--cc=git@vger.kernel.org \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).