From: Jonathan Nieder <jrnieder@gmail.com>
To: Devin Lehmacher <djl329@cornell.edu>
Cc: git@vger.kernel.org, Noam Postavsky <npostavs@users.sourceforge.net>
Subject: Re: [GSoC] Move ~/.git-credential-cache to ~/.cache/git
Date: Fri, 10 Mar 2017 16:26:15 -0800 [thread overview]
Message-ID: <20170311002615.GG26789@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <8BE1A361-32BB-4164-AD54-949555855C52@cornell.edu>
(+cc: npostavs)
Hi Devin,
Devin Lehmacher wrote:
> I started working on this microproject and am not quite sure what is
> necessary for backwards compatibility. Since the socket is recreated
> whenever the credential daemon exits backwards compatibility
> shouldn’t really be a concern with regard to where the socket is
> located in the filesystem.
>
> However, contrib/persistent-https depends on the socket being at
> ~/.git-credential-cache/socket, so changing the default location
> would break this. However, if we need to keep the socket at that
> location for cases like this I don’t understand how this change
> would be helpful in any way.
That's a good question. If I'm reading contrib/persistent-https/
correctly, it uses the same directory but doesn't rely on the socket
there, so it should not be a problem.
However, that reminded me to search for other tools that might rely on
the socket. Using
https://codesearch.debian.net/search?q=%5C.git-credential-cache, I
find that magit does rely on the socket path.
$ git clone https://github.com/magit/magit
$ git log -S.git-credential-cache
commit 0f30dfbb0075ac2e99b65a2c7fac360197a989c1
Author: Noam Postavsky <npostavs@users.sourceforge.net>
Date: Sat Oct 24 15:57:54 2015 -0400
Start credential daemon on magit-credential-hook
If we let git start the daemon, Emacs will send a SIGHUP when git
finishes and closes the pty, killing the daemon. Hence the need to have
our own daemon running first.
Cc-ing Noam to figure out what a safe transition will look like.
Thanks for noticing,
Jonathan
next prev parent reply other threads:[~2017-03-11 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 23:30 [GSoC] Move ~/.git-credential-cache to ~/.cache/git Devin Lehmacher
2017-03-11 0:26 ` Jonathan Nieder [this message]
2017-03-11 1:02 ` Noam Postavsky
2017-03-11 2:27 ` Devin Lehmacher
2017-03-11 3:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170311002615.GG26789@aiede.mtv.corp.google.com \
--to=jrnieder@gmail.com \
--cc=djl329@cornell.edu \
--cc=git@vger.kernel.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).