From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 594891FBEC for ; Fri, 10 Mar 2017 19:47:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755514AbdCJTrm (ORCPT ); Fri, 10 Mar 2017 14:47:42 -0500 Received: from cloud.peff.net ([104.130.231.41]:42231 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755377AbdCJTrl (ORCPT ); Fri, 10 Mar 2017 14:47:41 -0500 Received: (qmail 29671 invoked by uid 109); 10 Mar 2017 19:47:28 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Fri, 10 Mar 2017 19:47:28 +0000 Received: (qmail 7612 invoked by uid 111); 10 Mar 2017 19:47:37 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Fri, 10 Mar 2017 14:47:37 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 10 Mar 2017 14:47:26 -0500 Date: Fri, 10 Mar 2017 14:47:26 -0500 From: Jeff King To: Junio C Hamano Cc: Brandon Williams , Jeff Hostetler , Jeff Hostetler , git@vger.kernel.org, markbt@efaref.net, benpeart@microsoft.com, jonathantanmy@google.com Subject: Re: [PATCH 02/10] pack-objects: add --partial-by-size=n --partial-special Message-ID: <20170310194725.36acsc2bdfhl4aih@sigill.intra.peff.net> References: <1488994685-37403-1-git-send-email-jeffhost@microsoft.com> <1488994685-37403-3-git-send-email-jeffhost@microsoft.com> <1c38ffbc-e4a2-32e5-d324-506c2111043e@jeffhostetler.com> <20170309070438.r5g2h5vlmgzds4kp@sigill.intra.peff.net> <20170310175823.GA53198@google.com> <20170310180341.bbzukqrj2zlkje2b@sigill.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Mar 10, 2017 at 11:38:10AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > I think we ended up deciding that it would be better to just disallow > > symlink .gitattributes (and .git*) from entering the index, the way we > > disallow ".git". > > Hmph, I thought we would need both, though. Or do we specifically > want to honor untracked .gitattributes that is left as a symlink > pointing to elsewhere in the filesystem or something like that? I wasn't going to worry about an untracked .gitattributes. The reasons for disallowing symlinked .gitattributes are: - it doesn't behave the same when accessed internally via the tree objects - malicious symlinks that try to leave the repository Neither of those issues is at play if your symlink .gitattributes file isn't tracked. So there's some inconsistency in the sense that it "works" until you try to "git add" it. But either you aren't going to add it (in which case it's a feature that it works), or you are going to add it, and you'll get notified then that it's disallowed. -Peff