From: Siddharth Kannan <kannan.siddharth12@gmail.com>
To: mash <mash+git@crossperf.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
stepnem@gmail.com, Stefan Beller <sbeller@google.com>,
Vedant Bassi <sharababy.dev@gmail.com>,
Prathamesh Chavan <pc44800@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: [PATCH v2 GSoC RFC] diff: allow "-" as a short-hand for "last branch"
Date: Fri, 10 Mar 2017 04:59:03 +0000 [thread overview]
Message-ID: <20170310045903.GA2417@instance-1.c.mfqp-source.internal> (raw)
Hey, I have already worked on this, and I made the change inside
sha1_name.c.
The final version of my patch is here[1].
> Handling the dash in sha1_name:get_sha1_basic is not an issue but
> git
> was designed with the dash in mind for options not for this weird
> short-hand so as long as there's no decision made that git should
> actually have this short-hand everywhere it does not seem like a
> good
> idea to change anything in there because it would probably have
> unwanted side-effects.
Actually, this was discussed even when I was working on this patch.
I said [2]
> Making a change in sha1_name.c will touch a lot of commands
> (setup_revisions is called from everywhere in the codebase), so, I
> am
> still trying to figure out how to do this such that the rest of the
> codepath remains unchanged.
Matthieu replied to this [3]
> I don't have strong opinion on this: I tend to favor consistency and
> supporting "-" everywhere goes in this direction, but I think the
> downsides should be considered too. A large part of the exercice
> here
> is to write a good commit message!
From the discussion over the different versions of my patch, I get
the feeling that enabling this shorthand for all the commands is the
direction that git wants to move in.
Sorry about the time you spent on this patch.
[1]: http://public-inbox.org/git/1488007487-12965-1-git-send-email-kannan.siddharth12@gmail.com/
[2]: https://public-inbox.org/git/20170207191450.GA5569@ubuntu-512mb-blr1-01.localdomain/
[3]: https://public-inbox.org/git/vpqh944eof7.fsf@anie.imag.fr/
Thanks,
Siddharth.
P.S. This message was sent _before_ 1cmCXH-0000ND-9K@crossperf.com but
I didn't CC The mailing list in that message. I am sending it with the
mailing list cc-ed to ensure that the conversation makes sense.
next reply other threads:[~2017-03-10 4:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 4:59 Siddharth Kannan [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-08 9:50 [PATCH] diff: allow "-" as a short-hand for "last branch" mash
2017-03-09 20:26 ` [PATCH v2 GSoC RFC] " mash
[not found] ` <20170310034106.GB1984@instance-1.c.mfqp-source.internal>
2017-03-10 4:52 ` mash
2017-03-10 5:00 ` Siddharth Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310045903.GA2417@instance-1.c.mfqp-source.internal \
--to=kannan.siddharth12@gmail.com \
--cc=1cm4dm-0007OE-MZ@crossperf.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mash+git@crossperf.com \
--cc=pc44800@gmail.com \
--cc=sbeller@google.com \
--cc=sharababy.dev@gmail.com \
--cc=stepnem@gmail.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).