From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Lars Hjemli <hjemli@gmail.com>,
Christian Couder <christian.couder@gmail.com>
Subject: Re: [PATCH] branch & tag: Add a --no-contains option
Date: Thu, 9 Mar 2017 09:55:55 -0500 [thread overview]
Message-ID: <20170309145555.kzrttqya3bghdhe4@sigill.intra.peff.net> (raw)
In-Reply-To: <CACBZZX4W7brFe5ecTvQPMmf4X5_zH+dw3cB5xeVg+2hWYps0Ug@mail.gmail.com>
On Thu, Mar 09, 2017 at 03:52:09PM +0100, Ævar Arnfjörð Bjarmason wrote:
> - filter->with_commit_tag_algo = 1;
> + if ((filter->merge_commit + filter->with_commit +
> filter->no_commit) > 1)
> + filter->with_commit_tag_algo = 0;
> + else
> + filter->with_commit_tag_algo = 1;
> filter_refs(&array, filter, FILTER_REFS_TAGS);
> ref_array_sort(sorting, &array);
>
> I think I'll amend the tip of my WIP v2 to have something like that,
> and then we can follow-up with making these cases where you supply
> multiple options faster.
Yeah, that's another option. I think you may find that it's unbearably
slow if you have a lot of tags.
> > Looking at this, I'm pretty sure that using "--contains" with "--merged"
> > has similar problems, as they both use the UNINTERESTING bit. So even
> > without your patch, there is a lurking bug.
>
> I'm currently running this:
> https://gist.github.com/avar/45cf288ce7cdc43e7395c6cbf9a98d68
Cute. I'll be curious if it turns up anything.
-Peff
next prev parent reply other threads:[~2017-03-09 15:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 20:20 [PATCH] branch & tag: Add a --no-contains option Ævar Arnfjörð Bjarmason
2017-03-08 23:02 ` Junio C Hamano
2017-03-09 10:09 ` Jeff King
2017-03-09 10:41 ` Ævar Arnfjörð Bjarmason
2017-03-09 10:46 ` Jeff King
2017-03-09 12:12 ` Ævar Arnfjörð Bjarmason
2017-03-09 12:51 ` Jeff King
2017-03-09 13:27 ` [PATCH 0/4] fix object flag pollution in "tag --contains" Jeff King
2017-03-09 13:27 ` [PATCH 1/4] ref-filter: move ref_cbdata definition into ref-filter.c Jeff King
2017-03-09 13:28 ` [PATCH 2/4] ref-filter: use contains_result enum consistently Jeff King
2017-03-09 13:29 ` [PATCH 3/4] ref-filter: die on parse_commit errors Jeff King
2017-03-09 13:29 ` [PATCH 4/4] ref-filter: use separate cache for contains_tag_algo Jeff King
2017-03-11 20:01 ` Ævar Arnfjörð Bjarmason
2017-03-11 20:21 ` Ævar Arnfjörð Bjarmason
2017-03-12 11:12 ` Jeff King
2017-03-11 13:06 ` [PATCH 0/4] fix object flag pollution in "tag --contains" Ævar Arnfjörð Bjarmason
2017-03-11 20:18 ` [PATCH v4] ref-filter: Add --no-contains option to tag/branch/for-each-ref Ævar Arnfjörð Bjarmason
2017-03-12 4:44 ` Junio C Hamano
2017-03-12 9:10 ` Ævar Arnfjörð Bjarmason
2017-03-12 17:49 ` Junio C Hamano
2017-03-09 14:52 ` [PATCH] branch & tag: Add a --no-contains option Ævar Arnfjörð Bjarmason
2017-03-09 14:55 ` Jeff King [this message]
2017-03-10 11:31 ` Ævar Arnfjörð Bjarmason
2017-03-09 20:02 ` [PATCH v2] ref-filter: Add --no-contains option to tag/branch/for-each-ref Ævar Arnfjörð Bjarmason
2017-03-09 20:31 ` Christian Couder
2017-03-10 11:46 ` Ævar Arnfjörð Bjarmason
2017-03-10 12:09 ` Ævar Arnfjörð Bjarmason
2017-03-10 20:33 ` [PATCH v3] " Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309145555.kzrttqya3bghdhe4@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).