From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Dmitry Neverov <dmitry.neverov@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>
Subject: Re: 'git submodules update' ignores credential.helper config of the parent repository
Date: Tue, 28 Feb 2017 09:37:10 -0500 [thread overview]
Message-ID: <20170228143710.smbzo6b7wefjc62r@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79ka8saQMKeutE415WxOQ71MnEw1A4uV3b0Pa4gcehx8pdw@mail.gmail.com>
On Mon, Feb 27, 2017 at 11:09:12AM -0800, Stefan Beller wrote:
> For worktrees these multiple config files sounded like
> the obvious solution, but I wonder if there was also
> some bike shedding about other solutions?
>
> I could imagine that we would want to have attributes
> for specific configuration, e.g.:
>
> --8<--
> [core]
> repositoryformatversion = 0
> filemode = true
> bare = false
> logallrefupdates = true
> [remote "origin"]
> url = git://github.com/gitster/git
> fetch = +refs/heads/*:refs/remotes/origin/*
> [attribute "submodules"]
> read = true
> # this will be read and respected by submodules as well:
> [url."internal-git-miror"]
> insteadOf = github.com
> [attribute "submodules"]
> read = false
> # This (and the beginning of this file) will not be respected
> # by submodules
> [credential]
> helper =
> -->8--
>
> This would change the semantics of a config file as the attribute for
> each setting depends on the location (was attribute.FOO.read =
> {true, false} read before).
I'm not enthused by this, just because there is a hidden dependency
between attribute.* sections and other ones. They _look_ like regular
config keys, but they really aren't.
I have a feeling that something like this would create unwelcome corner
cases in the config-writer, which is otherwise does not have to care
about which existing section of a file it adds a key to.
-Peff
next prev parent reply other threads:[~2017-02-28 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 13:33 'git submodules update' ignores credential.helper config of the parent repository Dmitry Neverov
2017-02-27 19:09 ` Stefan Beller
2017-02-28 14:37 ` Jeff King [this message]
2017-02-28 18:05 ` Stefan Beller
2017-02-28 20:08 ` Jeff King
2017-02-28 20:21 ` Stefan Beller
2017-02-28 20:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228143710.smbzo6b7wefjc62r@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dmitry.neverov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).