From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0351F2022D for ; Thu, 23 Feb 2017 23:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751332AbdBWXHb (ORCPT ); Thu, 23 Feb 2017 18:07:31 -0500 Received: from mail-pg0-f52.google.com ([74.125.83.52]:33448 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbdBWXHa (ORCPT ); Thu, 23 Feb 2017 18:07:30 -0500 Received: by mail-pg0-f52.google.com with SMTP id z128so2357837pgb.0 for ; Thu, 23 Feb 2017 15:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=I+YMqE4VbC75Rhp769dqkEywMAagdrZ8FduIciSTfgo=; b=guTwI3b9yF3TbM3+LNhovWX4Oq9yGLJGOwaROs7fdKZmhfYiEMmLvr1nA57ClI8J9b Bt4VnO9Iua7f22MVyxIjAutxzd9Vjc0vDoE4Cwc5kHoaArPAEoMK66x9GyhezFIBe83/ ZX2jNfx00xlG7tWo8uA3ykrxMgwqvNyT5Q+EPKVjMfRm8YAH91xj0H9y64gEvevtDNhT 5s7SC73Lxzo4U83RaqY+fnadX6rGbH/g0eZordflbUTSbtsIiGvKfiymFtm+kONsP4Ym jwVJPDlVfGfoLD2w70lC4w5Joo/i++WnLinbjBi1oK8l+scz8vkiXR9IvRgfiGhBhPfX zY/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=I+YMqE4VbC75Rhp769dqkEywMAagdrZ8FduIciSTfgo=; b=WzVERR0Ci4UpHSEjm/jHnMWgagbTcMWFDJJq1VRmKWdnUvLIjDG3IAqxydz6pueQ6/ Zlms9JIMmTP05hdMGtLj/4J6PBmaj+6xYfOtKgl18MaMQsVIBLFuhV/F6mwndX9aRn8l zmKFtPCCDCxRpu/K8Y3x9IQ3jSLmfrkPLTyV+tjnDN9T01ZB3fUvqj5ZgT7LRfn5wtOW xr6lupgAnFNJOSlj4jONk7EEMICglA0ZHMi96OwVbPMP6yNxur9c217czhDxoAHbHnzB 4OZ+EEuenBTGjDZAItFM2DAu1pGTDG0qj3BzW9JWNnWuDGe9ggdEeMq9HsFo7jboxA/Y B7aQ== X-Gm-Message-State: AMke39kozh9lxBGqyv9dqJCMWXC6zNLvLVK+IN0DHf+PBv0FC15bozyeHB91+/oHRzRpfC8C X-Received: by 10.99.223.5 with SMTP id u5mr51029833pgg.58.1487890691942; Thu, 23 Feb 2017 14:58:11 -0800 (PST) Received: from localhost ([2620:0:1000:5b10:ad75:dfc7:8a6:1152]) by smtp.gmail.com with ESMTPSA id y67sm11575484pfa.96.2017.02.23.14.58.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 23 Feb 2017 14:58:11 -0800 (PST) From: Stefan Beller To: sbeller@google.com Cc: git@vger.kernel.org, sandals@crustytoothpaste.net, jrnieder@gmail.com, bmwill@google.com, gitster@pobox.com, novalis@novalis.org Subject: [PATCH 15/15] builtin/checkout: add --recurse-submodules switch Date: Thu, 23 Feb 2017 14:57:35 -0800 Message-Id: <20170223225735.10994-16-sbeller@google.com> X-Mailer: git-send-email 2.12.0.rc1.16.ge4278d41a0.dirty In-Reply-To: <20170223225735.10994-1-sbeller@google.com> References: <20170223225735.10994-1-sbeller@google.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Signed-off-by: Stefan Beller --- Documentation/git-checkout.txt | 7 +++++++ builtin/checkout.c | 28 ++++++++++++++++++++++++++++ t/lib-submodule-update.sh | 33 ++++++++++++++++++++++++--------- t/t2013-checkout-submodule.sh | 5 +++++ 4 files changed, 64 insertions(+), 9 deletions(-) diff --git a/Documentation/git-checkout.txt b/Documentation/git-checkout.txt index 8e2c0662dd..d6399c0af8 100644 --- a/Documentation/git-checkout.txt +++ b/Documentation/git-checkout.txt @@ -256,6 +256,13 @@ section of linkgit:git-add[1] to learn how to operate the `--patch` mode. out anyway. In other words, the ref can be held by more than one worktree. +--[no-]recurse-submodules:: + Using --recurse-submodules will update the content of all initialized + submodules according to the commit recorded in the superproject. If + local modifications in a submodule would be overwritten the checkout + will fail unless `-f` is used. If nothing (or --no-recurse-submodules) + is used, the work trees of submodules will not be updated. + :: Branch to checkout; if it refers to a branch (i.e., a name that, when prepended with "refs/heads/", is a valid ref), then that diff --git a/builtin/checkout.c b/builtin/checkout.c index f174f50303..207ce09771 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@ -21,12 +21,31 @@ #include "submodule-config.h" #include "submodule.h" +static int recurse_submodules = RECURSE_SUBMODULES_DEFAULT; + static const char * const checkout_usage[] = { N_("git checkout [] "), N_("git checkout [] [] -- ..."), NULL, }; +int option_parse_recurse_submodules(const struct option *opt, + const char *arg, int unset) +{ + if (unset) { + recurse_submodules = RECURSE_SUBMODULES_OFF; + return 0; + } + if (arg) + recurse_submodules = + parse_update_recurse_submodules_arg(opt->long_name, + arg); + else + recurse_submodules = RECURSE_SUBMODULES_ON; + + return 0; +} + struct checkout_opts { int patch_mode; int quiet; @@ -1163,6 +1182,9 @@ int cmd_checkout(int argc, const char **argv, const char *prefix) N_("second guess 'git checkout '")), OPT_BOOL(0, "ignore-other-worktrees", &opts.ignore_other_worktrees, N_("do not check if another worktree is holding the given ref")), + { OPTION_CALLBACK, 0, "recurse-submodules", &recurse_submodules, + "checkout", "control recursive updating of submodules", + PARSE_OPT_OPTARG, option_parse_recurse_submodules }, OPT_BOOL(0, "progress", &opts.show_progress, N_("force progress reporting")), OPT_END(), }; @@ -1193,6 +1215,12 @@ int cmd_checkout(int argc, const char **argv, const char *prefix) git_xmerge_config("merge.conflictstyle", conflict_style, NULL); } + if (recurse_submodules != RECURSE_SUBMODULES_OFF) { + git_config(submodule_config, NULL); + if (recurse_submodules != RECURSE_SUBMODULES_DEFAULT) + set_config_update_recurse_submodules(recurse_submodules); + } + if ((!!opts.new_branch + !!opts.new_branch_force + !!opts.new_orphan_branch) > 1) die(_("-b, -B and --orphan are mutually exclusive")); diff --git a/t/lib-submodule-update.sh b/t/lib-submodule-update.sh index 0b26f0e20f..54cd8a6366 100755 --- a/t/lib-submodule-update.sh +++ b/t/lib-submodule-update.sh @@ -756,6 +756,11 @@ test_submodule_forced_switch () { test_submodule_switch_recursing () { command="$1" + RESULT=success + if test "$KNOWN_FAILURE_DIRECTORY_SUBMODULE_CONFLICTS" = 1 + then + RESULT=failure + fi ######################### Appearing submodule ######################### # Switching to a commit letting a submodule appear checks it out ... test_expect_success "$command: added submodule is checked out" ' @@ -865,7 +870,7 @@ test_submodule_switch_recursing () { ' # Replacing a submodule with files in a directory must succeeds # when the submodule is clean - test_expect_success "$command: replace submodule with a directory" ' + test_expect_$RESULT "$command: replace submodule with a directory" ' prolog && reset_work_tree_to_interested add_sub1 && ( @@ -877,7 +882,7 @@ test_submodule_switch_recursing () { ) ' # ... absorbing a .git directory. - test_expect_success "$command: replace submodule containing a .git directory with a directory must absorb the git dir" ' + test_expect_$RESULT "$command: replace submodule containing a .git directory with a directory must absorb the git dir" ' prolog && reset_work_tree_to_interested add_sub1 && ( @@ -905,7 +910,7 @@ test_submodule_switch_recursing () { ' # ... must check its local work tree for untracked files - test_expect_success "$command: replace submodule with a file must fail with untracked files" ' + test_expect_$RESULT "$command: replace submodule with a file must fail with untracked files" ' prolog && reset_work_tree_to_interested add_sub1 && ( @@ -961,16 +966,21 @@ test_submodule_switch_recursing () { ) ' + # This test fails, due to missing setup, we do not clone sub2 into + # submodule_update, because it doesn't exist in the 'add_sub1' version + # test_expect_success "$command: modified submodule updates submodule recursively" ' prolog && reset_work_tree_to_interested add_sub1 && ( cd submodule_update && git branch -t modify_sub1_recursively origin/modify_sub1_recursively && - $command modify_sub1_recursively && - test_superproject_content origin/modify_sub1_recursively && - test_submodule_content sub1 origin/modify_sub1_recursively - test_submodule_content sub1/sub2 + test_must_fail $command modify_sub1_recursively && + test_superproject_content origin/add_sub1 && + test_submodule_content sub1 origin/add_sub1 + # test_superproject_content origin/modify_sub1_recursively && + # test_submodule_content sub1 origin/modify_sub1_recursively && + # test_submodule_content sub1/sub2 no_submodule ) ' } @@ -980,6 +990,11 @@ test_submodule_switch_recursing () { # the superproject as well as the submodule is allowed. test_submodule_forced_switch_recursing () { command="$1" + RESULT=success + if test "$KNOWN_FAILURE_DIRECTORY_SUBMODULE_CONFLICTS" = 1 + then + RESULT=failure + fi ######################### Appearing submodule ######################### # Switching to a commit letting a submodule appear creates empty dir ... test_expect_success "$command: added submodule is checked out" ' @@ -1074,7 +1089,7 @@ test_submodule_forced_switch_recursing () { ) ' # Replacing a submodule with files in a directory ... - test_expect_success "$command: replace submodule with a directory" ' + test_expect_$RESULT "$command: replace submodule with a directory" ' prolog && reset_work_tree_to_interested add_sub1 && ( @@ -1125,7 +1140,7 @@ test_submodule_forced_switch_recursing () { ' # ... but stops for untracked files that would be lost - test_expect_success "$command: replace submodule with a file" ' + test_expect_$RESULT "$command: replace submodule with a file stops for untracked files" ' prolog && reset_work_tree_to_interested add_sub1 && ( diff --git a/t/t2013-checkout-submodule.sh b/t/t2013-checkout-submodule.sh index 6847f75822..aa35223369 100755 --- a/t/t2013-checkout-submodule.sh +++ b/t/t2013-checkout-submodule.sh @@ -63,6 +63,11 @@ test_expect_success '"checkout " honors submodule.*.ignore from .git/ ! test -s actual ' +KNOWN_FAILURE_DIRECTORY_SUBMODULE_CONFLICTS=1 +test_submodule_switch_recursing "git checkout --recurse-submodules" + +test_submodule_forced_switch_recursing "git checkout -f --recurse-submodules" + test_submodule_switch "git checkout" test_submodule_forced_switch "git checkout -f" -- 2.12.0.rc1.16.ge4278d41a0.dirty