From: Eric Wong <e@80x24.org>
To: Hiroshi Shirosaki <h.shirosaki@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git svn branch fails with authenticaton failures
Date: Thu, 23 Feb 2017 20:54:52 +0000 [thread overview]
Message-ID: <20170223205452.GA29547@whir> (raw)
In-Reply-To: <1487731055-29153-1-git-send-email-h.shirosaki@gmail.com>
Hiroshi Shirosaki <h.shirosaki@gmail.com> wrote:
> I have the following authentication failure while svn rebase and
> svn dcommit works fine without authentication failures.
>
> $ git svn branch v7_3
> Copying https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx at r27519
> to https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/v7_3...
> Can't create session: Unable to connect to a repository at URL
> 'https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx': No more
> credentials or we tried too many times.
> Authentication failed at
> C:\Program Files\Git\mingw64/libexec/git-core\git-svn line 1200.
>
> I can workaround the issue to add auth configuration to
> SVN::Client->new().
Missing sign-off (see Documentation/SubmittingPatches).
Not my rule, but it's unfortunately required for this project.
Also, the Subject: should be in the imperative mood,
Perhaps something like:
Subject: [PATCH] git svn: fix authentication with 'branch'
I am less picky about the message body.
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1175,10 +1175,10 @@ sub cmd_branch {
> ::_req_svn();
> require SVN::Client;
>
> + my ($config, $baton, $callbacks) = Git::SVN::Ra::prepare_config_once();
Since we're not using it, here, you can avoid setting a variable
for $callbacks more explicitly:
my ($config, $baton, undef) = Git::SVN::Ra::prepare_config_once();
> my $ctx = SVN::Client->new(
> - config => SVN::Core::config_get_config(
> - $Git::SVN::Ra::config_dir
> - ),
> + auth => $baton,
> + config => $config,
> log_msg => sub {
> ${ $_[0] } = defined $_message
> ? $_message
> --
Anyways, this looks like a good change. I will accept a v2
with your sign-off and changes noted above. Thank you.
prev parent reply other threads:[~2017-02-23 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 2:37 [PATCH] git svn branch fails with authenticaton failures Hiroshi Shirosaki
2017-02-23 20:54 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223205452.GA29547@whir \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=h.shirosaki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).